Paths

Table of Contentst

Differential D38872

bhyve: Exit with EX_OSERR if init checkpoint or restore time failed
ClosedPublic
Actions

Authored by gusev.vitaliy_gmail.com on Mar 2 2023, 6:47 PM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Aug 7, 9:41 AM

	Unknown Object (File)
	Fri, Aug 7, 9:41 AM

	Unknown Object (File)
	Wed, Aug 5, 5:26 PM

	Unknown Object (File)
	Wed, Aug 5, 3:55 AM

	Unknown Object (File)
	Sun, Aug 2, 6:19 AM

	Unknown Object (File)
	Sun, Aug 2, 4:04 AM

	Unknown Object (File)
	Sat, Aug 1, 5:15 AM

	Unknown Object (File)
	Wed, Jul 29, 5:48 PM

Subscribers

Details

Reviewers

markj
jhb
corvink

Group Reviewers

Commits

rG6efb053bea5f: bhyve: exit with EX_OSERR if init checkpoint or restore time failed
rGd213429e42d4: bhyve: exit with EX_OSERR if init checkpoint or restore time failed

Summary

Part of Capsicum integration for snapshots.

Sponsored by: vStack

Test Plan

Run VM, Suspend, Resume.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gusev.vitaliy_gmail.com created this revision.Mar 2 2023, 6:47 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 2 2023, 6:47 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

gusev.vitaliy_gmail.com requested review of this revision.Mar 2 2023, 6:47 PM

gusev.vitaliy_gmail.com mentioned this in D35454: bhyve: snapshot capsicum support.Mar 2 2023, 6:49 PM

gusev.vitaliy_gmail.com mentioned this in D38857: bhyve: Init checkpoint before caph_enter().

gusev.vitaliy_gmail.com added a child revision: D38857: bhyve: Init checkpoint before caph_enter().Mar 2 2023, 8:30 PM

gusev.vitaliy_gmail.com added a parent revision: D38856: bhyve: [snapshot] Add cap limits for ipc socket.

markj accepted this revision as: markj.Mar 2 2023, 10:03 PM

markj added inline comments.

usr.sbin/bhyve/bhyverun.c
1582	pthread_create() returns a positive error number in the failure case, and this check won't catch it. I suspect it should just check `init_checkpoint_thread(ctx) != 0`.

This revision is now accepted and ready to land.Mar 2 2023, 10:03 PM

corvink accepted this revision.Mar 3 2023, 7:04 AM

Fix note, use init_checkpoint_thread(ctx) != 0

This revision now requires review to proceed.Mar 3 2023, 11:47 AM

gusev.vitaliy_gmail.com marked an inline comment as done.Mar 3 2023, 11:48 AM

gusev.vitaliy_gmail.com added inline comments.

usr.sbin/bhyve/bhyverun.c
1582	Done.

@markj @corvink Please re-accept.

markj accepted this revision as: markj.Mar 3 2023, 2:27 PM

This revision is now accepted and ready to land.Mar 3 2023, 2:27 PM

Closed by commit rGd213429e42d4: bhyve: exit with EX_OSERR if init checkpoint or restore time failed (authored by gusev.vitaliy_gmail.com, committed by corvink). · Explain WhyMar 6 2023, 1:06 PM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rGd213429e42d4: bhyve: exit with EX_OSERR if init checkpoint or restore time failed.

corvink added a commit: rG6efb053bea5f: bhyve: exit with EX_OSERR if init checkpoint or restore time failed.Mar 17 2023, 10:31 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

7 lines

Diff 118384

usr.sbin/bhyve/bhyverun.c

Loading...