Page MenuHomeFreeBSD

bhyve: Exit with EX_OSERR if init checkpoint or restore time failed
ClosedPublic

Authored by gusev.vitaliy_gmail.com on Mar 2 2023, 6:47 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Oct 12, 5:49 PM
Unknown Object (File)
Sun, Oct 12, 12:01 PM
Unknown Object (File)
Sun, Oct 12, 6:19 AM
Unknown Object (File)
Sat, Oct 11, 11:04 PM
Unknown Object (File)
Sat, Oct 11, 8:07 PM
Unknown Object (File)
Sat, Oct 11, 8:06 PM
Unknown Object (File)
Sat, Oct 11, 8:06 PM
Unknown Object (File)
Sat, Oct 11, 11:09 AM

Details

Summary

Part of Capsicum integration for snapshots.

Sponsored by: vStack

Test Plan

Run VM, Suspend, Resume.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
usr.sbin/bhyve/bhyverun.c
1582

pthread_create() returns a positive error number in the failure case, and this check won't catch it. I suspect it should just check init_checkpoint_thread(ctx) != 0.

This revision is now accepted and ready to land.Mar 2 2023, 10:03 PM

Fix note, use init_checkpoint_thread(ctx) != 0

This revision now requires review to proceed.Mar 3 2023, 11:47 AM
gusev.vitaliy_gmail.com added inline comments.
usr.sbin/bhyve/bhyverun.c
1582

Done.

This revision is now accepted and ready to land.Mar 3 2023, 2:27 PM