Page MenuHomeFreeBSD
Differential D38886

bhyvectl: send_message() returns garbage
ClosedPublic
Actions

Authored by gusev.vitaliy_gmail.com on Mar 3 2023, 11:37 AM.
Tags
Referenced Files
F132425144: D38886.diff
Thu, Oct 16, 8:07 PM
Unknown Object (File)
Mon, Oct 13, 11:00 PM
Unknown Object (File)
Sat, Oct 11, 8:07 PM
Unknown Object (File)
Sat, Oct 11, 8:07 PM
Unknown Object (File)
Sat, Oct 11, 8:06 PM
Unknown Object (File)
Sat, Oct 11, 8:06 PM
Unknown Object (File)
Sat, Oct 11, 11:09 AM
Unknown Object (File)
Mon, Oct 6, 7:32 PM
View All Files
Subscribers
bcran
elenamihailescu22_gmail.com
imp
rgrimes
bhyve

Details

Reviewers
rew
markj
jhb
corvink
Group Reviewers
bhyve
Commits
rG38b37099bb19: bhyvectl: do not return garbage from send_message
rG89fe7b98fe45: bhyvectl: do not return garbage from send_message
Summary

Variable 'err' is used uninitialized in some cases and returned
as result of function.

Sponsored by: vStack

Test Plan

Compile bhyvectl, run 'bhyvectl --suspend', verify send_message() returns 0 on success.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gusev.vitaliy_gmail.com created this revision.Mar 3 2023, 11:37 AM
Herald added a reviewer: bhyve. · View Herald TranscriptMar 3 2023, 11:37 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
gusev.vitaliy_gmail.com requested review of this revision.Mar 3 2023, 11:37 AM
gusev.vitaliy_gmail.com added a child revision: D38866: libvmm: Add missed ioctl to vm_ioctl_cmds.
markj added inline comments.Mar 3 2023, 2:14 PM
usr.sbin/bhyvectl/bhyvectl.c
1693

When connect() fails, this function returns errno, but here it returns -1. Shouldn't it be consistent?

1710

Shouldn't we set err here?

elenamihailescu22_gmail.com added a subscriber: elenamihailescu22_gmail.com.Mar 3 2023, 2:38 PM
gusev.vitaliy_gmail.com updated this revision to Diff 118256.Mar 3 2023, 2:51 PM

Fixed @markj notes.

gusev.vitaliy_gmail.com marked 2 inline comments as done.Mar 3 2023, 2:51 PM
gusev.vitaliy_gmail.com added inline comments.
usr.sbin/bhyvectl/bhyvectl.c
1693

Done.

1710

Done.

gusev.vitaliy_gmail.com added a child revision: D38889: bhyvectl: Correct socket_fd closing in send_message().Mar 3 2023, 2:54 PM
gusev.vitaliy_gmail.com removed a child revision: D38866: libvmm: Add missed ioctl to vm_ioctl_cmds.
gusev.vitaliy_gmail.com marked 2 inline comments as done.
markj accepted this revision as: markj.Mar 3 2023, 2:58 PM
This revision is now accepted and ready to land.Mar 3 2023, 2:58 PM
corvink accepted this revision.Mar 6 2023, 11:29 AM
Closed by commit rG89fe7b98fe45: bhyvectl: do not return garbage from send_message (authored by gusev.vitaliy_gmail.com, committed by corvink). · Explain WhyMar 6 2023, 1:06 PM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG89fe7b98fe45: bhyvectl: do not return garbage from send_message.
corvink added a commit: rG38b37099bb19: bhyvectl: do not return garbage from send_message.Mar 17 2023, 10:31 AM
gusev.vitaliy_gmail.com mentioned this in D35454: bhyve: snapshot capsicum support.May 15 2023, 5:53 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyvectl/
8 lines

Diff 118378

View Options

usr.sbin/bhyvectl/bhyvectl.c

Loading...