Page MenuHomeFreeBSD
Differential D38856

bhyve: [snapshot] Add cap limits for ipc socket
ClosedPublic
Actions

Authored by gusev.vitaliy_gmail.com on Mar 2 2023, 6:12 PM.
Tags
Referenced Files
F166265919: D38856.id.diff
Wed, Aug 12, 3:09 PM
F166113635: D38856.id118248.diff
Tue, Aug 11, 8:14 PM
Unknown Object (File)
Mon, Aug 10, 10:42 AM
Unknown Object (File)
Mon, Aug 10, 9:25 AM
Unknown Object (File)
Sun, Aug 9, 3:05 PM
Unknown Object (File)
Sun, Aug 9, 1:22 AM
Unknown Object (File)
Sat, Aug 8, 4:39 AM
Unknown Object (File)
Sat, Aug 8, 3:58 AM
View All Files
Subscribers
bcran
imp
jonathan
rgrimes
bhyve

Details

Reviewers
corvink
markj
jhb
Group Reviewers
bhyve
Commits
rG2193f12bf8db: bhyve: add cap limits for ipc socket
rG577ddca90877: bhyve: add cap limits for ipc socket
Summary

Part of Capsicum integration for snapshots.

Sponsored by: vStack

Test Plan

Compile, Run VM, Suspend, Resume.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gusev.vitaliy_gmail.com created this revision.Mar 2 2023, 6:12 PM
Herald added a reviewer: bhyve. · View Herald TranscriptMar 2 2023, 6:12 PM
Herald added subscribers: bcran, jonathan, rgrimes, imp. · View Herald Transcript
gusev.vitaliy_gmail.com requested review of this revision.Mar 2 2023, 6:12 PM
gusev.vitaliy_gmail.com mentioned this in D35454: bhyve: snapshot capsicum support.Mar 2 2023, 6:49 PM
gusev.vitaliy_gmail.com added a child revision: D38872: bhyve: Exit with EX_OSERR if init checkpoint or restore time failed.Mar 2 2023, 8:30 PM
gusev.vitaliy_gmail.com added a parent revision: D38855: bhyve: [snapshot] Do not flush readonly device at blockif_pause().
markj accepted this revision as: markj.Mar 2 2023, 9:58 PM
markj added inline comments.
usr.sbin/bhyve/snapshot.c
1522

There should be a newline between variable declarations and code.

This revision is now accepted and ready to land.Mar 2 2023, 9:58 PM
corvink accepted this revision.Mar 3 2023, 7:02 AM
gusev.vitaliy_gmail.com updated this revision to Diff 118248.Mar 3 2023, 11:45 AM

Add empty line after #endif

This revision now requires review to proceed.Mar 3 2023, 11:45 AM
gusev.vitaliy_gmail.com marked an inline comment as done.Mar 3 2023, 11:45 AM
gusev.vitaliy_gmail.com added inline comments.
usr.sbin/bhyve/snapshot.c
1522

Done.

gusev.vitaliy_gmail.com marked an inline comment as done.Mar 3 2023, 12:06 PM

@markj @corvink Please re-accept.

markj accepted this revision as: markj.Mar 3 2023, 2:18 PM
This revision is now accepted and ready to land.Mar 3 2023, 2:18 PM
Closed by commit rG577ddca90877: bhyve: add cap limits for ipc socket (authored by gusev.vitaliy_gmail.com, committed by corvink). · Explain WhyMar 6 2023, 1:06 PM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG577ddca90877: bhyve: add cap limits for ipc socket.
corvink added a commit: rG2193f12bf8db: bhyve: add cap limits for ipc socket.Mar 17 2023, 10:31 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
10 lines

Diff 118383

View Options

usr.sbin/bhyve/snapshot.c

Loading...