IfAPI: Style cleanup

[jhibbits]

Summary

Casts to (struct ifnet *) made sense when if_t was a void *, but
since it's a struct ifnet * it no longer makes sense. Also remove
pointless conditionals in if_setcapenable().

Sponsored by: Juniper Networks, Inc.

[kib]

A lot of functions return int and that boils down to return (0);. Do you intend to make the fail in some way in the future? If yes, could you please describe what are the expected failure modes?

sys/net/if.c

4197–4198

Remove no longer needed blank line as well?

4211–4212

Blank line is not needed, there and below everywhere

4219

There and everywhere

4296

Since you checked the length, what is the point of using strlcpy() instead of strcpy()?

[jhibbits]

In D38499#876078, @kib wrote:

A lot of functions return int and that boils down to return (0);. Do you intend to make the fail in some way in the future? If yes, could you please describe what are the expected failure modes?

For many of the new ones that return (0); I was just following the precedent. I think the idea was originally (nearly a decade ago) that the netstack module could return an error on an accessor that doesn't exist. For instance, maybe the netstack doesn't support some capability at all, it could return an error if that capability gets set. @stevek knows better of Juniper's intentions then. I'll at least clean up the functions that simply forward to functions that return void.

[kib]

@glebius My comments were not handled.

[glebius]

Didn't mean to override your comments! I'm pretty sure @jhibbits will address them before checking in.

[jhibbits]

Address @kib's feedback. I think I got them all.

[jhibbits]

In D38499#877645, @glebius wrote:

Didn't mean to override your comments! I'm pretty sure @jhibbits will address them before checking in.

I did take care of all of them, but neglected to update the review once I did.

[kib]

sys/net/if.c

4651

4696

This can be written simpler as this

4708

Is the cast still needed?

4714

Again, the q about the cast.

4730

There should be blank line between decl and body block, and perhaps no blank line before return.

4839

Why the cast is needed?

In fact, I suspect that casting the function pointer through an object pointer is UB, just not sure about a possible special case for void *.

4851

Same

[jhibbits]

sys/net/if.c

4651

Odd, I thought I got all the naked returns.

4696

I was going with that first, but figured "!=" is a boolean result, so went explicit. I'll drop it.

4839

Ancient code (2014). Cleaning it up.

[jhibbits]

Address more feedback from @kib.

[jhibbits]

One more whitespace bug.

[kib]

Thank you