Paths

Table of Contentst

Differential D37209

tcp_rack: Add a manual page
ClosedPublic
Actions

Authored by gbe on Oct 29 2022, 7:49 PM.

Tags

None

Referenced Files

	F171171053: D37209.id112719.diff
	Wed, Sep 9, 5:27 AM

	Unknown Object (File)
	Tue, Sep 8, 2:26 AM

	Unknown Object (File)
	Tue, Sep 8, 2:26 AM

	Unknown Object (File)
	Sun, Sep 6, 6:05 PM

	Unknown Object (File)
	Sun, Sep 6, 12:03 PM

	Unknown Object (File)
	Sun, Sep 6, 7:10 AM

	Unknown Object (File)
	Fri, Sep 4, 3:41 PM

	Unknown Object (File)
	Fri, Sep 4, 1:29 AM

Subscribers

pauamma_chezdork.com

Details

Reviewers

tuexen
rrs
pauamma_chezdork.com

Group Reviewers

Commits

rGb1bcde8605fa: tcp_rack: Add a manual page
rGbdbc05bea995: tcp_rack: Add a manual page

Summary

Add a manual page for tcp_rack(4)
Link it in tcp(4) and tcp_bbr(4)

MFC after: 2 weeks

Test Plan

mandoc output review and mandoc '-Tlint' checks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gbe created this revision.Oct 29 2022, 7:49 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 29 2022, 7:49 PM

gbe requested review of this revision.Oct 29 2022, 7:49 PM

Harbormaster completed remote builds in B48089: Diff 112387.Oct 29 2022, 7:49 PM

pauamma_chezdork.com requested changes to this revision.Oct 29 2022, 10:16 PM

pauamma_chezdork.com added a subscriber: pauamma_chezdork.com.

pauamma_chezdork.com added inline comments.

share/man/man4/tcp_rack.4
34	Also, "stack" feels wrong to me since this is about a module, not all of TCP, whether TCP is a stack by itself regardless. If not "module", maybe "algorithm"?
40	Is it a driver?
46	See above re "stack".
102	The variables below are in `net.inet.tcp.rack`, not `net.inet.tcp.bbr`.

This revision now requires changes to proceed.Oct 29 2022, 10:16 PM

Some Corrections

Harbormaster completed remote builds in B48093: Diff 112401.Oct 30 2022, 7:32 AM

Mark some inline comments as done.

Reword sentence

Harbormaster completed remote builds in B48181: Diff 112667.Nov 6 2022, 10:04 AM

Reword sentence

Harbormaster completed remote builds in B48182: Diff 112668.Nov 6 2022, 10:07 AM

Address comments

share/man/man4/tcp_rack.4
34	"Stack" is more common word in this field, since we already have WITH_EXTRA_TCP_STACKS and so on.

pauamma_chezdork.com accepted this revision.Nov 6 2022, 12:52 PM

This revision is now accepted and ready to land.Nov 6 2022, 12:52 PM

Closed by commit rGbdbc05bea995: tcp_rack: Add a manual page (authored by gbe). · Explain WhyNov 7 2022, 11:29 AM

This revision was automatically updated to reflect the committed changes.

gbe added a commit: rGbdbc05bea995: tcp_rack: Add a manual page.

gbe added a commit: rGb1bcde8605fa: tcp_rack: Add a manual page.Nov 21 2022, 7:22 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

1 line

3 lines

5 lines

159 lines

Diff 112719

share/man/man4/Makefile

Loading...

share/man/man4/tcp.4

Loading...

share/man/man4/tcp_bbr.4

Loading...

share/man/man4/tcp_rack.4

Loading...