Details

Reviewers

thj
tuexen
jtl
rrs
glebius

Group Reviewers

transport

Commits

rGdd35207e2025: tcp: finish SACK loss recovery on sudden lack of SACK blocks
rG2b8ee332b938: tcp: finish SACK loss recovery on sudden lack of SACK blocks
rG3d0b768cc0a0: tcp: finish SACK loss recovery on sudden lack of SACK blocks
rGc21b7b55bea2: tcp: finish SACK loss recovery on sudden lack of SACK blocks

Summary

While a receiver should continue sending SACK blocks for the
duration of a SACK loss recovery, if for some reason the
TCP options no longer contain these SACK blocks, but we
already started maintaining the Scoreboard, keep on handling
incoming ACKs (without SACK) as belonging to the SACK recovery.

This should mitigate an issue with some clients.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Aug 4 2022, 6:48 PM

Herald added a reviewer: transport. · View Herald TranscriptAug 4 2022, 6:48 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Aug 4 2022, 6:48 PM

Harbormaster completed remote builds in B46748: Diff 108890.Aug 4 2022, 6:48 PM

missed closing bracket, and PRR conditional

Harbormaster completed remote builds in B46749: Diff 108892.Aug 4 2022, 6:56 PM

tuexen accepted this revision.Aug 11 2022, 3:27 PM

This revision is now accepted and ready to land.Aug 11 2022, 3:27 PM

Will modify the 3 conditionals to an inline function, with added comments to the two corner cases (RTO when only pure non-SACK dupacks get received; RTO when client renegs receive buffer - and stops sending SACK blocks