nvme: Define NVME_MPS_SHIFT
ClosedPublic
Actions

Authored by imp on Apr 10 2022, 5:11 PM.

Tags

None

Referenced Files

	F132302801: D34865.id.diff
	Wed, Oct 15, 5:03 PM

	F132302796: D34865.id105063.diff
	Wed, Oct 15, 5:03 PM

	F132302788: D34865.id104841.diff
	Wed, Oct 15, 5:02 PM

	Unknown Object (File)
	Wed, Oct 15, 6:23 AM

	Unknown Object (File)
	Tue, Sep 23, 12:05 AM

	Unknown Object (File)
	Aug 30 2025, 2:47 AM

	Unknown Object (File)
	Aug 14 2025, 11:24 PM

	Unknown Object (File)
	Aug 14 2025, 11:01 PM

View All 93 Files

Subscribers

dab

Details

Reviewers

mav
chuck
gallatin
chs
andrew
jimharris
rpokala

Commits

rGe66c1b51850c: nvme: Define NVME_MPS_SHIFT

Summary

The memory page size (MPS) is expressed in terms of a 2^(number + 12)
and other items in the system inherit this. Create a define rather than
sprinkling 12 everywehere.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Apr 10 2022, 5:11 PM

Herald added a subscriber: dab. · View Herald TranscriptApr 10 2022, 5:11 PM

imp requested review of this revision.Apr 10 2022, 5:11 PM

Harbormaster completed remote builds in B45106: Diff 104841.Apr 10 2022, 5:11 PM

imp added a child revision: D34866: nvme: Fix old intel alignment size.Apr 10 2022, 5:11 PM

chuck accepted this revision.Apr 14 2022, 2:43 PM

This revision is now accepted and ready to land.Apr 14 2022, 2:43 PM

Closed by commit rGe66c1b51850c: nvme: Define NVME_MPS_SHIFT (authored by imp). · Explain WhyApr 15 2022, 8:47 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGe66c1b51850c: nvme: Define NVME_MPS_SHIFT.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme.h

3 lines

Diff 105063

View Options

nvme: Define NVME_MPS_SHIFTClosedPublicActions