nvme: Use saved mps when initializing drive
ClosedPublic
Actions

Authored by imp on Apr 10 2022, 5:11 PM.

Details

Reviewers

mav
chuck
gallatin
chs
andrew
jimharris
rpokala

Commits

rG3a468f201062: nvme: Use saved mps when initializing drive

Summary

Make sure we set the MPS we cached (currently the drives minimum mps) in
CC (Controller Configuration) when reinitializing the drive. It must
match the page_size that we're going to use.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Apr 10 2022, 5:11 PM

Herald added a subscriber: dab. · View Herald TranscriptApr 10 2022, 5:11 PM

imp requested review of this revision.Apr 10 2022, 5:11 PM

Harbormaster completed remote builds in B45110: Diff 104845.Apr 10 2022, 5:11 PM

imp added a parent revision: D34868: nvme: Rename min_page_size to page_size and save mps.Apr 10 2022, 5:11 PM

imp added a child revision: D34870: nvme: Remove NVME_MAX_XFER_SIZE, replace inline calculation.

Retire NVME_PAGE_SHIFT... It wasn't quite the right name for this.

Harbormaster completed remote builds in B45115: Diff 104850.Apr 10 2022, 5:15 PM

chuck accepted this revision.Apr 14 2022, 3:49 PM

chuck added inline comments.

sys/dev/nvme/nvme_ctrlr.c
392	A re-wording suggestion: Use the Memory Page Size selected during device initialization. Note that value stored in mps is suitable to use here without adjusting by NVME_MPS_SHIFT.