Page MenuHomeFreeBSD

ifnet: use ck_pr(3) store & load setting ifnet pointer in ifindex
ClosedPublic

Authored by glebius on Dec 4 2021, 9:15 PM.

Details

Summary

The lockless access to the array is protected by the network epoch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 43139
Build 40027: arc lint + arc unit

Event Timeline

I think there should only be one function for "store" pointer which is ifnet_setbyindex(); that'll be possible if you consider my comment from D33259; though in the longer term it probably won't matter to have the other one for ifindex_free() as we'd still guarantee that all accesses go through wrapper functions so we can keep changing the internals.

If you can explain the added WASSERT I am fine with this.

sys/net/if.c
416

Contrary to your description, why do you need to add this suddenly here?

sys/net/if.c
416

Can be removed, but it still removed when all index allocation bits are merged into one in D33262

This revision is now accepted and ready to land.Dec 6 2021, 10:48 AM