Page MenuHomeFreeBSD
Differential D33260

ifnet: use ck_pr(3) store & load setting ifnet pointer in ifindex
ClosedPublic
Actions

Authored by glebius on Dec 4 2021, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 26, 5:38 PM
Unknown Object (File)
Wed, Jun 25, 3:08 PM
Unknown Object (File)
Wed, Jun 25, 2:59 PM
Unknown Object (File)
Wed, Jun 25, 2:35 PM
Unknown Object (File)
Wed, Jun 25, 10:23 AM
Unknown Object (File)
Tue, Jun 24, 7:04 PM
Unknown Object (File)
Sun, Jun 15, 10:59 AM
Unknown Object (File)
Tue, Jun 10, 10:20 PM
View All 89 Files
Subscribers
ae
imp
melifaro

Details

Reviewers
bz
kp
Group Reviewers
network
Commits
rG450394af27bc: ifnet: use ck_pr(3) store & load setting ifnet pointer in ifindex
Summary

The lockless access to the array is protected by the network epoch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43139
Build 40027: arc lint + arc unit

Event Timeline

glebius created this revision.Dec 4 2021, 9:15 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptDec 4 2021, 9:15 PM
glebius requested review of this revision.Dec 4 2021, 9:15 PM
Harbormaster completed remote builds in B43139: Diff 99448.Dec 4 2021, 9:15 PM
glebius added a parent revision: D33259: ifnet: allocate index at the end of if_alloc_domain().Dec 4 2021, 9:15 PM
glebius added a child revision: D33261: ifnet: initial if_grow() shall always succeed.
bz added a comment.Dec 5 2021, 5:52 PM

I think there should only be one function for "store" pointer which is ifnet_setbyindex(); that'll be possible if you consider my comment from D33259; though in the longer term it probably won't matter to have the other one for ifindex_free() as we'd still guarantee that all accesses go through wrapper functions so we can keep changing the internals.

If you can explain the added WASSERT I am fine with this.

sys/net/if.c
416

Contrary to your description, why do you need to add this suddenly here?

glebius added inline comments.Dec 5 2021, 5:57 PM
sys/net/if.c
416

Can be removed, but it still removed when all index allocation bits are merged into one in D33262

kp accepted this revision as: kp.Dec 6 2021, 10:48 AM
This revision is now accepted and ready to land.Dec 6 2021, 10:48 AM
Closed by commit rG450394af27bc: ifnet: use ck_pr(3) store & load setting ifnet pointer in ifindex (authored by glebius). · Explain WhyDec 6 2021, 5:33 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG450394af27bc: ifnet: use ck_pr(3) store & load setting ifnet pointer in ifindex.

Revision Contents
Changeset List

PathSize
sys/
net/
8 lines

Diff 99448

View Options

sys/net/if.c

Loading...