Page MenuHomeFreeBSD
Differential D30926

Eliminate p_elf_machine from struct proc.
ClosedPublic
Actions

Authored by dchagin on Jun 28 2021, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 11, 4:48 AM
Unknown Object (File)
Mon, May 11, 4:47 AM
Unknown Object (File)
Mon, May 11, 4:47 AM
Unknown Object (File)
Sun, May 10, 3:41 AM
Unknown Object (File)
Fri, May 8, 7:25 PM
Unknown Object (File)
Sun, May 3, 6:35 PM
Unknown Object (File)
Sat, Apr 25, 5:04 PM
Unknown Object (File)
Tue, Apr 21, 10:40 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
kib
jhb
Commits
rGb4b67e41443f: Eliminate p_elf_machine from struct proc.
rG5d9f790191fe: Eliminate p_elf_machine from struct proc.
Summary

Instead of p_elf_machine use machine member of the Elf_Brandinfo which is now
cached in the struct proc at p_elf_brandinfo member.

As p_elf_flags alignment is 8 bytes here is a hole, should I remove p_reserved?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin created this revision.Jun 28 2021, 5:25 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 28 2021, 5:25 PM
dchagin requested review of this revision.Jun 28 2021, 5:25 PM
Harbormaster completed remote builds in B40146: Diff 91446.Jun 28 2021, 5:25 PM
dchagin added reviewers: markj, kib.Jun 28 2021, 5:31 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
dchagin added a reviewer: jhb.Jun 28 2021, 5:34 PM
kib accepted this revision.Jun 28 2021, 5:56 PM
kib added inline comments.
sys/sys/proc.h
702–703

We do not leave the cruft in system structures (in HEAD), even if it is padding.

This revision is now accepted and ready to land.Jun 28 2021, 5:56 PM
markj accepted this revision.Jun 28 2021, 11:44 PM

+1 to kib's comment.

Closed by commit rG5d9f790191fe: Eliminate p_elf_machine from struct proc. (authored by dchagin). · Explain WhyJun 29 2021, 5:20 PM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG5d9f790191fe: Eliminate p_elf_machine from struct proc..
dchagin added a commit: rGb4b67e41443f: Eliminate p_elf_machine from struct proc..Jun 17 2022, 7:33 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
5 lines
2 lines
sys/
1 line

Diff 91513

View Options

sys/kern/imgact_elf.c

Loading...
View Options

sys/kern/kern_thread.c

Loading...
View Options

sys/sys/proc.h

Loading...