Page MenuHomeFreeBSD

Eliminate p_elf_machine from struct proc.
ClosedPublic

Authored by dchagin on Jun 28 2021, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 12:06 AM
Unknown Object (File)
Sat, Oct 4, 5:21 AM
Unknown Object (File)
Sat, Sep 27, 8:59 AM
Unknown Object (File)
Wed, Sep 24, 11:54 PM
Unknown Object (File)
Sep 3 2025, 5:56 AM
Unknown Object (File)
Aug 18 2025, 2:43 AM
Unknown Object (File)
Aug 8 2025, 12:01 PM
Unknown Object (File)
Aug 7 2025, 8:04 AM
Subscribers

Details

Summary

Instead of p_elf_machine use machine member of the Elf_Brandinfo which is now
cached in the struct proc at p_elf_brandinfo member.

As p_elf_flags alignment is 8 bytes here is a hole, should I remove p_reserved?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/sys/proc.h
702–703

We do not leave the cruft in system structures (in HEAD), even if it is padding.

This revision is now accepted and ready to land.Jun 28 2021, 5:56 PM
This revision was automatically updated to reflect the committed changes.