Page MenuHomeFreeBSD

Eliminate p_elf_machine from struct proc.
ClosedPublic

Authored by dchagin on Jun 28 2021, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 12, 2:28 PM
Unknown Object (File)
Mon, Mar 9, 2:42 AM
Unknown Object (File)
Sun, Mar 8, 11:23 AM
Unknown Object (File)
Fri, Feb 27, 5:48 AM
Unknown Object (File)
Sun, Feb 22, 3:30 PM
Unknown Object (File)
Feb 8 2026, 3:22 PM
Unknown Object (File)
Feb 8 2026, 2:42 PM
Unknown Object (File)
Jan 30 2026, 10:37 PM
Subscribers

Details

Summary

Instead of p_elf_machine use machine member of the Elf_Brandinfo which is now
cached in the struct proc at p_elf_brandinfo member.

As p_elf_flags alignment is 8 bytes here is a hole, should I remove p_reserved?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/sys/proc.h
702–703

We do not leave the cruft in system structures (in HEAD), even if it is padding.

This revision is now accepted and ready to land.Jun 28 2021, 5:56 PM
This revision was automatically updated to reflect the committed changes.