Differential D27906

if_vtnet: improve and cleanup the receive code
ClosedPublic
Actions

Authored by bryanv on Jan 2 2021, 8:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Oct 21 2024, 6:50 AM

	Unknown Object (File)
	Oct 5 2024, 4:08 AM

	Unknown Object (File)
	Oct 4 2024, 7:07 AM

	Unknown Object (File)
	Oct 3 2024, 10:04 AM

	Unknown Object (File)
	Oct 3 2024, 12:18 AM

	Unknown Object (File)
	Oct 2 2024, 5:07 AM

	Unknown Object (File)
	Sep 26 2024, 7:52 AM

	Unknown Object (File)
	Sep 26 2024, 4:12 AM

View All 54 Files

Subscribers

Details

Reviewers

Commits

rGfa7ca1e33241: if_vtnet: Rx path cleanup

Summary

Fix the NEEDS_CSUM and DATA_VALID checksum flags. The NEEDS_CSUM checksum is incomplete (partial) so offer a fallback for the driver to calculate the checksum. Simplify DATA_VALID because we know the host has validated the checksum.
Default 4K mbuf clusters for mergeable buffers. May need to scale this down to 2K clusters in certain configurations such many queue pairs, big queues (like 4096 in GCP), and low memory.
Use the MTU when calculated the receive mbuf cluster size when not doing TSO/LRO. This will need more adjustment once the MTU feature is supported.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bryanv created this revision.Jan 2 2021, 8:56 PM

bryanv held this revision as a draft.

Herald added a subscriber: imp. · View Herald TranscriptJan 2 2021, 8:56 PM

Harbormaster completed remote builds in B35871: Diff 81529.Jan 2 2021, 8:56 PM

bryanv edited the summary of this revision. (Show Details)Jan 2 2021, 8:56 PM

bryanv added a reviewer: grehan.

bryanv published this revision for review.Jan 2 2021, 9:59 PM

debdrup added a subscriber: debdrup.Jan 6 2021, 12:43 PM

debdrup added inline comments.

sys/dev/virtio/network/if_vtnet.c
1384–1385	Minor nit

This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2021, 5:11 AM

Closed by commit rGfa7ca1e33241: if_vtnet: Rx path cleanup (authored by bryanv). · Explain Why

This revision was automatically updated to reflect the committed changes.

bryanv added a commit: rGfa7ca1e33241: if_vtnet: Rx path cleanup.

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

network/

568 lines

39 lines

Diff 82533

sys/dev/virtio/network/if_vtnet.c

Loading...

sys/dev/virtio/network/if_vtnetvar.h

Loading...