yay!

Updated to compile and work with the new ifabi changes.

Thanks for the heads up! Looking into it...

hi! I just tried compiling this on -HEAD (to land it today!) and it failed; it looks like you need to go adapt it to the iflib/ifnet changes (ie, that hid struct ifnet behind if_private.h.)

Integrate suggestions from Zhenlei Huang (zlei@); thank you!

The manpage changes look great to me!

In D48167#1103394, @ziaee wrote:

I'm so excited to test this driver this weekend! Thank you so much for submitting this! All of the suggestions I made are to bring it into alignment with the rest of the freebsd manual and are specified in the manual page style guide, style.mdoc(5). Sorry I'm so late.

This change applies the rest of the changes suggested to the manual pages.

I'm so excited to test this driver this weekend! Thank you so much for submitting this! All of the suggestions I made are to bring it into alignment with the rest of the freebsd manual and are specified in the manual page style guide, style.mdoc(5). Sorry I'm so late.

This update to the diff brings:

Here's what I've got so far for the manual. I ordered some parts to test but they're not all here yet.

In D48167#1103157, @khorben_defora.org wrote:

I am currently looking into adding the SPDX license identifier, but it can also be done in a separate review.

Ok, i'll wait for the SPDX addition and then if I don't get any other feedback I'll land it

In D48167#1103156, @adrian wrote:

I think it's fine as-is to go in the tree, it's been two years and I'd like to see this in before -15.

I think it's fine as-is to go in the tree, it's been two years and I'd like to see this in before -15.

Address feedback from lwhsu@; thanks!

i could forsee someone writing something like a network manager plugin that doesn't specifically just want to call and parse shell output.

Where would it be reused?

(also nice work!)

out of curiousity - what do people think about extracting a bunch of code out of umbctl and stuffing it in a library that can be reused?