Hi rkitover,

zlei, I updated the axe and ure patches based on your review.

Fix style based on zlei's review

Fix style based on zlei's review

A couple of minor style(9) fixes

I've made the changes you suggested zlei, I will update the axe and ure patches as well.

Style fixes based on zlei's review

Style fixes based on zlei's review

In D55631#1285161, @kevlo wrote:

In D55631#1284650, @bms wrote:

I was able to obtain an axge(4) compatible USB3 adapter for ~6GBP from Amazon.

Is the chipset ax88279? If so, could you send me the link to the product so
I can buy one? Thanks.

Do you know of other drivers that would benefit from this patch that you have access to hardware for?

PS: I bought a USB adapter ( AX88179A ) but were not able to repeat ( with stress tests for about two days ).

In D55631#1284650, @bms wrote:

I was able to obtain an axge(4) compatible USB3 adapter for ~6GBP from Amazon.

Does anyone know how I can get an adapter or hub device with the C variant chip (latest revision?)

Hi bms,

I was able to obtain an axge(4) compatible USB3 adapter for ~6GBP from Amazon.

Hi sanpei,

I have tested the updated if_axge driver with several devices.
In my environments, the issues with link flaps have been resolved(even added changing axge_miibus_statchg, there is "no" spurious link down message. Same as axe I don't know why??) .

I can reproduce below steps

I have tested the updated if_axe driver with several devices.
In my environments, the issues with link flaps have been resolved(even added changing axe_miibus_statchg, there is "no" spurious link down message. I don't know why??) .

I'd be happy to review this, but I need reproduction steps.

Posted patch to lock MII bus:

FYI
I have created and am currently testing a patch that includes "Lock-mii-bus-operation" for 15.0-RELEASE. (Link: patch)
I ported some parts from the axge driver (specifically the changes around ure_attach at line 515).

I have tested the ure driver across several environments. Here are the results:

I will try new patch with axe and axge and report it. Thanks!!

I've updated the axge patch with this fix.

Add lock to serialize MII bus operations

I added a lock for the MII bus, and it seems to have fixed this problem.

Lock MII bus operations

I have reproduced the bug on my laptop.

Thank you for testing,

FYI: My testing methodology

Hardware: ASIX Electronics Corp. AX88772 (BUFFALO LUA3-U2-ATX, 100Base Ethernet)
Tested on: Raspberry Pi 4(16-current), Raspberry Pi Zero 2W(15.0-RELEASE), Pine64(15.0-RELEASE)

I posted the axe patch:

Hi Adrian,

this is good work! i would like to figure out how to describe the "why" this extra stuff is necessary though, so lemme noodle on that a bit first.

LGTM

Another style(9) update

I have confirmation from someone in the bug thread that the patch works:

Thank you pouria!

In D55682#1276464, @pouria wrote:

I've to apply your patch again and wait to see the new logs.
Will tell you.

In D55682#1278294, @rkitover_gmail.com wrote:

Apologies if I'm being impatient, but when does the patch go into the tree?