Superseded by D52861 and D52862

rebase

More typo fixes and drop __FBSDID tags

Roll typo fixes into this revision

thanks for your review!

Remove nhi_compat.h, typo

I give this a quick look over and left a couple of comments/questions. That said, I think it's reasonable to commit this to the tree and iterate on it there.

Accept all USB4 class PCI devices in nhi_pci_probe

Fixes

Fixes

Stuck on athn_usb_detach code or executes athn_usb_stop multiple times
I suspect this is due to the msleep on one threat and a wakeup on another, but I am not certain how to isolate the problem.

Current Problem: Running into a recursive mutex based on FreeBSD/OpenBSD mutex styles.

Working to update the athn_usb_init, currently working through the newstate handler.

Add missing router defines.

Don't touch router defines; this should be done in D49452.

In D49884#1137462, @imp wrote:

In D49884#1137457, @lwhsu wrote:

I think the current idea is avoiding directly import firmware file into repo. Perhaps we can separate the firmware out. The current approach is using firmware ports/pkg, before having that, we can just put it somewhere and ask people to grab it and put to the required place, for testing.

Or point them at the linux wireless firmware archive repo....

In D49884#1137457, @lwhsu wrote:

I think the current idea is avoiding directly import firmware file into repo. Perhaps we can separate the firmware out. The current approach is using firmware ports/pkg, before having that, we can just put it somewhere and ask people to grab it and put to the required place, for testing.

I think the current idea is avoiding directly import firmware file into repo. Perhaps we can separate the firmware out. The current approach is using firmware ports/pkg, before having that, we can just put it somewhere and ask people to grab it and put to the required place, for testing.

In D49450#1128475, @imp wrote:

This will take me a while to slog through.
Do you have pointers to online references to USB4 / TB standards you're emplementing?

This will take me a while to slog through.
Do you have pointers to online references to USB4 / TB standards you're emplementing?

I'll take a look once you're done with the planned changes you've flagged.

I want to factor out a notify function first.