Thank you pouria!

In D55682#1276464, @pouria wrote:

I've to apply your patch again and wait to see the new logs.
Will tell you.

In D55682#1278294, @rkitover_gmail.com wrote:

Apologies if I'm being impatient, but when does the patch go into the tree?

Apologies if I'm being impatient, but when does the patch go into the tree?

Remove frozen TX handling, unneeded if link up

I think I can remove the frozen TX fix given that the link doesn't go down, I'll do that and test it out, then update this patch.

Update for style(9)

Fix for style(9)

In D55682#1276829, @rkitover_gmail.com wrote:

Sorry about the style violations, I will read the guide more carefully and adjust both DRs.

Sorry about the style violations, I will read the guide more carefully and adjust both DRs.

In D55682#1276410, @rkitover_gmail.com wrote:

Thanks!

So apparently the issue still manifests for you due to some kind of configuration difference between our systems.

I'd like to fix this as well.

Can you give me your log? Do a:

grep -E 'ure|ue0' /var/log/messages

, may be ue1 depending on configuration.

style.9

So apparently the issue still manifests for you due to some kind of configuration difference between our systems.

In D55682#1276189, @rkitover_gmail.com wrote:

My results are different, are you applying to CURRENT?

Yes

My results are different, are you applying to CURRENT?

In D55682#1274611, @rkitover_gmail.com wrote:

Can you please verify which behaviors happen for you with and without the patch?

Can you please verify which behaviors happen for you with and without the patch?

In D55682#1274609, @pouria wrote:

Despite the Ethernet port being connected, after replugging in the USB dock it reports that ue0 is DOWN, even though the Ethernet lights are on and the other Ethernet endpoint reports connected and UP:

Despite the Ethernet port being connected, after replugging in the USB dock it reports that ue0 is DOWN, even though the Ethernet lights are on and the other Ethernet endpoint reports connected and UP:

% mdo tail -f /var/log/messages
Mar  7 01:20:09 cornelia kernel: ugen0.11: <GenesysLogic USB3.1 Hub> at usbus0
Mar  7 01:20:09 cornelia kernel: uhub3 on uhub0
Mar  7 01:20:09 cornelia kernel: uhub3: <GenesysLogic USB3.1 Hub, class 9/0, rev 3.20/6.63, addr 18> on usbus0
Mar  7 01:20:09 cornelia kernel: uhub3: 4 ports with 4 removable, self powered
Mar  7 01:20:10 cornelia kernel: ugen0.12: <Realtek USB 10/100/1000 LAN> at usbus0
Mar  7 01:20:10 cornelia kernel: ure0 on uhub3
Mar  7 01:20:10 cornelia kernel: ure0: <Realtek USB 10/100/1000 LAN, class 0/0, rev 3.20/31.00, addr 19> on usbus0
Mar  7 01:20:10 cornelia kernel: miibus0: <MII bus> on ure0
Mar  7 01:20:10 cornelia kernel: rgephy0: <RTL8251/8153 1000BASE-T media interface> PHY 0 on miibus0
Mar  7 01:20:10 cornelia kernel: rgephy0:  none, 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT-FDX, 1000baseT-FDX-master, auto
Mar  7 01:20:10 cornelia kernel: ue0: <USB Ethernet> on ure0
Mar  7 01:20:10 cornelia kernel: ue0: Ethernet address: 00:e0:4c:a4:4e:ef
Mar  7 01:20:10 cornelia kernel: ue0: link state changed to DOWN
Mar  7 01:20:10 cornelia kernel: ugen0.13: <GenesysLogic USB2.1 Hub> at usbus0
Mar  7 01:20:10 cornelia kernel: uhub4 on uhub0
Mar  7 01:20:10 cornelia kernel: uhub4: <GenesysLogic USB2.1 Hub, class 9/0, rev 2.10/6.63, addr 20> on usbus0
Mar  7 01:20:11 cornelia kernel: uhub4: 4 ports with 4 removable, self powered

The initial link flaps on device initialization is not fixed by this patch, but, if you run with and without the patch for like an hour or two, you will see the difference.

Unfortunately, even after applying your patch, I still have the issue:

Thank you. I also have:

Update for style(9)

Update for style(9)

Update for style(9)

Fix for style(9)

Remove frozen TX fix, only needed for axge

Started as pull request here:

Thanks @adrian ! I merged this into the tree. Since these functions appear to have existed for a while, I'm going to MFC these too. Thank you so much for this submission and your patience @unitrunker_unitrunker.net!

looks good plz land

Ping, the proposed docs are okay from manpages side, but needs review by someone who understands USB.

Okay, over to USB

D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access.
rebased

D54296: PR 291774: expand range of errors reported by libusb_open(3)
rebased to latest

D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages.
Fixed linter warnings.

Hey Rick! Thanks for the ping. Tip: use the linter,

mandoc -Tlint here/is/the/manual

D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access.
RETURN VALUES

D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access.
punctuation

D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages.
punctuation