Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (595 w, 3 d)

Recent Activity

Yesterday

ngie added inline comments to D52642: kyua: Add "debug -x|--execute cmd" option.
Mon, Dec 29, 8:28 PM
ngie added inline comments to D54326: kern: document no-op handling of syscall number 0 during deregistration.
Mon, Dec 29, 7:57 PM
ngie updated the summary of D54401: clang-format: adjust to sort C++ headers per style(9).
Mon, Dec 29, 6:39 PM
ngie updated subscribers of D54401: clang-format: adjust to sort C++ headers per style(9).
Mon, Dec 29, 6:37 PM
ngie requested review of D54401: clang-format: adjust to sort C++ headers per style(9).
Mon, Dec 29, 6:36 PM
ngie accepted D54016: df: Import tests from NetBSD.
Mon, Dec 29, 1:23 AM

Sun, Dec 28

ngie added inline comments to D54324: kern: document rationale for PRIV_REBOOT usage in kexec_load.
Sun, Dec 28, 10:23 PM
ngie added inline comments to D54326: kern: document no-op handling of syscall number 0 during deregistration.
Sun, Dec 28, 10:20 PM
ngie added a comment to D54374: release.sh: allow GITROOT, etc, to be overridden.

Hmm, I thought the way this worked was that env_setup set defaults and then the config file was sourced to override those values.

Sun, Dec 28, 9:19 PM

Sat, Dec 27

ngie added inline comments to D52642: kyua: Add "debug -x|--execute cmd" option.
Sat, Dec 27, 8:54 PM
ngie added inline comments to D48087: kyua: Add "prepare" command.
Sat, Dec 27, 8:41 PM

Fri, Dec 26

ngie added inline comments to D48087: kyua: Add "prepare" command.
Fri, Dec 26, 6:39 PM
ngie requested changes to D54105: kyua: Add flaky metadata.

Please provide an example (spec) of what you're implementing in the Testing Done section.

Fri, Dec 26, 6:34 PM
ngie accepted D54363: kyua: Make "debug -p" skip writing stdout/stderr to tmp files.
Fri, Dec 26, 6:14 PM
ngie updated the test plan for D54374: release.sh: allow GITROOT, etc, to be overridden.
Fri, Dec 26, 5:51 PM
ngie requested review of D54374: release.sh: allow GITROOT, etc, to be overridden.
Fri, Dec 26, 5:49 PM

Tue, Dec 23

ngie added a comment to D54062: Explicitly normalize on Unix line-endings with FreeBSD sources.

@markj: this change avoids a large amount of grief when building or editing sources on hosts that are incorrectly configured, and/or on Windows hosts. I'm not sure what exactly Linnea did to trigger this, but I assume it had to do with hosting or editing the sources on a Windows box.

Tue, Dec 23, 9:24 PM

Mon, Dec 22

ngie added inline comments to D48087: kyua: Add "prepare" command.
Mon, Dec 22, 8:15 PM
ngie added inline comments to D48872: callbootd: Add man page, update Makefile to install man page, and update usage()..
Mon, Dec 22, 8:13 PM

Thu, Dec 11

ngie accepted D54169: libc/tests/string: improve stpncpy() "bounds" unit test.
Thu, Dec 11, 6:58 AM

Wed, Dec 3

ngie updated the summary of D54062: Explicitly normalize on Unix line-endings with FreeBSD sources.
Wed, Dec 3, 11:54 PM
ngie updated the summary of D54062: Explicitly normalize on Unix line-endings with FreeBSD sources.
Wed, Dec 3, 11:47 PM
ngie retitled D54062: Explicitly normalize on Unix line-endings with FreeBSD sources from Normalize Unix line-endings by default to Explicitly normalize on Unix line-endings with FreeBSD sources.
Wed, Dec 3, 11:44 PM
ngie requested review of D54062: Explicitly normalize on Unix line-endings with FreeBSD sources.
Wed, Dec 3, 11:33 PM

Nov 6 2025

ngie added inline comments to D53591: iwlwifi: fix the gcc build.
Nov 6 2025, 9:45 PM
ngie committed rG2ec6a2e5f011: iwlwifi: fix the gcc build (authored by ngie).
iwlwifi: fix the gcc build
Nov 6 2025, 9:44 PM
ngie closed D53591: iwlwifi: fix the gcc build.
Nov 6 2025, 9:43 PM
ngie added a comment to D53591: iwlwifi: fix the gcc build.

I still think it's a good idea to push ${CWARNFLAGS.${COMPILER_TYPE}.${.IMPSRC:T}} into bsd.sys.mk, but this is ok too.

Nov 6 2025, 9:22 PM
ngie updated the test plan for D53591: iwlwifi: fix the gcc build.
Nov 6 2025, 9:21 PM
ngie updated the test plan for D53591: iwlwifi: fix the gcc build.
Nov 6 2025, 9:20 PM
ngie updated the diff for D53591: iwlwifi: fix the gcc build.

Incorporate feedback from @bz

Nov 6 2025, 9:20 PM
ngie updated the summary of D53591: iwlwifi: fix the gcc build.
Nov 6 2025, 9:19 PM

Nov 5 2025

ngie added a comment to D53591: iwlwifi: fix the gcc build.
In D53591#1223710, @bz wrote:

You do not need the .if if you do it as suggested here:
https://lists.freebsd.org/archives/freebsd-hackers/2025-August/004872.html

Nov 5 2025, 8:59 PM
ngie updated the diff for D53591: iwlwifi: fix the gcc build.

Fix typo spotted by @bz.

Nov 5 2025, 8:55 PM
ngie updated the summary of D53591: iwlwifi: fix the gcc build.
Nov 5 2025, 8:19 PM
ngie updated the diff for D53591: iwlwifi: fix the gcc build.

Incorporate corrections/suggestions from @delphij

Nov 5 2025, 8:15 PM
ngie updated the test plan for D53591: iwlwifi: fix the gcc build.
Nov 5 2025, 8:14 PM
ngie added a comment to D53591: iwlwifi: fix the gcc build.

I think what bz@ really wanted is something like:

.if ${COMPILER_TYPE} == "clang"
CWARNFLAGS.drv.c += -Wno-override-init -Wno-initializer-overrides
.endif

but your change should be sufficient to fix gcc build.

Nov 5 2025, 8:05 PM
ngie accepted D53595: libcrypto: Install tests in the tests package.
Nov 5 2025, 1:45 AM

Nov 4 2025

ngie updated the test plan for D53591: iwlwifi: fix the gcc build.
Nov 4 2025, 11:12 PM
ngie abandoned D53590: iwlwifi: fix the gcc build.

Accidental double-open.

Nov 4 2025, 11:10 PM
ngie requested review of D53591: iwlwifi: fix the gcc build.
Nov 4 2025, 11:09 PM
ngie requested review of D53590: iwlwifi: fix the gcc build.
Nov 4 2025, 10:55 PM
ngie committed rG0d5ef734e91e: crypto/openssl: remove autogenerated files (authored by ngie).
crypto/openssl: remove autogenerated files
Nov 4 2025, 4:06 PM
ngie committed rG9b84a17c0adc: OpenSSL: install .pc files from the exporters subdir (authored by ngie).
OpenSSL: install .pc files from the exporters subdir
Nov 4 2025, 4:06 PM
ngie committed rG9b3c89ce8b2b: openssl: add a simple smoke test for the legacy provider (authored by ngie).
openssl: add a simple smoke test for the legacy provider
Nov 4 2025, 4:06 PM
ngie committed rG57d1d2c49707: crypto/openssl: update to 3.5.4 (authored by ngie).
crypto/openssl: update to 3.5.4
Nov 4 2025, 4:06 PM
ngie committed rG505aec2bf3b1: crypto/openssl: update generated files to match 3.5.4 artifacts (authored by ngie).
crypto/openssl: update generated files to match 3.5.4 artifacts
Nov 4 2025, 4:06 PM
ngie committed rG41955f207f50: crypto/openssl: update build artifacts for the 3.5.3 release (authored by ngie).
crypto/openssl: update build artifacts for the 3.5.3 release
Nov 4 2025, 4:06 PM
ngie committed rG22382d9e706b: crypto/openssl: apply polish to new vendor import process (authored by ngie).
crypto/openssl: apply polish to new vendor import process
Nov 4 2025, 4:06 PM
ngie committed rG779e075df98d: crypto/openssl: update component to 3.5.3 (authored by ngie).
crypto/openssl: update component to 3.5.3
Nov 4 2025, 4:06 PM
ngie committed rG3e979746ab99: Update the installed manpages to match OpenSSL 3.5.1 (authored by ngie).
Update the installed manpages to match OpenSSL 3.5.1
Nov 4 2025, 4:06 PM
ngie created P677 Command-Line Input.
Nov 4 2025, 3:59 PM

Nov 1 2025

ngie added a comment to D53459: go: Force using current toolchain.

At the very least I think it's a good idea to either document what the variable does, or make it into a first-class customizable flag.

Nov 1 2025, 2:16 AM

Oct 31 2025

ngie added a comment to D53459: go: Force using current toolchain.

They're the same toolchains. They're hashed and downloaded as part of do-fetch, from the same servers that Go itself is distributed, so theoretically they should carry the same risk as the Go ports.

I guess what I'm suggesting here is that if the toolchain tarball is under attack, then so is the distfile we'd use to build the Go port. You're definitely NOT wrong about the risk there, but I'm not seeing how falling back to the Go port mitigates it.

Oct 31 2025, 8:17 PM
ngie added a comment to D53459: go: Force using current toolchain.

Supply chain attacks and repeatability seems like the biggest concerns I'd see with not using the locally provided toolchains.

Oct 31 2025, 8:02 PM

Oct 25 2025

ngie accepted D52800: closefrom_test: Convert to atf-c(3).
Oct 25 2025, 11:51 PM

Oct 19 2025

ngie updated the diff for D53190: crypto/openssl: update vendor update instructions.

Fix GH Markdown rendering

Oct 19 2025, 8:02 AM
ngie attached a referenced file: F132718680: FREEBSD-upgrade.md.html.
Oct 19 2025, 7:59 AM
ngie added a comment to D53190: crypto/openssl: update vendor update instructions.

I'll update the rendered attachment once I'm sure there's no additional interest in changing the content of the file.

Oct 19 2025, 7:59 AM
ngie updated the diff for D53190: crypto/openssl: update vendor update instructions.

Fix list item rendering in the Assumptions section.

Oct 19 2025, 7:58 AM
ngie created P676 Command-Line Input.
Oct 19 2025, 7:56 AM
ngie added a comment to D53190: crypto/openssl: update vendor update instructions.

Oct 19 2025, 7:55 AM
ngie updated the test plan for D53190: crypto/openssl: update vendor update instructions.
Oct 19 2025, 7:54 AM
ngie updated the test plan for D53190: crypto/openssl: update vendor update instructions.
Oct 19 2025, 7:54 AM
ngie updated the title for P675 FreeBSD-upgrade.md.html from Command-Line Input to FreeBSD-upgrade.md.html.
Oct 19 2025, 7:52 AM
ngie created P675 FreeBSD-upgrade.md.html.
Oct 19 2025, 7:51 AM
ngie added a comment to P674 Command-Line Input.

Fails to build with the error seen below.
Not specifying PYMUPDF_SETUP_MUPDF_BUILD results in another error after the package tries to build MuPDF from scratch when building components with gmake. The build system is very complex. I feel like they need to use a different build infrastructure/tool than setuptools (cmake?) and they're going way too deep trying to get the build to work within the confines of setuptools, pip, etc.

^[[1m<...>/freebsd-ports/print/py-PyMuPDF/work-py311/pymupdf-1.26.5/src/build/extra.i.cpp:3346:10: ^[[0m^[[0;1;31mfatal error: ^[[0m^[[1m'mupdf/classes2.h' file not found^[[0m^M
 3346 | #include ^[[0;32m"mupdf/classes2.h"^[[0m^M
      | ^[[0;1;32m         ^~~~~~~~~~~~~~~~~~^M                                                                     
^[[0m1 error generated.^M                            
Traceback (most recent call last):^M                                                    
  File "/usr/local/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>^M
    main()^M                                                  
  File "/usr/local/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main^M
    json_out["return_val"] = hook(**hook_input["kwargs"])^M                                                                                                                          
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^M          
  File "/usr/local/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 280, in build_wheel^M                                        
    return _build_backend().build_wheel(^M                                                                               
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^M                               
  File "<...>/freebsd-ports/print/py-PyMuPDF/work-py311/pymupdf-1.26.5/pipcl.py", line 721, in build_wheel^M             
    items = self._call_fn_build(config_settings)^M
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^M
  File "<...>/freebsd-ports/print/py-PyMuPDF/work-py311/pymupdf-1.26.5/pipcl.py", line 1017, in _call_fn_build^M             
    ret = self.fn_build()^M                         
          ^^^^^^^^^^^^^^^^M                
  File "<...>/freebsd-ports/print/py-PyMuPDF/work-py311/pymupdf-1.26.5/setup.py", line 634, in build^M             
    path_so_leaf = _build_extension(^M                               
                   ^^^^^^^^^^^^^^^^^^M                           
  File "<...>/freebsd-ports/print/py-PyMuPDF/work-py311/pymupdf-1.26.5/setup.py", line 1108, in _build_extension^M             
    path_so_leaf = pipcl.build_extension(^M                         
                   ^^^^^^^^^^^^^^^^^^^^^^^M
  File "<...>/freebsd-ports/print/py-PyMuPDF/work-py311/pymupdf-1.26.5/pipcl.py", line 1867, in build_extension^M             
    run_if(^M                            
  File "<...>/freebsd-ports/print/py-PyMuPDF/work-py311/pymupdf-1.26.5/pipcl.py", line 2816, in run_if^M             
    run( command, caller=caller+1)^M     
  File "<...>/freebsd-ports/print/py-PyMuPDF/work-py311/pymupdf-1.26.5/pipcl.py", line 2385, in run^M             
    cp = subprocess.run(^M                                                                                            
         ^^^^^^^^^^^^^^^^M                                                                         
  File "/usr/local/lib/python3.11/subprocess.py", line 571, in run^M
    raise CalledProcessError(retcode, process.args,^M
subprocess.CalledProcessError: Command '$CXX \^M
    -fPIC \^M                                         
    -O2 -DNDEBUG \^M                                
    -I/usr/local/include/python3.11 -I/usr/local/include/python3.11 \^M
    -MD -MF <...>/freebsd-ports/print/py-PyMuPDF/work-py311/pymupdf-1.26.5/src/build/extra.i.cpp.o.d \^M
    -c <...>/freebsd-ports/print/py-PyMuPDF/work-py311/pymupdf-1.26.5/src/build/extra.i.cpp \^M
    -o <...>/freebsd-ports/print/py-PyMuPDF/work-py311/pymupdf-1.26.5/src/build/extra.i.cpp.o \^M
     -Wall -Wno-deprecated-declarations -Wno-unused-const-variable -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -O2 -pipe -fstack-protector-strong -fno-strict-aliasing \^M
    -DPy_LIMITED_API=0x030b0000' returned non-zero exit status 1.^M                                                                   
^M                                                                                                                                                                                                        
^[[91mERROR^[[0m Backend subprocess exited when trying to invoke build_wheel^M
*** Error code 1^M                                                                                               
^M                                                            
Stop.^M                                                     
make: stopped in <...>/freebsd-ports/print/py-PyMuPDF^M
Oct 19 2025, 7:20 AM
ngie added a reviewer for D53190: crypto/openssl: update vendor update instructions: khorben.
Oct 19 2025, 7:11 AM
ngie updated the test plan for D53190: crypto/openssl: update vendor update instructions.
Oct 19 2025, 7:11 AM
ngie created P674 Command-Line Input.
Oct 19 2025, 7:11 AM

Oct 18 2025

ngie requested review of D53190: crypto/openssl: update vendor update instructions.
Oct 18 2025, 7:32 PM

Oct 17 2025

ngie closed D53044: crypto/openssl: remove autogenerated files.
Oct 17 2025, 10:58 AM
ngie closed D53043: OpenSSL: install .pc files from the exporters subdir.
Oct 17 2025, 6:47 AM
ngie committed rG97388e7215e0: OpenSSL: install .pc files from the exporters subdir (authored by ngie).
OpenSSL: install .pc files from the exporters subdir
Oct 17 2025, 6:47 AM
ngie committed rGd271d2ce1524: crypto/openssl: remove autogenerated files (authored by ngie).
crypto/openssl: remove autogenerated files
Oct 17 2025, 6:46 AM
ngie committed rG3b6442370a17: openssl: add a simple smoke test for the legacy provider (authored by ngie).
openssl: add a simple smoke test for the legacy provider
Oct 17 2025, 6:38 AM
ngie closed D53045: openssl: add a simple smoke test for the legacy provider.
Oct 17 2025, 6:37 AM

Oct 13 2025

ngie added a comment to D53045: openssl: add a simple smoke test for the legacy provider.

The test uses OPENSSL_CONF to specify the test config file.

Sorry, I was blind.

Oct 13 2025, 4:52 AM

Oct 12 2025

ngie added a comment to D53045: openssl: add a simple smoke test for the legacy provider.

Does OpenSSL just picks up openssl.conf from current directory?

Oct 12 2025, 10:41 PM
ngie updated the summary of D53045: openssl: add a simple smoke test for the legacy provider.
Oct 12 2025, 4:15 AM
ngie requested review of D53045: openssl: add a simple smoke test for the legacy provider.
Oct 12 2025, 4:12 AM
ngie updated the test plan for D53044: crypto/openssl: remove autogenerated files.
Oct 12 2025, 4:10 AM
ngie updated the test plan for D53044: crypto/openssl: remove autogenerated files.
Oct 12 2025, 4:10 AM
ngie requested review of D53044: crypto/openssl: remove autogenerated files.
Oct 12 2025, 4:08 AM
ngie updated the summary of D53043: OpenSSL: install .pc files from the exporters subdir.
Oct 12 2025, 3:44 AM
ngie requested review of D53043: OpenSSL: install .pc files from the exporters subdir.
Oct 12 2025, 3:03 AM

Oct 10 2025

ngie added inline comments to D52800: closefrom_test: Convert to atf-c(3).
Oct 10 2025, 10:33 PM

Oct 7 2025

ngie committed rGd4033e6d3774: crypto/openssl: update generated files to match 3.5.4 artifacts (authored by ngie).
crypto/openssl: update generated files to match 3.5.4 artifacts
Oct 7 2025, 11:17 PM

Oct 4 2025

ngie committed rG046c625e9382: crypto/openssl: update to 3.5.4 (authored by ngie).
crypto/openssl: update to 3.5.4
Oct 4 2025, 4:01 AM

Oct 2 2025

ngie added inline comments to D52800: closefrom_test: Convert to atf-c(3).
Oct 2 2025, 4:31 AM
ngie added a comment to D52800: closefrom_test: Convert to atf-c(3).

I'll resume looking at this later. Need to get into the right mindset to make sure the conversion looks good.
Just some minor comments while here...

Oct 2 2025, 4:30 AM

Sep 30 2025

ngie accepted D52799: closefrom_test: Fix the first test.
Sep 30 2025, 11:13 PM
ngie committed rG8e12a5c4eb35: openssl: import 3.5.4 (authored by ngie).
openssl: import 3.5.4
Sep 30 2025, 7:15 PM
ngie committed rG12b8f7324509: vendor/openssl: add additional test files for 3.0.18 (authored by ngie).
vendor/openssl: add additional test files for 3.0.18
Sep 30 2025, 7:10 PM
ngie committed rG027bdf0ee383: vendor/openssl: import 3.0.18 (authored by ngie).
vendor/openssl: import 3.0.18
Sep 30 2025, 7:07 PM

Sep 26 2025

ngie committed rG3a4c29b5bed4: GoogleTest: import 1.17.0 (authored by ngie).
GoogleTest: import 1.17.0
Sep 26 2025, 8:37 AM

Sep 24 2025

ngie committed rG08be83a3cb68: Fix the build post-dcf5d5603b3af8 (authored by ngie).
Fix the build post-dcf5d5603b3af8
Sep 24 2025, 10:17 PM
ngie committed rG8782ceb94273: Reduce ifdef soup by adding pre-3.0 compat support (authored by ngie).
Reduce ifdef soup by adding pre-3.0 compat support
Sep 24 2025, 10:17 PM
ngie committed rGa694dad26ba5: factor: support OpenSSL 3 (authored by ngie).
factor: support OpenSSL 3
Sep 24 2025, 10:17 PM