Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (558 w, 4 d)

Recent Activity

Fri, Apr 11

ngie updated the diff for D49724: devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8.

Fix CONFLICTS definition per the Porter's Handbook section on "Using CONFLICTS* With Globs."

Fri, Apr 11, 3:00 AM
ngie updated the diff for D49724: devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8.

Update CONFLICTS_INSTALL to handle the 1.x to 2.x hop cleanly, while forbidding
\*lint1 and \*lint from being installed together.

Fri, Apr 11, 2:56 AM
ngie retitled D49724: devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8 from devel/golintci-lint: upgrade from 1.62.2 to 2.0.2 to devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8.
Fri, Apr 11, 2:52 AM
ngie updated the diff for D49724: devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8.
  • Fork 1.x from 2.x
  • Upgrade 1.x from 1.62.2 to 1.64.8
Fri, Apr 11, 2:52 AM
ngie added a comment to D49723: USES= go: support v2 and higher proxy URLs.

This is a good approach. I'm 👍 on behalf of the go team.

Thanks, Enji!

Fri, Apr 11, 2:13 AM
ngie closed D49723: USES= go: support v2 and higher proxy URLs.
Fri, Apr 11, 2:12 AM
ngie committed R11:0647dd427458: Mk/Uses/go.mk: support v2 and higher proxy URLs (authored by ngie).
Mk/Uses/go.mk: support v2 and higher proxy URLs
Fri, Apr 11, 2:12 AM

Wed, Apr 9

ngie updated the summary of D49724: devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8.
Wed, Apr 9, 3:19 AM
ngie added a comment to D49724: devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8.

Oof... 2.0.2 really finds a lot more issues in code (for better or worse). containerd for instance passes on 1.65.x, but fails on 2.0.2.
Also, 2.0.2 required a config migration (like tox), so it might make more sense to split up the package into 2 different versions.

Wed, Apr 9, 3:19 AM
ngie added a reviewer for D49724: devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8: lcook.
Wed, Apr 9, 2:30 AM
ngie updated the test plan for D49723: USES= go: support v2 and higher proxy URLs.
Wed, Apr 9, 2:30 AM
ngie requested review of D49724: devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8.
Wed, Apr 9, 2:26 AM
ngie requested review of D49723: USES= go: support v2 and higher proxy URLs.
Wed, Apr 9, 2:26 AM

Wed, Apr 2

ngie added a comment to D49633: tests: Require allow_network_access for tests needing name resolution.

I'm in the same boat as @lwhsu : this still doesn't fix the other 3 test cases I mentioned in that are failing though: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285826 .

Wed, Apr 2, 3:40 PM

Tue, Apr 1

ngie committed rG4b98fe9def2d: Fix GoogleTest 1.14.0 import (authored by ngie).
Fix GoogleTest 1.14.0 import
Tue, Apr 1, 5:32 AM
ngie committed rGb84a505d2eae: m4 tests: Update tests after $FreeBSD$ removal (authored by markj).
m4 tests: Update tests after $FreeBSD$ removal
Tue, Apr 1, 2:40 AM
ngie committed rG39775a21add6: tests/netlink: mark a test that requires tun(4) (authored by glebius).
tests/netlink: mark a test that requires tun(4)
Tue, Apr 1, 2:04 AM
ngie committed rGbcd9c0cfb622: getentropy tests: Update after commit 473681a1a506da (authored by markj).
getentropy tests: Update after commit 473681a1a506da
Tue, Apr 1, 1:58 AM

Mon, Mar 31

ngie committed rGebd127c3e36c: file: Support testing multiple magic files. (authored by delphij).
file: Support testing multiple magic files.
Mon, Mar 31, 9:35 PM
ngie committed rG18c4022e9fdc: netbsd-tests: Update a test case to chase grep symlink handling changes (authored by markj).
netbsd-tests: Update a test case to chase grep symlink handling changes
Mon, Mar 31, 9:31 PM
ngie committed rG8d95e941d4cc: netbsd-tests: Update a test case to chase grep symlink handling changes (authored by markj).
netbsd-tests: Update a test case to chase grep symlink handling changes
Mon, Mar 31, 9:30 PM
ngie closed D49574: devel/kyua: update to 0.14.1.
Mon, Mar 31, 9:25 PM
ngie committed R11:dc10385c61dc: devel/kyua: update to 0.14.1 (authored by ngie).
devel/kyua: update to 0.14.1
Mon, Mar 31, 9:25 PM
ngie reopened D49574: devel/kyua: update to 0.14.1.
Mon, Mar 31, 7:06 PM
ngie updated the diff for D49574: devel/kyua: update to 0.14.1.

Restore PORTEPOCH (feedback from bofh)

Mon, Mar 31, 7:06 PM
ngie added a reverting change for D49574: devel/kyua: update to 0.14.1: R11:0b8746e53ed0: devel/kyua: revert update to 0.14.1.
Mon, Mar 31, 7:03 PM
ngie committed R11:0b8746e53ed0: devel/kyua: revert update to 0.14.1 (authored by ngie).
devel/kyua: revert update to 0.14.1
Mon, Mar 31, 7:03 PM
ngie added a reverting change for R11:2922224d0e29: devel/kyua: update to 0.14.1: R11:0b8746e53ed0: devel/kyua: revert update to 0.14.1.
Mon, Mar 31, 7:03 PM
ngie closed D49568: devel/lutok: update to 0.6.1.
Mon, Mar 31, 7:01 PM
ngie committed R11:5836bc5cdf1f: devel/lutok: update to 0.6.1 (authored by ngie).
devel/lutok: update to 0.6.1
Mon, Mar 31, 7:01 PM
ngie closed D49574: devel/kyua: update to 0.14.1.
Mon, Mar 31, 7:00 PM
ngie committed R11:2922224d0e29: devel/kyua: update to 0.14.1 (authored by ngie).
devel/kyua: update to 0.14.1
Mon, Mar 31, 7:00 PM
ngie closed D49573: devel/atf: update to 0.23.
Mon, Mar 31, 7:00 PM
ngie committed R11:e151741c091f: devel/atf: update to 0.23 (authored by ngie).
devel/atf: update to 0.23
Mon, Mar 31, 7:00 PM

Sat, Mar 29

ngie set the repository for D49574: devel/kyua: update to 0.14.1 to R11 FreeBSD ports repository.
Sat, Mar 29, 10:07 PM
ngie set the repository for D49573: devel/atf: update to 0.23 to R11 FreeBSD ports repository.
Sat, Mar 29, 10:07 PM
ngie updated the test plan for D49573: devel/atf: update to 0.23.
Sat, Mar 29, 10:07 PM
ngie updated the test plan for D49568: devel/lutok: update to 0.6.1.
Sat, Mar 29, 10:07 PM
ngie updated subscribers of D49574: devel/kyua: update to 0.14.1.
Sat, Mar 29, 10:05 PM
ngie updated the test plan for D49574: devel/kyua: update to 0.14.1.
Sat, Mar 29, 10:05 PM
ngie added a reviewer for D49573: devel/atf: update to 0.23: bofh.
Sat, Mar 29, 10:03 PM
ngie updated the diff for D49568: devel/lutok: update to 0.6.1.
  • Resolve comments from bofh by replacing USE_GITHUB with the static release artifact URL.
  • Leverage CONFIGURE_ENABLE= instead of the handrolled equivalent with CONFIGURE_ON= and CONFIGURE_OFF=.
Sat, Mar 29, 9:59 PM
ngie requested review of D49574: devel/kyua: update to 0.14.1.
Sat, Mar 29, 9:55 PM
ngie requested review of D49573: devel/atf: update to 0.23.
Sat, Mar 29, 9:55 PM
ngie added inline comments to D49568: devel/lutok: update to 0.6.1.
Sat, Mar 29, 9:54 PM
ngie updated the summary of D49568: devel/lutok: update to 0.6.1.
Sat, Mar 29, 5:49 PM
ngie updated the summary of D49568: devel/lutok: update to 0.6.1.
Sat, Mar 29, 5:49 PM
ngie requested review of D49568: devel/lutok: update to 0.6.1.
Sat, Mar 29, 5:40 PM

Fri, Mar 28

ngie committed rG1b37af092211: Bump .Dd for recently changed aio_*(2) manpages (authored by ngie).
Bump .Dd for recently changed aio_*(2) manpages
Fri, Mar 28, 2:46 AM
ngie committed rGe24279e0f9e2: Remove mentions of ENOSYS added in d97e44784bb5 (authored by ngie).
Remove mentions of ENOSYS added in d97e44784bb5
Fri, Mar 28, 2:41 AM
ngie closed D49541: Remove mentions of ENOSYS added in d97e44784bb5.
Fri, Mar 28, 2:41 AM

Thu, Mar 27

ngie updated the test plan for D49541: Remove mentions of ENOSYS added in d97e44784bb5.
Thu, Mar 27, 7:32 PM
ngie added reviewers for D49541: Remove mentions of ENOSYS added in d97e44784bb5: asomers, ziaee.
Thu, Mar 27, 7:31 PM
ngie requested review of D49541: Remove mentions of ENOSYS added in d97e44784bb5.
Thu, Mar 27, 7:30 PM
ngie committed rG3b496eb1bded: loader: Fix 32-bit compatibility (authored by ahmadkhalifa570_gmail.com).
loader: Fix 32-bit compatibility
Thu, Mar 27, 5:28 PM

Wed, Mar 26

ngie committed rGc15ed41118c9: dumpon: provide diag info when `PEM_read_RSA_PUBKEY` fails (authored by ngie).
dumpon: provide diag info when `PEM_read_RSA_PUBKEY` fails
Wed, Mar 26, 9:37 PM
ngie committed rGd6552ebf26bc: mca_log: add missing breaks when handling thresholds (authored by ngie).
mca_log: add missing breaks when handling thresholds
Wed, Mar 26, 9:35 PM
ngie committed rG30cfebf2f089: mca_log: add missing breaks when handling thresholds (authored by ngie).
mca_log: add missing breaks when handling thresholds
Wed, Mar 26, 9:32 PM
ngie committed rGd5425ed751aa: mptutil: document that disabled/enabled are also supported (authored by ngie).
mptutil: document that disabled/enabled are also supported
Wed, Mar 26, 9:26 PM
ngie committed rGb99e7c46884a: lib/libcrypt: another trivial style change (authored by ngie).
lib/libcrypt: another trivial style change
Wed, Mar 26, 9:19 PM
ngie committed rG62e7a3c6cd67: lib/libcrypt: remove trailing whitespace (authored by ngie).
lib/libcrypt: remove trailing whitespace
Wed, Mar 26, 9:18 PM
ngie committed rGf7d46b858a54: radlib: fix a memory leak in `is_valid_request` (authored by ngie).
radlib: fix a memory leak in `is_valid_request`
Wed, Mar 26, 9:16 PM
ngie committed rGc08ec13bcc71: lib/libsbuf/tests: reformat with `clang-format` (authored by ngie).
lib/libsbuf/tests: reformat with `clang-format`
Wed, Mar 26, 9:14 PM
ngie committed rGf50d338974f2: lib/libsbuf/tests: reformat with `clang-format` (authored by ngie).
lib/libsbuf/tests: reformat with `clang-format`
Wed, Mar 26, 9:13 PM
ngie committed rGa5403c1f7d57: contrib/googletest: update from 1.14.0 to 1.15.2 (authored by ngie).
contrib/googletest: update from 1.14.0 to 1.15.2
Wed, Mar 26, 9:10 PM
ngie committed rGeb331308b0d5: tests/sys/fs/fusefs: include iomanip header (authored by ngie).
tests/sys/fs/fusefs: include iomanip header
Wed, Mar 26, 9:10 PM
ngie committed rG687096cf1e2a: Import GoogleTest 1.14.0 (authored by ngie).
Import GoogleTest 1.14.0
Wed, Mar 26, 6:10 PM
ngie committed rG2adc0bae0b46: fusefs tests: handle -Wdeprecated* issues with GoogleTest 1.14.0 (authored by ngie).
fusefs tests: handle -Wdeprecated* issues with GoogleTest 1.14.0
Wed, Mar 26, 6:09 PM
ngie committed rG69c5f7b4ca36: pkg: Fix Coverity warnings (authored by markj).
pkg: Fix Coverity warnings
Wed, Mar 26, 3:50 PM
ngie closed D49502: aio_*(2): mention ENOSYS under ERRORS.
Wed, Mar 26, 4:51 AM
ngie committed rGd97e44784bb5: aio_*(2): mention ENOSYS under ERRORS (authored by ngie).
aio_*(2): mention ENOSYS under ERRORS
Wed, Mar 26, 4:51 AM
ngie added a comment to D49502: aio_*(2): mention ENOSYS under ERRORS.
In D49502#1128880, @imp wrote:
In D49502#1128871, @imp wrote:

Do you need to mention the SIGSYS issue? Unless you have blocked SIGSYS, any system call that returns ENOSYS will generate that signal.

Good question. It looks like ENOSYS without SIGSYS is the standard in libsys:

% rg -l SIGSYS lib/libsys/*.2 | wc -l
       1
% rg -l ENOSYS lib/libsys/*.2 | wc -l
      24

Ok looks like intro covers it

Wed, Mar 26, 4:47 AM

Tue, Mar 25

ngie added a comment to D49502: aio_*(2): mention ENOSYS under ERRORS.
In D49502#1128871, @imp wrote:

Do you need to mention the SIGSYS issue? Unless you have blocked SIGSYS, any system call that returns ENOSYS will generate that signal.

Tue, Mar 25, 10:38 PM
ngie updated the test plan for D49502: aio_*(2): mention ENOSYS under ERRORS.
Tue, Mar 25, 10:03 PM
ngie requested review of D49502: aio_*(2): mention ENOSYS under ERRORS.
Tue, Mar 25, 10:00 PM
ngie committed rG0d61082e3c64: openssl: update ASM and version info for 3.0.16 import (authored by ngie).
openssl: update ASM and version info for 3.0.16 import
Tue, Mar 25, 9:10 PM
ngie committed rGcb29db243bd0: openssl: Import OpenSSL 3.0.16 (authored by ngie).
openssl: Import OpenSSL 3.0.16
Tue, Mar 25, 9:10 PM
ngie committed rG1d67cec52542: contrib/googletest: update from 1.14.0 to 1.15.2 (authored by ngie).
contrib/googletest: update from 1.14.0 to 1.15.2
Tue, Mar 25, 8:30 PM
ngie committed rG7286b7242c31: tests/sys/fs/fusefs: include iomanip header (authored by ngie).
tests/sys/fs/fusefs: include iomanip header
Tue, Mar 25, 8:30 PM

Mon, Mar 24

ngie added a comment to D49463: kyua: Add "kyua debug -p" option.
  • Could you please verify that this doesn't regress Linux/MacOS?
  • Something like using debugger_ptr_t = std::shared_ptr<debugger> then converting all of the code to use debugger_ptr_t (or maybe just debugger_ptr? I forget the style ATF/kyua uses since I flushed that out of my cache in favor of other garbage :D..) seems like a good idea for clarity/brevity.

I actually have a different proposal.. what if the "automatic cleanup" functionality was opt-out and enabled by default or by a custom policy, e.g.,

  • I want the results from the passed test cases,
  • I want the results from the failed test cases only, or
  • I don't care, clean it up when you're done.

Also, I think that it's honestly better to get the process core and continue on personally. Otherwise you could have resources tied up waiting for a human to push a button.

Mon, Mar 24, 5:02 AM
ngie added inline comments to D49463: kyua: Add "kyua debug -p" option.
Mon, Mar 24, 4:58 AM
ngie updated subscribers of D49463: kyua: Add "kyua debug -p" option.
  • Could you please verify that this doesn't regress Linux/MacOS?
  • Something like using debugger_ptr_t = std::shared_ptr<debugger> then converting all of the code to use debugger_ptr_t seems like a good idea for clarity/brevity.
Mon, Mar 24, 4:52 AM

Sat, Mar 22

ngie accepted D49409: libc/tests: enable getaddrinfo(1) tests from NetBSD.
Sat, Mar 22, 7:44 PM

Mar 15 2025

ngie closed D49296: openssl: Import OpenSSL 3.0.16.
Mar 15 2025, 1:56 AM

Mar 14 2025

ngie committed rG0d0c8621fd18: openssl: Import OpenSSL 3.0.16 (authored by ngie).
openssl: Import OpenSSL 3.0.16
Mar 14 2025, 6:43 AM
ngie committed rGd2a55e6a9348: openssl: update ASM and version info for 3.0.16 import (authored by ngie).
openssl: update ASM and version info for 3.0.16 import
Mar 14 2025, 6:43 AM
ngie closed D49297: openssl: update ASM and version info for 3.0.16 import.
Mar 14 2025, 6:43 AM

Mar 11 2025

ngie updated the diff for D49297: openssl: update ASM and version info for 3.0.16 import.

Update remaining version numbers I missed in prior revision.

Mar 11 2025, 5:14 AM

Mar 10 2025

ngie updated the diff for D49297: openssl: update ASM and version info for 3.0.16 import.

Update the remaining version numbers/strings

Mar 10 2025, 7:53 PM

Mar 8 2025

ngie added a reviewer for D49296: openssl: Import OpenSSL 3.0.16: gordon.
Mar 8 2025, 6:47 PM
ngie updated the summary of D49298: openssl: Import OpenSSL 3.0.16.
Mar 8 2025, 6:47 PM
ngie updated the summary of D49298: openssl: Import OpenSSL 3.0.16.
Mar 8 2025, 6:46 PM
ngie abandoned D49295: openssl: Import OpenSSL 3.0.16.

Double-submitted as D49296.

Mar 8 2025, 6:45 PM
ngie updated the summary of D49296: openssl: Import OpenSSL 3.0.16.
Mar 8 2025, 6:44 PM
ngie updated the diff for D49298: openssl: Import OpenSSL 3.0.16.

Update with the changes in the tree instead of the vendor import commit

Mar 8 2025, 6:43 PM
ngie updated the summary of D49298: openssl: Import OpenSSL 3.0.16.
Mar 8 2025, 6:40 PM
ngie requested review of D49298: openssl: Import OpenSSL 3.0.16.
Mar 8 2025, 6:39 PM
ngie updated the summary of D49297: openssl: update ASM and version info for 3.0.16 import.
Mar 8 2025, 6:38 PM
ngie added a reviewer for D49297: openssl: update ASM and version info for 3.0.16 import: gordon.
Mar 8 2025, 6:38 PM
ngie requested review of D49297: openssl: update ASM and version info for 3.0.16 import.
Mar 8 2025, 6:37 PM