Page MenuHomeFreeBSD

devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8
Needs ReviewPublic

Authored by ngie on Apr 9 2025, 2:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 22, 2:06 PM
Unknown Object (File)
Fri, May 9, 7:43 AM
Unknown Object (File)
Fri, May 2, 5:19 AM
Unknown Object (File)
Apr 27 2025, 2:39 PM
Unknown Object (File)
Apr 26 2025, 9:01 PM
Unknown Object (File)
Apr 25 2025, 11:28 PM
Unknown Object (File)
Apr 25 2025, 9:50 PM
Unknown Object (File)
Apr 25 2025, 1:11 PM
Subscribers
None

Details

Reviewers
lcook
Summary

This change upgrades devel/golintci-lint from 1.62.2 to 2.0.2. Given
that newer versions of golangci-lint aren't backwards compatible,
require configuration migration, and emit more errors than the 1.x
series, fork devel/golintci-lint 1.62.2 as devel/golintci-lint1 and
upgrade the version to the latest 1.62.x release. This is being done to
allow multiple consumers to continue using golangci-lint in their CI
workflows without unnecessary breakage.

Both versions require a newer version of go (1.23+). Bump the version
referenced in USES+= go to support this change.

Release notes for golintci-lint 1.64.4 and 2.0.2 can be found in the
project changelog.

Requires: D49723.

PR: 285969
Signed-off-by: Enji Cooper <ngie@FreeBSD.org>

Test Plan
  • Tried installing both: ports properly detected the conflict.
  • Installed 2.0.2 successfully, but it failed when running the newer version for various linting-related reasons.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63446
Build 60330: arc lint + arc unit

Event Timeline

ngie requested review of this revision.Apr 9 2025, 2:26 AM
ngie created this revision.

Oof... 2.0.2 really finds a lot more issues in code (for better or worse). containerd for instance passes on 1.65.x, but fails on 2.0.2.
Also, 2.0.2 required a config migration (like tox), so it might make more sense to split up the package into 2 different versions.

  • Fork 1.x from 2.x
  • Upgrade 1.x from 1.62.2 to 1.64.8
ngie retitled this revision from devel/golintci-lint: upgrade from 1.62.2 to 2.0.2 to devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8.Apr 11 2025, 2:52 AM
ngie edited the summary of this revision. (Show Details)
ngie edited the test plan for this revision. (Show Details)

Update CONFLICTS_INSTALL to handle the 1.x to 2.x hop cleanly, while forbidding
*-lint1 and *-lint from being installed together.

Fix CONFLICTS definition per the Porter's Handbook section on "Using CONFLICTS* With Globs."