devel/lutok: update to 0.6.1
ClosedPublic
Actions

Authored by ngie on Mar 29 2025, 5:40 PM.

Details

Reviewers

bofh

Commits

R11:5836bc5cdf1f: devel/lutok: update to 0.6.1

Summary

This version contains several enhancements and bug fixes described in the
release notes linked below:

Adjust the logic while here in some subtle ways:

Only require ATF and package the tests if the port is built with the TEST option on.
Switch from jmmv's GitHub repo to the freebsd GitHub repo.

Signed-off-by: Enji Cooper <ngie@FreeBSD.org>

Test Plan

I confirmed that the changes functioned locally on my FreeBSD 14.3-RELEASE amd64 host (with and without the TEST option enabled).
The test suite passed on my 14.3-RELEASE amd64 FreeBSD host.

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

ngie requested review of this revision.Mar 29 2025, 5:40 PM

ngie created this revision.

ngie edited the test plan for this revision. (Show Details)

ngie added a reviewer: bofh.

ngie edited the summary of this revision. (Show Details)

devel/lutok/Makefile
13	I tend to avoid this as much as possible. I have forgot the exact news/update from Github but Github has mentioned that they will never guaranty the hash/checksum of the generated dists. As the repo is within our control why not use a release tarball as you have already generated that.
15	This is redundant. Use `DISTVERSIONPREFIX=lutok-`.

ngie marked 2 inline comments as done.Mar 29 2025, 9:54 PM

ngie added inline comments.

devel/lutok/Makefile
15	It's actually not needed at all once I get rid of `USE_GITHUB=`!

ngie marked an inline comment as done.Mar 29 2025, 9:56 PM

Resolve comments from bofh by replacing USE_GITHUB with the static release artifact URL.
Leverage CONFIGURE_ENABLE= instead of the handrolled equivalent with CONFIGURE_ON= and CONFIGURE_OFF=.