Page MenuHomeFreeBSD

mav (Alexander Motin)
User

Projects

User Details

User Since
Jun 3 2014, 6:27 PM (560 w, 7 h)

Recent Activity

Wed, Feb 19

mav accepted D49016: cam: Update scsi_all.h to reflect 30 years of evolution.
Wed, Feb 19, 9:41 PM

Tue, Feb 18

mav accepted D48983: acpi_asus_wmi(4): Improve keyboard backlight support..
Tue, Feb 18, 6:11 PM

Fri, Feb 14

mav added a comment to D48985: acpi_asus_wmi(4): Handle TUF-specific hotkeys internally.

RGB mode looks like some magic withe the number of constants. I wonder if it is possible or reasonable to read defaults from BIOS where the changed values are stored?

Fri, Feb 14, 2:26 AM
mav accepted D48984: acpi_asus_wmi(4): Add support for WMI event queue.

Seems to make sense, but I don't know anything about it.

Fri, Feb 14, 2:18 AM
mav added a comment to D48983: acpi_asus_wmi(4): Improve keyboard backlight support..

I have no objections, but I wonder whether maximum of 3 vs 7 might be model-specific?

Fri, Feb 14, 2:11 AM
mav accepted D48982: acpi_asus_wmi(4): Add EVDEV support.

I have no objections, if it works, but I don't have that ASUS for quite a while now.

Fri, Feb 14, 2:02 AM

Tue, Feb 4

mav accepted D48687: cam/da: Document what an 'invalid pack' means..
Tue, Feb 4, 6:19 PM

Mon, Jan 27

mav added a comment to D48687: cam/da: Document what an 'invalid pack' means..

Just to be sure, DA_FLAG_PACK_INVALID does not mean there is no media. There might be a media, just not one we opened originally.

Mon, Jan 27, 4:24 PM
mav added a comment to D48689: cam/da: Call cam_periph_invalidate on ENXIO in dadone.

This change require DA_FLAG_PACK_INVALID to be reliable avoid false periph invalidations. I am not sure current asc == 0x3a covers all the cases, I have feeling that 0x28/0x00 Not ready to ready change, medium may have changed is even more widespread case of media change and so pack invalidation.

Mon, Jan 27, 4:22 PM
mav requested changes to D48686: cam: Implement ascq ranges correctly.

This change is unneeded. ascq <= table_entry->ascq is already checked few lines above.

Mon, Jan 27, 4:08 PM
mav accepted D48684: cam: Fail ASC 0x40.
Mon, Jan 27, 4:06 PM
mav accepted D48685: cam: Fix off by one error in ASC/ASCQ lookup.

I've noticed this issue too while looking on the previous patch.

Mon, Jan 27, 4:05 PM

Jan 23 2025

mav accepted D48648: libiscsiutil: Add log_warnc() and log_errc() functions.
Jan 23 2025, 8:56 PM
mav added a comment to D48595: ctld: Use nvlist instead of home-rolled name-value lists.
In D48595#1109250, @jhb wrote:

I'm not quite sure where to put the nvlist_error calls TBH.

Jan 23 2025, 6:26 PM
mav resigned from D48597: ctld: Use kevent(2) for socket events rather than select(2).
Jan 23 2025, 5:14 PM
mav accepted D48622: ctld: Fix assertion against the wrong field.
Jan 23 2025, 4:59 PM
mav added inline comments to D48597: ctld: Use kevent(2) for socket events rather than select(2).
Jan 23 2025, 4:52 PM
mav accepted D48596: ctld: Factor our code to setup a listening socket into a separate function.
Jan 23 2025, 4:48 PM
mav added a comment to D48595: ctld: Use nvlist instead of home-rolled name-value lists.

I don't remember nvlists much, but shouldn't errors be checked via nvlist_error() sometimes?

Jan 23 2025, 4:44 PM
mav accepted D48594: ctld: Use bool in uclparse.c.

I guess instead of 1 could be expected some error codes, that just never happened.

Jan 23 2025, 4:27 PM
mav accepted D48593: iscsi: Move valid_iscsi_name to libiscsiutil.
Jan 23 2025, 4:22 PM

Jan 17 2025

mav accepted D48505: cam: Add 3e/3 as a fatal code.

This seems consistent with other places where we use "SS_FATAL | ENXIO".

Jan 17 2025, 8:26 PM
mav added a comment to D48503: snd_hda.4: Improve HARDWARE for HW Relnotes.

While I guess u3g.4 might indeed include the full list of supported devices, simply because IIRC many of them require some quirks to attach and operate, the snd_hda was written with a goal to work on unknown hardware. The list of devices in the code in most cases is just for cosmetics and user convenience. That is why I would not like it to be listed as more than examples. We've actually had a list in the man page before, but I axed it out at some point.

Jan 17 2025, 3:52 PM

Jan 15 2025

mav added a comment to D48451: add UMA_ZONE_NOTRIM & use it for the ktls_buffer zone.

I understand the desire to avoid extra work, but if server load pattern really change to no longer require the KTLS, the allocations will stay cached, occupying memory for no reason if there is no explicit pressure. For example, considering ZFS might shrink ARC or at least limit its growth if there is no free memory, it might be a waste.

Jan 15 2025, 5:35 PM
mav committed rG519121f5ea03: isp: Fix abort issue introduced by previous commit (authored by mav).
isp: Fix abort issue introduced by previous commit
Jan 15 2025, 2:50 AM
mav committed rGff911710de34: isp: Fix abort issue introduced by previous commit (authored by mav).
isp: Fix abort issue introduced by previous commit
Jan 15 2025, 2:49 AM

Jan 8 2025

mav committed rG2c48a8f161c9: isp: Fix abort issue introduced by previous commit (authored by mav).
isp: Fix abort issue introduced by previous commit
Jan 8 2025, 6:25 PM
mav added a reverting change for rG1f7c379c0716: isp: Fix abort issue introduced by previous commit: rGe6c96c7af717: Revert "isp: Fix abort issue introduced by previous commit".
Jan 8 2025, 6:21 PM
mav committed rGe6c96c7af717: Revert "isp: Fix abort issue introduced by previous commit" (authored by mav).
Revert "isp: Fix abort issue introduced by previous commit"
Jan 8 2025, 6:21 PM
mav committed rG1f7c379c0716: isp: Fix abort issue introduced by previous commit (authored by mav).
isp: Fix abort issue introduced by previous commit
Jan 8 2025, 6:19 PM

Jan 7 2025

mav accepted D48361: x86: Short-circuit ipi_all_but_self() on UP systems.
Jan 7 2025, 4:24 PM

Jan 3 2025

mav accepted D48303: pci: Only claim to support PCI ASPM on x86.

I don't remember whether ASPM has anything to do with enabling ports, so wonder if it is a curios case of opposite bugs, but if it helps, I see no problem.

Jan 3 2025, 2:45 PM

Dec 23 2024

mav accepted D48181: diff: Fix device case..
Dec 23 2024, 5:12 PM
mav committed rGd353c342a12c: isp: Improve task aborts handling (authored by mav).
isp: Improve task aborts handling
Dec 23 2024, 2:35 PM
mav committed rG36abbfe061df: isp: Fix use after free in aborts handling (authored by mav).
isp: Fix use after free in aborts handling
Dec 23 2024, 2:35 PM
mav committed rG1fd197d19221: isp: Improve task aborts handling (authored by mav).
isp: Improve task aborts handling
Dec 23 2024, 2:35 PM
mav committed rG71656857b308: isp: Fix use after free in aborts handling (authored by mav).
isp: Fix use after free in aborts handling
Dec 23 2024, 2:35 PM

Dec 10 2024

mav accepted D48014: isp(4): Correct nomenclature for L_Port.
Dec 10 2024, 8:07 PM

Dec 9 2024

mav committed rGec3175fc3b2c: isp: Improve task aborts handling (authored by mav).
isp: Improve task aborts handling
Dec 9 2024, 5:11 PM
mav committed rG40fb1b8bc1cf: isp: Fix use after free in aborts handling (authored by mav).
isp: Fix use after free in aborts handling
Dec 9 2024, 4:51 PM

Dec 4 2024

mav added inline comments to D47745: intr/x86: merge pic_{dis,en}able_source() call into pic_{dis,en}able_intr().
Dec 4 2024, 11:44 AM

Dec 1 2024

mav committed rG7589f9bb7555: hwpmc: Restore line lost in previous commit (authored by mav).
hwpmc: Restore line lost in previous commit
Dec 1 2024, 12:57 AM

Nov 28 2024

mav committed rGde852d78ff58: hwpmc: Restore line lost in previous commit (authored by mav).
hwpmc: Restore line lost in previous commit
Nov 28 2024, 4:56 PM

Oct 26 2024

mav added a comment to D47287: cam: Don't log invalid cdb errors.

I've never used it myself, so don't have a strong opinion, but as next step somebody will want to block reservation conflicts, then something else, and again and again...

Oct 26 2024, 2:11 PM

Oct 23 2024

mav accepted D47224: bhyve ahci: Improve robustness of TRIM handling.

Looks good to me. Thanks.

Oct 23 2024, 2:20 PM

Oct 21 2024

mav added inline comments to D47224: bhyve ahci: Improve robustness of TRIM handling.
Oct 21 2024, 5:52 PM
mav added inline comments to D47224: bhyve ahci: Improve robustness of TRIM handling.
Oct 21 2024, 4:43 PM

Oct 14 2024

mav added a comment to D44367: cam: Move temporary queue from stack to softc.

The xpt_done_td queues are used only for the non-MP safe things as well as I think for the error path, both of which are relatively rare.

Oct 14 2024, 3:19 PM

Oct 2 2024

mav accepted D46530: openzfs: Reduce local diffs.
Oct 2 2024, 7:26 PM

Sep 26 2024

mav committed rGd89090334a32: ure(4): Add ID for LAN port in Thinkpad OneLink+ dock (authored by mav).
ure(4): Add ID for LAN port in Thinkpad OneLink+ dock
Sep 26 2024, 12:51 AM
mav committed rG8748daf670ee: ure(4): Add ID for LAN port in Thinkpad OneLink+ dock (authored by mav).
ure(4): Add ID for LAN port in Thinkpad OneLink+ dock
Sep 26 2024, 12:50 AM

Sep 19 2024

mav committed rGa1bb5bdb0ab6: ure(4): Add ID for LAN port in Thinkpad OneLink+ dock (authored by mav).
ure(4): Add ID for LAN port in Thinkpad OneLink+ dock
Sep 19 2024, 2:00 AM

Sep 11 2024

mav accepted D46247: Fix the ZFS sharenfs property for DNS names with '-'s in them.
Sep 11 2024, 2:48 PM

Aug 30 2024

mav accepted D46470: geom_disk: Print attachment in boot log like newbus.
Aug 30 2024, 5:27 PM
mav added a comment to D46469: virtio_blk: Populate d_attachment.

What do you both think of https://reviews.freebsd.org/P646 as a more systematic way of addressing this?

Aug 30 2024, 5:25 PM

Aug 29 2024

mav added a comment to D46470: geom_disk: Print attachment in boot log like newbus.

I suppose 3 printf's may cause garbled output if other printf's are used by something.

Aug 29 2024, 1:28 AM
mav accepted D46469: virtio_blk: Populate d_attachment.
Aug 29 2024, 1:24 AM
mav accepted D46468: geom_disk: Export attachment if present in XML config.

It seems BIO_GETATTR allows GEOM::attachment override. Though I am not saying it is very useful.

Aug 29 2024, 1:20 AM

Jul 21 2024

mav committed rG9746cb2197a1: nvmecontrol: Fix "Workloadd" typo (authored by mav).
nvmecontrol: Fix "Workloadd" typo
Jul 21 2024, 5:47 PM
mav committed rG908777f1c258: nvmecontrol: Fix "Workloadd" typo (authored by mav).
nvmecontrol: Fix "Workloadd" typo
Jul 21 2024, 5:47 PM

Jul 12 2024

mav committed rG6ac0f711ad9e: nvmecontrol: Fix "Workloadd" typo (authored by mav).
nvmecontrol: Fix "Workloadd" typo
Jul 12 2024, 3:38 PM

Jul 3 2024

mav added inline comments to D45814: Allow ZFS sharenfs to generate multiple export(5) lines.
Jul 3 2024, 3:36 PM
mav accepted D45814: Allow ZFS sharenfs to generate multiple export(5) lines.

Looks fine to me, just couple nits.

Jul 3 2024, 3:33 PM

Jul 2 2024

mav added a comment to D45814: Allow ZFS sharenfs to generate multiple export(5) lines.

Have you looked on similar Linux code? It would be good to be consistent or at least similar. I haven't looked deep, but foreach_nfs_host_cb() seems to support multiple hosts.

Jul 2 2024, 3:28 PM

Jun 27 2024

mav committed rG87085c12ba8f: Fix SATA NCQ error recovery after 25375b1415 (authored by mav).
Fix SATA NCQ error recovery after 25375b1415
Jun 27 2024, 1:38 PM

Jun 24 2024

mav accepted D45688: Add isp(4) fwload_only loader tunable.
Jun 24 2024, 7:40 PM · cam
mav accepted D45660: Fix isp(4) device probing with 9.x firmware.

Looks odd to me, but OK.

Jun 24 2024, 6:17 PM · cam
mav added a comment to D45660: Fix isp(4) device probing with 9.x firmware.
In D45660#1042742, @ken wrote:

So here is what the debugging log message in isp_getpdb() shows. isp0 and isp1 are connected to LTO-6 tape drives via an 8Gb switch. isp2 is directly connected to an LTO-6 in loop mode:

isp0: Chan 0 handle 0x0 Port 0xfffc01 flags 0x0 curstate 77 laststate 77
isp0: Chan 0 handle 0x1 Port 0x011b26 flags 0x40a0 curstate 46 laststate 46
isp0: Chan 0 handle 0x7fe Port 0xfffffe flags 0x0 curstate 44 laststate 44
isp0: Chan 0 handle 0x7fe Port 0xfffffe flags 0x0 curstate 44 laststate 44
isp1: Chan 0 handle 0x0 Port 0xfffc01 flags 0x0 curstate 77 laststate 77
isp1: Chan 0 handle 0x1 Port 0x011a26 flags 0x40a0 curstate 46 laststate 46
isp1: Chan 0 handle 0x7fe Port 0xfffffe flags 0x0 curstate 44 laststate 44
isp1: Chan 0 handle 0x7fe Port 0xfffffe flags 0x0 curstate 44 laststate 44
isp2: Chan 0 handle 0x0 Port 0x000026 flags 0x40a0 curstate 46 laststate 46

Jun 24 2024, 5:49 PM · cam
mav accepted D45718: isp: don't run ISPCTL_FCLINK_TEST on failed ISPCTL_ABORT_CMD.
Jun 24 2024, 3:29 PM
mav added a comment to D45688: Add isp(4) fwload_only loader tunable.

It seems a good tunable, except I am not getting the meaning of "only" there. Why not "always", "force" or something like that?

Jun 24 2024, 3:25 PM · cam
mav added a comment to D45660: Fix isp(4) device probing with 9.x firmware.

None of QLogic documents I have know nothing about NVMe, and this state field is declared is byte there. I have no objections for this patch, but a bit curios what NVMe status do we see there for non-NVMe devices.

Jun 24 2024, 3:17 PM · cam

Jun 14 2024

mav committed rG80b42329248a: nvme: Fix panic on detach after ce75bfcac9cfe (authored by mav).
nvme: Fix panic on detach after ce75bfcac9cfe
Jun 14 2024, 7:34 PM

Jun 7 2024

mav committed rG4cc4b5e2b5f8: Add some AMD device IDs. (authored by dmitryluhtionov_gmail.com).
Add some AMD device IDs.
Jun 7 2024, 5:04 PM

Jun 6 2024

mav accepted D45522: ctladm: deprecate the undocumented "port -l" option.
Jun 6 2024, 9:38 PM

May 29 2024

mav added a comment to D45390: runq/sched: Switch to 256 distinct levels.

Differences of less than 4 (RQ_PPQ) are insignificant and are simply removed. No functional change (intended).

May 29 2024, 11:20 PM
mav added a comment to D45388: sched_ule: Re-implement stealing on top of runq common-code.

I suspect that first thread was skipped to avoid stealing a thread that was just scheduled to a CPU, but was unable to run yet.

May 29 2024, 6:34 PM
mav added a comment to D45380: kern/dev/nvme: Use the per-namespace uma(9) zone for the bio..

I am not fully sure about the motivation of this change, but It feels wrong to me to have per-namespace zones. On a big system under heavy load UMA does a lot of work for per-CPU and per-domain caching, and doing it also per-namespace would multiply resource waste. Also last time I touched it, I remember it was difficult for UMA to operate in severely constrained environments, since eviction of per-CPU caches is quite expensive. I don't remember how reservation works in that context, but I suppose that having dozens of small zones with small reservations, but huge per-CPU caches is not a very viable configuration.

May 29 2024, 1:57 PM

May 23 2024

mav accepted D45311: nvme: Count number of alginment splits.
May 23 2024, 9:37 PM
mav added inline comments to D45311: nvme: Count number of alginment splits.
May 23 2024, 6:28 PM
mav committed rG856d35337225: Fix scn_queue races on very old pools (authored by mav).
Fix scn_queue races on very old pools
May 23 2024, 6:12 PM
mav committed rG9898f936aa69: Fix scn_queue races on very old pools (authored by mav).
Fix scn_queue races on very old pools
May 23 2024, 5:46 PM
mav committed rG455ce1729353: Fix scn_queue races on very old pools (authored by mav).
Fix scn_queue races on very old pools
May 23 2024, 5:42 PM
mav committed rG49086aa35d98: Fix scn_queue races on very old pools (authored by mav).
Fix scn_queue races on very old pools
May 23 2024, 4:22 PM

May 14 2024

mav accepted D45192: nvme: Improve timeout action.

I see no problems, but I have difficulties to believe that timeout handlers 1-2 times per second per queue pair may have any visible effects. Also I am not happy to see second place where timeouts are calculated. And 99/100 also looks quite arbitrary.

May 14 2024, 12:44 AM
mav accepted D45190: ctl: use socket buffer mutexes in struct socket directly.

Mechanically it seems to have sense. I've missed when than original transition happened, but if you say it is right, so be it.

May 14 2024, 12:22 AM

May 7 2024

mav added a comment to D45072: mca: Allow for passing ECC error record to memory controller driver..

I wonder if there is any real architecture where pointer load/store is non-atomic. For things that are going to be executed between once and never it feels like you are over-engineering it. :)

May 7 2024, 6:34 PM
mav accepted D45072: mca: Allow for passing ECC error record to memory controller driver..

I have no objections, if it is useful.

May 7 2024, 5:24 PM

May 3 2024

mav added inline comments to D45072: mca: Allow for passing ECC error record to memory controller driver..
May 3 2024, 1:35 AM

Apr 27 2024

mav committed rGa36b9f244287: libpmc: Import AMD Zen 4 PMU events (authored by mav).
libpmc: Import AMD Zen 4 PMU events
Apr 27 2024, 3:04 AM
mav committed rG75f1323c15cb: libpmc: Import AMD Zen 4 PMU events (authored by mav).
libpmc: Import AMD Zen 4 PMU events
Apr 27 2024, 3:04 AM

Apr 26 2024

mav added a comment to D44961: rate limit ctl_process_done warning messages.

What is an "OOA queue"?

Apr 26 2024, 3:24 PM
mav added a comment to D44961: rate limit ctl_process_done warning messages.

I wonder what is your queue depth, so that one message per request per 90 seconds would cause a noticeable storm. Also per-system limiting makes output not very useful, since it does not say much useful about LUNs, ports, commands, etc due to selecting first message out of many, only that something is wrong. Thinking even wider, I find those messages printed on actual completion not very useful, since if there are not a delays, but something is really wrong, the commands many never complete and so the messages may never get printed. I wonder if instead removing all this and once per second checking OOA queues for stuck requests and printing some digests would be more useful.

Apr 26 2024, 3:03 PM

Apr 20 2024

mav committed rG278d6950943a: libpmc: Import AMD Zen 4 PMU events (authored by mav).
libpmc: Import AMD Zen 4 PMU events
Apr 20 2024, 3:55 PM
mav accepted D44860: ahc(4)/ahd(4): fix target mode on ARM.

Looks good to me, but if you wish, couple cosmetic thoughts.

Apr 20 2024, 3:30 PM
mav accepted D44859: ahc(4): resolve some minor nits.

Looks good to me, though seems only cosmetic.

Apr 20 2024, 3:23 PM

Apr 17 2024

mav committed rG4bb54e8ec3d0: ahc/ahd: Fix target mode operation (authored by mav).
ahc/ahd: Fix target mode operation
Apr 17 2024, 1:40 PM
mav committed rGe48f7ff6a12c: ahc/ahd: Fix target mode operation (authored by mav).
ahc/ahd: Fix target mode operation
Apr 17 2024, 1:40 PM

Apr 10 2024

mav committed rGf1e4c095777d: ahc/ahd: Fix target mode operation (authored by mav).
ahc/ahd: Fix target mode operation
Apr 10 2024, 8:51 PM

Mar 25 2024

mav accepted D44494: mpi3r: Track IO per target counter during queue poll with local var.
Mar 25 2024, 12:58 PM

Mar 21 2024

mav accepted D44430: mpi3mr: Update driver version to 8.10.0.1.0.
Mar 21 2024, 2:30 PM