User Details
- User Since
- Jan 7 2019, 7:21 PM (314 w, 3 d)
May 19 2024
Nov 3 2023
Mar 21 2023
Nov 1 2022
The PowerPC parts look good.
Oct 4 2022
Sep 30 2022
I'm also seeing this issue when zfs tries to mount my partition.
Considering PowerPC has been broken for quite some time, this seems a good approach, while the real issue on LLD or the kernel linker is not resolved.
Aug 5 2022
May 31 2022
Feb 22 2022
Jan 10 2022
Jan 6 2022
Looks good.
Dec 22 2021
I was able to build kboot for powerpc64, with diffs D33511 - D33515.
In the machines that I have access to, Petitboot can't run BE loader.kboot, but I was able to build and run a LE loader.kboot.
However, as mentioned in D33511, it can just run some loader commands, but can't list files or load a kernel. But the older version, without these changes, also can't.
Works fine, after the proposed fix in D33511.
Dec 15 2021
Dec 14 2021
Dec 1 2021
Is this change good to go now?
Nov 25 2021
Nov 24 2021
Nice!
Nov 5 2021
Nov 4 2021
Nov 1 2021
Oct 22 2021
Oct 20 2021
Oct 18 2021
I've tested these changes on a PPC64 VM. With them, the virtual SCSI device fails to attach, making it impossible to mount root.
Below are the relevant dmesg messages:
Oct 14 2021
Build uboot for ppc32 too
Oct 13 2021
Oct 6 2021
Initialize RGB offsets along with palette.
Sep 30 2021
Simplify sysctl setup
@scottl do you think this is ok now?
Sep 28 2021
Address reviewer's comments
Remove obsolete endian conversions
Sep 27 2021
Sep 21 2021
Initialize archsw earlier.
Sep 20 2021
Sep 15 2021
Address reviewer's comments
Add missing break
Query device tree for Radix/GTSE support, instead of using CPU version and HV bit checks, as this is a better approach, as discussed in IRC.
Sep 14 2021
Sep 13 2021
Sep 8 2021
Sep 6 2021
- Address reviewer's comments
Sep 1 2021
Aug 31 2021
Address reviewer's comments:
- log DMA load buffer error message only once for each device
- add a per device error counter, exported via sysctl (inspired by mpr code)
Aug 24 2021
Worked fine on POWER9.
For PowerPC, without these changes the allocation of more programmable counters than available already failed, because of the check for the counter number in allocate. But, as you said, it is always a good idea to validate the PMC class too.
Jul 30 2021
Jul 29 2021
Jul 28 2021
Jul 26 2021
Jul 23 2021
This approach of auto detecting the correct frame buffer physical address based on Vendor ID looks good.
It would help to make FreeBSD graphics work out of the box for Blackbird and Talos II machines, instead of forcing the user to figure out the physical address of its VGA adapter and pass it to the kernel manually, or else the system just hangs.
Ideally, Petitboot should fix it on their side, but I don't know if it will happen anytime soon, since Linux isn't affected, because it just talks directly to ASPEED video device, instead of relying on the framebuffer info exposed in the device tree.
D31232 fixes OFWFB with radix. After it lands it should be safe to make radix default.
@imp I've added the rate limiter, do you think this revision is ok now?
Jul 21 2021
- Fix event name mapping
- Handle non-programmable PMCs (PMC5 and PMC6)
- Add missing event counter check
Commandeering revision to finish changes while Leonardo is out.
Jul 20 2021
LGTM. The changes are similar to the PPC64 ones, in D31109.