Seems like the latest diff hasn't been uploaded yet, but once it is uploaded, I think this is ready to land?

In D46557#1062061, @jpb_jimby.name wrote:

All of the "Errant period" comments fall into one of two categories:

1. Ordered lists - these are the "period at beginning of line followed by space" variety. Ordered lists are covered in the FDP Primer, section 6.4.1
2. Image captions - these are the "period at beginning of line followed by text" variety. Image captions are covered in the FDP Primer in section 7.1 under the "Images" row in the table.

I will mark all of those comments "Done".

Please remember to mark this review as abandoned.

Did a pass on the remaining bit that was added, but it's entirely possible I've missed something.

I did a quick first pass since I had a bit of energy remaining.

mdoc(7) syntax looks fine to me.

In D42961#979432, @0mp wrote:

In D42961#979425, @debdrup wrote:

I think it'd be a good idea to add these as an include - that way, it's easier to enable or disable on a case-by-case basis.

What do you mean by "as an include"?

There are already includes in the file for newsyslog.conf.d/ and the local variant of it.
If I correctly understand how newsyslog works, setting the different values in the include file would override them when the configuration is read by newsyslog?

I think it'd be a good idea to add these as an include - that way, it's easier to enable or disable on a case-by-case basis.

Only spotted two minor nits, but they can be fixed before pushing as they don't have to hold up things.

Spotted some minor nits, but these can be fixed when it's pushed.

Putting aside the debate over the toor user for another time, using it as an example user doesn't seem like the best option, as it's meant to rescue systems.

I only spotted a minor nit.

mdoc(7) changes look good to me, can't speak to the code.

Looks good to me.

In D37881#899585, @danfe wrote:

Need to convert them to .Bl/.It+Ta/.El, but we'd better ask someone from the manpages to be sure.

To add a bit of context from a conversation on IRC, this review is intended to make it much easier to define jail(8) variables globally at the top of jail.conf(5), you only need to instanciate the name of a jail and optionally some per-jail values.

Please remember to bump .Dd :)

I'm perfectly satisfied with this import, since I've used the sendcalls script and had a hand in crafting the template.

Looks good to me!

Just a few nits that I noticed that may be worth considering.

The mdoc(7) changes look good to me.

Manual page looks good to me, with the exception of one minor nit.

Apologies for taking so long, life got in the way.

mdoc(7) looks good

I spotted a few nits, but they're not worth holding up the review for as they can be fixed before the commit is pushed.

Other than the question, I'm still happy with the mdoc, so will accept once that's been answered.

mdoc(7) looks good to me.

I cant immediately spot any other nits with the mdoc, but perhaps you should add a note about when ts(1) was added to FreeBSD in the history section header?

I don't think there's anything else I remarked on that needs to be addressed, so if everyone else would accept it if theirs has been dealt with, we can get the needful done.

As for the change, it looks good to me - but as I'm sure you know, you need extra approval too. ;)

I've made some suggestions for where various entries belong, but that's about it I think.

mdoc(7) syntax looks good to me, so once the other issues pointed out with the manual page have been fixed, I'm happy to accept it.

I'm happy with mdoc(7) syntax since .Dd was bumped ;)

Looks good to go, go ahead and commit @imp

mdoc looks good to me.

.Dd also needs to be bumped.

mdoc(7) looks good to me, but please remember to bump .Dd before you commit. :)

I think it's ready to go now, and the summary should work better as a descriptive commit message. :)

You're absolutely right, -P means parsable, whereas -p means properties.
You should probably explain that in the commit log, though - may I edit the summary?

Looks good to me, so assuming it builds, you're good to go. :)

For one-sentence-per-line changes, we generally like to keep them as separate commits.
However, I think it's okay for this commit since you're changing so little.

Ss, like Sh, should be capitalized according to mdoc(7).

Looks good to me.

I'd prefer if you used .Sy or .Em rather than capitalization.

I apologize deeply for losing track of this one (and the change to rc.subr(8), although I think I managed to address that one).

I ended up documenting this in bd6dce978c1, I believe - can you confirm?

Manual page syntax looks good, but it'd be nice to have a mention of the timing in the HISTORY section.

Have you run the manual page through mandoc -Tlint and igor from textproc/igor?

Manual page looks good to me, but please remember to bump .Dd before pushing. ;)

Manual page looks good to me from a syntax perspective, and I wasn't able to spot any other issues.

Please run mandoc -Tlint and igor on the manual page, you'll see that there's a few minor nits that need to be fixed.

Syntax looks good, and it matches what I remember of my CCIE Wireless courses.

Looks good to me.

Commandeering this now that @rpokala has approved it on IRC.

mdoc syntax hasn't really changed and .Dd has been bumped, so this can be commited and pushed.

There are also some lines that exceed 80 characters in width, so the manual page needs to be rewrapped.

Good to go.

I only spotted one minor nit, so I'll accept this and you can commit and push at your convenience after you've fixed it.

Looks good to me.

Looks good to me.

A nice little addition to have. :)

Manual page looks good, I'll let others review the code.

Looks good to me.

I only noticed one thing in the mdoc syntax.

My initial pass of it looks good, but consider waiting for someone else to look over it too.

The mdoc syntax looks good to me.

A tiny nit with the mdoc syntax, otherwise it looks good to me.

I think you should add the "nearly" qualifier to identical, as saying they're identical and then mentioning an exception seems contradictory to me.

Manual page changes look good to me.

Please remember to bump .Dd on pf.conf.5 - other than that, manual page looks fine.

Manual page looks good to me.

I spotted one thing in the manual page, otherwise it looks good to me.