Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects (6)

User Details

User Since
May 14 2014, 7:57 AM (610 w, 1 d)

Recent Activity

Yesterday

adrian added a comment to D54820: sendfile(2): document that EINTR never happens on non-blocking socket.

I agree. There's a reason EINTR is something userland is supposed to handle and restart in a documented way, and it's "so the kernel doesn't have to bend over backwards to restart things."

Thu, Jan 22, 4:20 PM
adrian added inline comments to D54821: powerpc: add a best-effort SMP time base sync for G5's that need it.
Thu, Jan 22, 3:14 PM · PowerPC
adrian added a reviewer for D54821: powerpc: add a best-effort SMP time base sync for G5's that need it: PowerPC.
Thu, Jan 22, 5:28 AM · PowerPC
adrian added a reviewer for D54821: powerpc: add a best-effort SMP time base sync for G5's that need it: jhibbits.
Thu, Jan 22, 5:27 AM · PowerPC
adrian requested review of D54821: powerpc: add a best-effort SMP time base sync for G5's that need it.
Thu, Jan 22, 5:27 AM · PowerPC

Wed, Jan 21

adrian accepted D54814: sdt: Enable on 32-bit powerpc and powerpc64le.

works for me!

Wed, Jan 21, 7:43 PM
adrian added a comment to D54745: powerpc64/powernv: Enable Partitionable Endpoint (PE) support.

I'm in the process of documenting / getting powernv8 and powernv9 qemu guests up and running.
(And I now have a power8 booting freebsd powernv so I can test it on real hardware as well.)

Wed, Jan 21, 4:42 PM · PowerPC
adrian added a comment to D54762: acpi: Add Darwin OSI support for Apple Mac hardware.

Any other comments? I'd like to land this into -HEAD this week and see how it plays out!

Wed, Jan 21, 4:26 PM
adrian added a comment to D48099: rtwn: add VHT information to TX rate completion.

What do we expect to do with the remaining patches in this stack?

Wed, Jan 21, 3:41 PM · wireless

Tue, Jan 20

adrian added a comment to D54794: net80211: correct return code for ieee80211_ampdu_request().

Oh, there's no callers of ieee80211_ampdu_request() outside of net80211? I was worried that the existing AMPDU implementing drivers would hiccup with the return value changing!

Tue, Jan 20, 4:14 PM
adrian added a comment to D54390: net80211: clean up time comparison in HT code.

yeah, without it the ampdu retry stuff eventually stops retrying until the counter loops around again for the comparison to work

Tue, Jan 20, 3:04 PM · wireless
adrian added a reviewer for D54790: net80211: migrate wk_rxmic / wk_rxmic in TKIP code to accessors: wireless.
Tue, Jan 20, 4:33 AM · wireless
adrian requested review of D54790: net80211: migrate wk_rxmic / wk_rxmic in TKIP code to accessors.
Tue, Jan 20, 4:32 AM · wireless

Mon, Jan 19

adrian added a reviewer for D54762: acpi: Add Darwin OSI support for Apple Mac hardware: ngie.
Mon, Jan 19, 1:30 AM
adrian added reviewers for D54762: acpi: Add Darwin OSI support for Apple Mac hardware: imp, jkim, obiwac.
Mon, Jan 19, 1:27 AM
adrian added a reviewer for D54771: pmu: avoid NULL ofw_get_bus_type(); handle pmu_send() calls w/ NULL recv buffers: PowerPC.
Mon, Jan 19, 1:21 AM · PowerPC
adrian requested review of D54771: pmu: avoid NULL ofw_get_bus_type(); handle pmu_send() calls w/ NULL recv buffers.
Mon, Jan 19, 1:20 AM · PowerPC

Sun, Jan 18

adrian accepted D54768: sys: do not allow entering vm_fault() on boot until VM is initialized.
Sun, Jan 18, 9:20 PM
adrian added a comment to D54768: sys: do not allow entering vm_fault() on boot until VM is initialized.

thanks!

Sun, Jan 18, 9:20 PM

Sat, Jan 17

adrian accepted D54759: spi: use better logic for earlier change.
Sat, Jan 17, 5:02 PM
adrian added a comment to D54633: aq: Add to amd64 GENERIC and to sys/conf/NOTES.

I had to undo the sys/conf/NOTES part because aq doesn't compile on ! amd64 right now. It's using calls to readl/writel.

Sat, Jan 17, 5:04 AM
adrian committed rGafbb21bd1d62: aq: remove from NOTES; it's unfortunately amd64 only (authored by adrian).
aq: remove from NOTES; it's unfortunately amd64 only
Sat, Jan 17, 5:01 AM
adrian committed rG6dc12ecfb268: spi: "-S" option for continuous stream from standard input to bus (authored by reviews-freebsd-org412_ketas.si.pri.ee).
spi: "-S" option for continuous stream from standard input to bus
Sat, Jan 17, 3:42 AM
adrian added a comment to D54734: spi(8) - "-S" option for continuous stream from standard input to bus.

landed!

Sat, Jan 17, 3:42 AM
adrian closed D54734: spi(8) - "-S" option for continuous stream from standard input to bus.
Sat, Jan 17, 3:42 AM
adrian added a comment to D54733: usbdevs: Add USB device IDs for Nuand bladeRF SDR.

hi! please resubmit this with the correct tab indents so I can apply it to the tree and push upstream. Thanks!

Sat, Jan 17, 3:26 AM
adrian committed rGc75eff16ef54: aq: Add to amd64 GENERIC and to sys/conf/NOTES (authored by brad_comstyle.com).
aq: Add to amd64 GENERIC and to sys/conf/NOTES
Sat, Jan 17, 3:26 AM
adrian closed D54633: aq: Add to amd64 GENERIC and to sys/conf/NOTES.
Sat, Jan 17, 3:25 AM
adrian added a comment to D54633: aq: Add to amd64 GENERIC and to sys/conf/NOTES.

its' ok i'll land it

Sat, Jan 17, 3:22 AM
adrian accepted D54733: usbdevs: Add USB device IDs for Nuand bladeRF SDR.
Sat, Jan 17, 3:22 AM

Fri, Jan 16

adrian committed rG4b5b8d69b23a: powerpc: fix release image building for Apple partitions (authored by adrian).
powerpc: fix release image building for Apple partitions
Fri, Jan 16, 6:27 AM
adrian added a comment to D54734: spi(8) - "-S" option for continuous stream from standard input to bus.

The manpage could do with a bit more work but we can work on that a bit after landing. Lemme get some more eyeballs on this.

Fri, Jan 16, 12:46 AM

Wed, Jan 14

adrian added inline comments to D54674: sys: add hmp.
Wed, Jan 14, 4:39 PM
adrian committed rGc498eaa2f909: asmc: Add support for MacBookPro11,5 (authored by guest-seuros).
asmc: Add support for MacBookPro11,5
Wed, Jan 14, 3:16 AM
adrian committed rGa24166d23d2e: mtw(4): Fix warm reboot initialization failures for MT7601U (authored by guest-seuros).
mtw(4): Fix warm reboot initialization failures for MT7601U
Wed, Jan 14, 3:16 AM
adrian closed D54665: asmc: Add support for MacBookPro11,5.
Wed, Jan 14, 3:15 AM
adrian closed D54659: mtw(4): Fix warm reboot initialization failures for MT7601U.
Wed, Jan 14, 3:15 AM
adrian added a comment to D54659: mtw(4): Fix warm reboot initialization failures for MT7601U.

nice catch!

Wed, Jan 14, 1:13 AM
adrian accepted D54659: mtw(4): Fix warm reboot initialization failures for MT7601U.
Wed, Jan 14, 1:13 AM
adrian accepted D54666: asmc: Fix asmc_dumpall to enumerate all SMC keys.
Wed, Jan 14, 1:12 AM
adrian added inline comments to D54670: 15.0/eratta: 15.0 doesn't boot on apple G5.
Wed, Jan 14, 12:49 AM

Sun, Jan 11

adrian committed rGa50789d8b89b: powerpc: put the isync inside the TD_LOCK() checking loop (authored by adrian).
powerpc: put the isync inside the TD_LOCK() checking loop
Sun, Jan 11, 7:24 PM
adrian committed rGe5861dc2ea52: Merge commit faa5141b9be4 from file git (by Christos Zoulas): (authored by jrtc27).
Merge commit faa5141b9be4 from file git (by Christos Zoulas):
Sun, Jan 11, 7:23 PM
adrian committed rG7afa03963c44: powerpc: fix release image building for Apple partitions (authored by adrian).
powerpc: fix release image building for Apple partitions
Sun, Jan 11, 7:05 AM
adrian closed D54639: powerpc: fix release image building for Apple partitions.
Sun, Jan 11, 7:05 AM · PowerPC
adrian added a comment to D54639: powerpc: fix release image building for Apple partitions.
In D54639#1248394, @imp wrote:

You could combine the two lines too by

OFFSET=$((0x$(hd...) ))
Sun, Jan 11, 7:01 AM · PowerPC
adrian updated the diff for D54639: powerpc: fix release image building for Apple partitions.

option #2, thanks warner! this is cleaner!

Sun, Jan 11, 6:48 AM · PowerPC
adrian added a comment to D54639: powerpc: fix release image building for Apple partitions.

(no changes planned, please review!)

Sun, Jan 11, 4:09 AM · PowerPC
adrian planned changes to D54639: powerpc: fix release image building for Apple partitions.
Sun, Jan 11, 4:09 AM · PowerPC
adrian requested review of D54639: powerpc: fix release image building for Apple partitions.
Sun, Jan 11, 4:06 AM · PowerPC
adrian accepted D54613: asmc: Convert driver to CTLFLAG_MPSAFE.

let's land this and then figure out how to expand the spin mutexes a bit to cover features a bit cleaner.
(And then see i they really NEED to be spin mutexes..)

Sun, Jan 11, 12:10 AM
adrian added a comment to D54613: asmc: Convert driver to CTLFLAG_MPSAFE.

yeah, looking at asmc again with spin mutex use i really don't want to clean that up whilst removing GIANT here.
it should be ok-ish for now.

Sun, Jan 11, 12:10 AM

Sat, Jan 10

adrian added a comment to D54613: asmc: Convert driver to CTLFLAG_MPSAFE.

I had a chat with seuros on discord about it. I think its fine as an intermediary step, but I do think it'll be worth revisiting the driver locking later and pushing more stuff into functionality locks rather than per device IO locks.

Sat, Jan 10, 8:30 PM
adrian accepted D54633: aq: Add to amd64 GENERIC and to sys/conf/NOTES.

@emaste how's this look to you?

Sat, Jan 10, 5:52 AM
adrian committed rGe28529ca4d34: rge: Add to amd64 GENERIC and to sys/conf/NOTES (authored by brad_comstyle.com).
rge: Add to amd64 GENERIC and to sys/conf/NOTES
Sat, Jan 10, 3:58 AM
adrian closed D54609: rge: Add to amd64 GENERIC and to sys/conf/NOTES.
Sat, Jan 10, 3:57 AM
adrian accepted D54609: rge: Add to amd64 GENERIC and to sys/conf/NOTES.
Sat, Jan 10, 3:54 AM

Fri, Jan 9

adrian accepted D54609: rge: Add to amd64 GENERIC and to sys/conf/NOTES.

oops! good catch

Fri, Jan 9, 6:23 AM

Thu, Jan 8

adrian added a reviewer for D54593: net80211: create IEEE80211_KEYBUF_128_SIZE / IEEE80211_MICBUF_128_SIZE: wireless.
Thu, Jan 8, 7:06 AM · wireless
adrian requested review of D54593: net80211: create IEEE80211_KEYBUF_128_SIZE / IEEE80211_MICBUF_128_SIZE.
Thu, Jan 8, 7:04 AM · wireless

Wed, Jan 7

adrian accepted D54588: linuxkpi: Add `rol32()`.
Wed, Jan 7, 10:37 PM
adrian committed rG5d73fca1f4b2: if_rge: sync with up to date OpenBSD code (authored by brad_comstyle.com).
if_rge: sync with up to date OpenBSD code
Wed, Jan 7, 2:28 AM
adrian added a comment to D54517: if_rge: sync with up to date OpenBSD code.

landed, thanks!

Wed, Jan 7, 2:28 AM
adrian closed D54517: if_rge: sync with up to date OpenBSD code.
Wed, Jan 7, 2:28 AM

Tue, Jan 6

adrian accepted D54510: loader: Only warn when we have neither FDT nor ACPI.
Tue, Jan 6, 4:05 AM

Mon, Jan 5

adrian accepted D54517: if_rge: sync with up to date OpenBSD code.

approved! want me to land it?

Mon, Jan 5, 7:57 AM
adrian added inline comments to D54512: 15.0/errata: Begin listing open regressions.
Mon, Jan 5, 6:11 AM
adrian accepted D54512: 15.0/errata: Begin listing open regressions.
Mon, Jan 5, 5:59 AM
adrian added a comment to D54512: 15.0/errata: Begin listing open regressions.

it's a bit terse, but i think it's fine!

Mon, Jan 5, 5:58 AM
adrian added inline comments to D54462: run: rum: migrate to new net80211 encryption key API.
Mon, Jan 5, 12:42 AM · wireless

Sun, Jan 4

adrian accepted D54405: git-arc: Try to improve documentation.

thanks for pushing forward documentation updates!

Sun, Jan 4, 6:09 PM
adrian added inline comments to D54484: mwl: migrate to new net80211 encryption key API.
Sun, Jan 4, 3:55 AM
adrian added inline comments to D54483: rsu: migrate to new net80211 encryption key API.
Sun, Jan 4, 3:53 AM
adrian requested review of D54485: LinuxKPI: migrate key data access to functions.
Sun, Jan 4, 3:45 AM
adrian requested review of D54484: mwl: migrate to new net80211 encryption key API.
Sun, Jan 4, 3:44 AM
adrian requested review of D54483: rsu: migrate to new net80211 encryption key API.
Sun, Jan 4, 3:44 AM
adrian requested review of D54482: wpi: migrate to new net80211 encryption key API.
Sun, Jan 4, 3:43 AM
adrian requested review of D54481: iwi: migrate to new net80211 encryption key API.
Sun, Jan 4, 3:42 AM
adrian requested review of D54480: ipw: migrate to new net80211 encryption key API.
Sun, Jan 4, 3:42 AM
adrian requested review of D54479: ath: migrate to new net80211 encryption key API.
Sun, Jan 4, 3:41 AM
adrian committed rG8df2e5421468: powerpc: put the isync inside the TD_LOCK() checking loop (authored by adrian).
powerpc: put the isync inside the TD_LOCK() checking loop
Sun, Jan 4, 2:28 AM
adrian closed D54478: powerpc: put the isync inside the TD_LOCK() checking loop.
Sun, Jan 4, 2:28 AM

Sat, Jan 3

adrian added a reviewer for D54478: powerpc: put the isync inside the TD_LOCK() checking loop: jhibbits.
Sat, Jan 3, 11:34 PM
adrian updated the diff for D54478: powerpc: put the isync inside the TD_LOCK() checking loop.

do 32 bit as well, thanks jhibbits

Sat, Jan 3, 11:32 PM
adrian planned changes to D54478: powerpc: put the isync inside the TD_LOCK() checking loop.
Sat, Jan 3, 10:55 PM
adrian requested review of D54478: powerpc: put the isync inside the TD_LOCK() checking loop.
Sat, Jan 3, 10:55 PM
adrian closed D54436: asmc: improve asmc_dumpall to read actual SMC key count.
Sat, Jan 3, 6:49 PM
adrian committed rG2a7c4685b769: asmc: improve asmc_dumpall to read actual SMC key count (authored by guest-seuros).
asmc: improve asmc_dumpall to read actual SMC key count
Sat, Jan 3, 6:49 PM
adrian accepted D54471: dtrace: Add definitiosn for the cam dtrace provider.
Sat, Jan 3, 5:49 PM
adrian accepted D54470: cam: When inq data isn't valid, pass NULL.

accepting; save the manpage include, please shuffle that :p

Sat, Jan 3, 5:48 PM
adrian accepted D54469: cam: Add probes for xpt actions.
Sat, Jan 3, 5:47 PM
adrian accepted D54468: cam: Start adding dtrace provider 'cam'.
Sat, Jan 3, 5:46 PM
adrian accepted D54472: tools/cam: Start to add the testing tools for CAM.
Sat, Jan 3, 5:45 PM
adrian added inline comments to D54470: cam: When inq data isn't valid, pass NULL.
Sat, Jan 3, 5:43 PM
adrian closed D54461: emulators/qemu-devel: add slirp dependency.
Sat, Jan 3, 12:44 AM
adrian committed R11:3c154fd0ad2b: emulators/qemu-devel: add slirp dependency (authored by adrian).
emulators/qemu-devel: add slirp dependency
Sat, Jan 3, 12:44 AM
adrian updated the diff for D54461: emulators/qemu-devel: add slirp dependency.

should be 1, not 2

Sat, Jan 3, 12:06 AM
adrian updated the summary of D54461: emulators/qemu-devel: add slirp dependency.
Sat, Jan 3, 12:05 AM
adrian updated the diff for D54461: emulators/qemu-devel: add slirp dependency.

just do slirp for now, bofh@ says the libfdt/meson internal use is intentional

Sat, Jan 3, 12:04 AM
adrian retitled D54461: emulators/qemu-devel: add slirp dependency from emulators/qemu-devel: add/fix library dependencies; remove libfdt installation to emulators/qemu-devel: add slirp dependency.
Sat, Jan 3, 12:04 AM