Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects (6)

User Details

User Since
May 14 2014, 7:57 AM (616 w, 3 d)

Recent Activity

Thu, Mar 5

adrian accepted D55667: iwx: Fix 32-bit compilation.
Thu, Mar 5, 4:07 PM
adrian added a comment to D55667: iwx: Fix 32-bit compilation.

(Alternative: Don't compile this on 32-bit architectures at all, if if_iwx in reality does not support those.)

Thu, Mar 5, 4:07 PM

Wed, Mar 4

adrian added a project to D55607: hwpmc_amd: fix amd_get_msr() MSR offset for newer counter bases: pmc.
Wed, Mar 4, 6:36 PM · pmc
adrian accepted D55643: net80211: sta: use IEEE80211_STATUS_SUCCESS instead of magic 0.
Wed, Mar 4, 3:18 PM

Tue, Mar 3

adrian added a comment to D55492: virtio_net: Use bus_dma for rxq/txq buffers.

also - are D55492 and D55564 supposed to be tested together in a stack? which should be applied first?

Tue, Mar 3, 4:48 PM · network
adrian added a project to D55492: virtio_net: Use bus_dma for rxq/txq buffers: network.
Tue, Mar 3, 4:46 PM · network
adrian added a comment to D55492: virtio_net: Use bus_dma for rxq/txq buffers.

First up - the alignment should be what the hardware supports, not what the ethernet type supports. Eg, if the virtio API supports 1 byte alignment and it's not hugely inefficient to do so then that's what you should create the DMA tag with.
There's a bunch of un-fun stuff around RX alignment of buffers versus the network stack requirements - notably the IP stack will do unaligned accesses and will trip an exception if you don't enable unaligned access or handle it in said exception handler.
This typically comes up when you have hardware with 4 byte alignment requirements but you need to start the mbuf at a 2 byte offset so a non-VLAN ethernet header will result in the IP header starting at a 4 byte alignment.
(Honestly though it's 2026 and we should just finally fix the IP/TCP stack..) So just keep that in mind if you're trialing 1 byte hardware alignment and you see weird shenanigans with RX path mbufs.

Tue, Mar 3, 4:46 PM · network
adrian added inline comments to D55607: hwpmc_amd: fix amd_get_msr() MSR offset for newer counter bases.
Tue, Mar 3, 3:48 PM · pmc

Thu, Feb 26

adrian committed rG8ebc054acacc: mwl: migrate to new net80211 encryption key API (authored by adrian).
mwl: migrate to new net80211 encryption key API
Thu, Feb 26, 3:56 AM
adrian committed rG70786de406b6: wpi: migrate to new net80211 encryption key API (authored by adrian).
wpi: migrate to new net80211 encryption key API
Thu, Feb 26, 3:56 AM
adrian committed rG76a20323fcfb: iwi: migrate to new net80211 encryption key API (authored by adrian).
iwi: migrate to new net80211 encryption key API
Thu, Feb 26, 3:56 AM
adrian committed rGfec9453dcea4: ipw: migrate to new net80211 encryption key API (authored by adrian).
ipw: migrate to new net80211 encryption key API
Thu, Feb 26, 3:56 AM
adrian committed rGa54a36c40f07: ath: migrate to new net80211 encryption key API (authored by adrian).
ath: migrate to new net80211 encryption key API
Thu, Feb 26, 3:56 AM
adrian closed D54484: mwl: migrate to new net80211 encryption key API.
Thu, Feb 26, 3:56 AM
adrian closed D54482: wpi: migrate to new net80211 encryption key API.
Thu, Feb 26, 3:56 AM
adrian closed D54481: iwi: migrate to new net80211 encryption key API.
Thu, Feb 26, 3:56 AM
adrian closed D54480: ipw: migrate to new net80211 encryption key API.
Thu, Feb 26, 3:56 AM
adrian closed D54479: ath: migrate to new net80211 encryption key API.
Thu, Feb 26, 3:56 AM

Wed, Feb 25

adrian accepted D55496: rge: correct media types in man page.
Wed, Feb 25, 2:49 AM

Mon, Feb 23

adrian accepted D55468: committers-guide: Remove freebsdmall from Benefits.
Mon, Feb 23, 8:22 PM

Sun, Feb 22

adrian committed rGacbf7498f5e1: rge: log silicon revision during attach (authored by chris.longros_gmail.com).
rge: log silicon revision during attach
Sun, Feb 22, 6:09 PM
adrian committed rGd5ca52182e52: rge: fix callout setup/teardown; handle invalid ethernet address (authored by john.darrah09_gmail.com).
rge: fix callout setup/teardown; handle invalid ethernet address
Sun, Feb 22, 6:09 PM
adrian committed rGd1947d0a1a55: rge: correctly free busdma memory / zero things out only if allocated (authored by john.darrah09_gmail.com).
rge: correctly free busdma memory / zero things out only if allocated
Sun, Feb 22, 6:09 PM
adrian closed D55402: rge: log silicon revision during attach.
Sun, Feb 22, 6:08 PM · network
adrian closed D55420: rge: correctly free busdma memory / zero things out only if allocated.
Sun, Feb 22, 6:08 PM · network
adrian closed D55419: rge: fix callout setup/teardown; handle invalid ethernet address.
Sun, Feb 22, 6:08 PM · network
adrian requested review of D55439: x86/ucode: fix gcc uninitialised warning.
Sun, Feb 22, 4:17 PM
adrian committed rG6a6152bc292f: rsu: migrate to new net80211 encryption key API (authored by adrian).
rsu: migrate to new net80211 encryption key API
Sun, Feb 22, 3:30 AM
adrian closed D54483: rsu: migrate to new net80211 encryption key API.
Sun, Feb 22, 3:30 AM
adrian accepted D55402: rge: log silicon revision during attach.
Sun, Feb 22, 2:33 AM · network
adrian committed rG19a18bb750e8: powerpc64: initial conversion of oea64 to rwlocks (authored by adrian).
powerpc64: initial conversion of oea64 to rwlocks
Sun, Feb 22, 2:26 AM
adrian closed D54936: powerpc64: initial conversion of oea64 to rwlocks.
Sun, Feb 22, 2:26 AM · PowerPC

Sat, Feb 21

adrian added reviewers for D55419: rge: fix callout setup/teardown; handle invalid ethernet address: network, imp.
Sat, Feb 21, 8:07 PM · network
adrian added reviewers for D55420: rge: correctly free busdma memory / zero things out only if allocated: network, imp.
Sat, Feb 21, 8:07 PM · network
adrian accepted D55402: rge: log silicon revision during attach.
Sat, Feb 21, 8:07 PM · network
adrian requested review of D55420: rge: correctly free busdma memory / zero things out only if allocated.
Sat, Feb 21, 7:44 PM · network
adrian requested review of D55419: rge: fix callout setup/teardown; handle invalid ethernet address.
Sat, Feb 21, 7:44 PM · network
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

ok, this one boots fine in p8 pseries and p9 pseries, but p8 powernv it .. just hangs during boot and eventually ends up at OPAL.

Sat, Feb 21, 4:07 AM · PowerPC
adrian added a comment to D55315: powerpc: add in some busdma domain setup.

Seeing the same problem with just D54745, D55313, and D55314. I suppose it's possible D54745 could shift things around enough to make the problem appear, but I'm not comfortable merging code into the DMA system when I already know we're violating platform constraints (without D54745 I know for a fact we're allocating bounce buffer in an illegal region and Bad Things via undefined behavior are likely -- just because we get away with it long enough to boot doesn't mean we're not going to get data corruption and lockups later on).

Sat, Feb 21, 2:32 AM · PowerPC

Wed, Feb 18

adrian added a comment to D55315: powerpc: add in some busdma domain setup.

ok, does this happen without this domain change? can you just try D55312, D55313, D55314?

Wed, Feb 18, 3:54 PM · PowerPC
adrian added a comment to D55315: powerpc: add in some busdma domain setup.

oh interesting. is this different from straight -head? If it is then i need to fix it. If it isn't then it's expected behaviour!

Wed, Feb 18, 3:31 PM · PowerPC
adrian added reviewers for D55340: powerpc: refactor common busdma tag setup: jhibbits, PowerPC.
Wed, Feb 18, 6:53 AM · PowerPC
adrian requested review of D55340: powerpc: refactor common busdma tag setup.
Wed, Feb 18, 6:52 AM · PowerPC
adrian updated the diff for D55315: powerpc: add in some busdma domain setup.

refactor

Wed, Feb 18, 6:43 AM · PowerPC
adrian updated the diff for D55315: powerpc: add in some busdma domain setup.

refactor

Wed, Feb 18, 6:41 AM · PowerPC
adrian updated the diff for D55314: powerpc: create a tag with the parents implementation if supplied.

refactor

Wed, Feb 18, 6:38 AM · PowerPC
adrian updated the diff for D55313: powerpc: initial straight port of busdma_machdep.c -> busdma_bounce.c.

refactor

Wed, Feb 18, 6:28 AM · PowerPC

Tue, Feb 17

adrian added reviewers for D55315: powerpc: add in some busdma domain setup: jhibbits, tpearson_raptorengineering.com.
Tue, Feb 17, 4:12 PM · PowerPC
adrian added reviewers for D55314: powerpc: create a tag with the parents implementation if supplied: jhibbits, tpearson_raptorengineering.com.
Tue, Feb 17, 4:12 PM · PowerPC
adrian added reviewers for D55313: powerpc: initial straight port of busdma_machdep.c -> busdma_bounce.c: jhibbits, tpearson_raptorengineering.com.
Tue, Feb 17, 4:11 PM · PowerPC
adrian added a reviewer for D55312: powerpc: implement lock iteration for mmu_oea64 pmap: jhibbits.
Tue, Feb 17, 4:11 PM · PowerPC

Mon, Feb 16

adrian requested review of D55315: powerpc: add in some busdma domain setup.
Mon, Feb 16, 8:11 PM · PowerPC
adrian requested review of D55314: powerpc: create a tag with the parents implementation if supplied.
Mon, Feb 16, 8:11 PM · PowerPC
adrian requested review of D55313: powerpc: initial straight port of busdma_machdep.c -> busdma_bounce.c.
Mon, Feb 16, 8:11 PM · PowerPC
adrian updated the summary of D54936: powerpc64: initial conversion of oea64 to rwlocks.
Mon, Feb 16, 5:57 PM · PowerPC
adrian requested review of D55312: powerpc: implement lock iteration for mmu_oea64 pmap.
Mon, Feb 16, 5:54 PM · PowerPC
adrian updated the diff for D54936: powerpc64: initial conversion of oea64 to rwlocks.

migrate this to /just/ do rwlock migration, not the iteration stuff.

Mon, Feb 16, 5:54 PM · PowerPC
adrian closed D55093: powerpc: document the magic constants for 16MB page size.
Mon, Feb 16, 5:51 PM · PowerPC
adrian committed rG995090202cae: powerpc: document the magic constants for 16MB page size (authored by adrian).
powerpc: document the magic constants for 16MB page size
Mon, Feb 16, 5:51 PM
adrian closed D55071: powerpc: enable HPT superpages by default.
Mon, Feb 16, 5:50 PM · PowerPC
adrian committed rGf412a5c565de: powerpc: enable HPT superpages by default (authored by adrian).
powerpc: enable HPT superpages by default
Mon, Feb 16, 5:50 PM
adrian added a comment to D55265: acpi_panasonic: Clear wireless RF_KILL on boot and resume.

Hm, this is an interesting problem/question.

Mon, Feb 16, 4:02 AM
adrian committed rGe4bcfe4ebf03: ichsmb: Add Intel Raptor Lake SMBus controller support (authored by guest-seuros).
ichsmb: Add Intel Raptor Lake SMBus controller support
Mon, Feb 16, 4:00 AM
adrian closed D54957: ichsmb: Add Intel Raptor Lake SMBus controller support.
Mon, Feb 16, 3:59 AM

Sun, Feb 15

adrian accepted D55289: libusb: dequeue next transfer on completion to prevent stalls.
Sun, Feb 15, 8:05 PM
adrian accepted D55291: libusb: make libusb_hotplug_get_user_data actually return user_data.
Sun, Feb 15, 8:04 PM
adrian added a comment to D55289: libusb: dequeue next transfer on completion to prevent stalls.

oh this is a good catch!

Sun, Feb 15, 6:22 PM
adrian accepted D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages..

looks good plz land

Sun, Feb 15, 5:02 PM · USB
adrian updated the diff for D54936: powerpc64: initial conversion of oea64 to rwlocks.

compile tested

Sun, Feb 15, 4:40 AM · PowerPC
adrian updated the diff for D54936: powerpc64: initial conversion of oea64 to rwlocks.

rw_init_flags() -> rw_init()

Sun, Feb 15, 3:30 AM · PowerPC
adrian added inline comments to D54936: powerpc64: initial conversion of oea64 to rwlocks.
Sun, Feb 15, 3:27 AM · PowerPC
adrian committed rG90d79dd54946: asmc: Add MacPro3,1 temperature sensor support (authored by guest-seuros).
asmc: Add MacPro3,1 temperature sensor support
Sun, Feb 15, 2:13 AM
adrian closed D54952: asmc: Add MacPro3,1 temperature sensor support.
Sun, Feb 15, 2:12 AM

Sat, Feb 14

adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

nope, still no dice

Sat, Feb 14, 7:21 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

ok, lemme try this latest one in qemu real quick, hold.

Sat, Feb 14, 7:19 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

Just tried the latest diff on power9/pseries qemu, it panics differently now

Sat, Feb 14, 12:58 AM · PowerPC

Fri, Feb 13

adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

ok i thought this was OK on power9 but it seems not:

Fri, Feb 13, 7:30 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

ok, tried with 8g in the VM instead of 2g, same issue.

Fri, Feb 13, 4:02 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

and from justin on irc

Fri, Feb 13, 4:00 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

This boots fine in qemu-system-ppc64 pseries9 + power9, but in qemu-system-ppc64 pseries-8.0 + power8, it immediately panics on boot with

Fri, Feb 13, 3:29 PM · PowerPC
adrian accepted D55265: acpi_panasonic: Clear wireless RF_KILL on boot and resume.
Fri, Feb 13, 3:34 AM
adrian added inline comments to D55265: acpi_panasonic: Clear wireless RF_KILL on boot and resume.
Fri, Feb 13, 3:34 AM
adrian accepted D54952: asmc: Add MacPro3,1 temperature sensor support.
Fri, Feb 13, 3:32 AM
adrian accepted D54957: ichsmb: Add Intel Raptor Lake SMBus controller support.
Fri, Feb 13, 3:32 AM
adrian committed rG1a6bdd6266e3: asmc: Convert driver to CTLFLAG_MPSAFE (authored by guest-seuros).
asmc: Convert driver to CTLFLAG_MPSAFE
Fri, Feb 13, 3:02 AM
adrian closed D54613: asmc: Convert driver to CTLFLAG_MPSAFE.
Fri, Feb 13, 3:01 AM

Wed, Feb 11

adrian committed rGf064d44badfa: run: rum: migrate to new net80211 encryption key API (authored by adrian).
run: rum: migrate to new net80211 encryption key API
Wed, Feb 11, 6:05 AM
adrian committed rGc08ee1eba989: iwx: migrate to new net80211 encryption key API (authored by adrian).
iwx: migrate to new net80211 encryption key API
Wed, Feb 11, 6:05 AM
adrian committed rG7a5288a023ba: net80211: clean up time comparison in HT code (authored by adrian).
net80211: clean up time comparison in HT code
Wed, Feb 11, 6:05 AM
adrian closed D54463: iwx: migrate to new net80211 encryption key API.
Wed, Feb 11, 6:05 AM · wireless
adrian closed D54462: run: rum: migrate to new net80211 encryption key API.
Wed, Feb 11, 6:05 AM · wireless
adrian closed D54390: net80211: clean up time comparison in HT code.
Wed, Feb 11, 6:05 AM · wireless

Tue, Feb 10

adrian accepted D55236: ip_mroute: Make the routing socket private.
Tue, Feb 10, 11:15 PM

Mon, Feb 9

adrian accepted D54795: net80211: in net80211_vap_printf() also use vprintf().
Mon, Feb 9, 5:07 PM
adrian added a comment to D54795: net80211: in net80211_vap_printf() also use vprintf().

I think it's fine to land as-is. Yes, the vlog vs vprintf discussion should happen soon. :-)

Mon, Feb 9, 5:07 PM

Sun, Feb 8

adrian added a reviewer for D55084: powerpc64/busdma: Migrate bounce DMA to common framework: adrian.
Sun, Feb 8, 7:53 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

oh crap i missed testing this; lemme test this on -HEAD today on the G5 and POWER8.

Sun, Feb 8, 7:50 PM · PowerPC
adrian added a comment to D39626: libpmcstat: Teach pmcstat_image_get_elf_params about debug files.

As mentioned on IRC, I think we should create _PATH_DEBUG_PREFIX or something similar to hide the /usr/lib/debug path.

Sun, Feb 8, 5:54 PM
adrian added inline comments to D54936: powerpc64: initial conversion of oea64 to rwlocks.
Sun, Feb 8, 5:42 AM · PowerPC
adrian updated the summary of D54936: powerpc64: initial conversion of oea64 to rwlocks.
Sun, Feb 8, 5:41 AM · PowerPC