Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects (6)

User Details

User Since
May 14 2014, 7:57 AM (614 w, 4 d)

Recent Activity

Today

adrian committed rG6a6152bc292f: rsu: migrate to new net80211 encryption key API (authored by adrian).
rsu: migrate to new net80211 encryption key API
Sun, Feb 22, 3:30 AM
adrian closed D54483: rsu: migrate to new net80211 encryption key API.
Sun, Feb 22, 3:30 AM
adrian accepted D55402: rge: log silicon revision during attach.
Sun, Feb 22, 2:33 AM · network
adrian committed rG19a18bb750e8: powerpc64: initial conversion of oea64 to rwlocks (authored by adrian).
powerpc64: initial conversion of oea64 to rwlocks
Sun, Feb 22, 2:26 AM
adrian closed D54936: powerpc64: initial conversion of oea64 to rwlocks.
Sun, Feb 22, 2:26 AM · PowerPC

Yesterday

adrian added reviewers for D55419: rge: fix callout setup/teardown; handle invalid ethernet address: network, imp.
Sat, Feb 21, 8:07 PM · network
adrian added reviewers for D55420: rge: correctly free busdma memory / zero things out only if allocated: network, imp.
Sat, Feb 21, 8:07 PM · network
adrian accepted D55402: rge: log silicon revision during attach.
Sat, Feb 21, 8:07 PM · network
adrian requested review of D55420: rge: correctly free busdma memory / zero things out only if allocated.
Sat, Feb 21, 7:44 PM · network
adrian requested review of D55419: rge: fix callout setup/teardown; handle invalid ethernet address.
Sat, Feb 21, 7:44 PM · network
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

ok, this one boots fine in p8 pseries and p9 pseries, but p8 powernv it .. just hangs during boot and eventually ends up at OPAL.

Sat, Feb 21, 4:07 AM · PowerPC
adrian added a comment to D55315: powerpc: add in some busdma domain setup.

Seeing the same problem with just D54745, D55313, and D55314. I suppose it's possible D54745 could shift things around enough to make the problem appear, but I'm not comfortable merging code into the DMA system when I already know we're violating platform constraints (without D54745 I know for a fact we're allocating bounce buffer in an illegal region and Bad Things via undefined behavior are likely -- just because we get away with it long enough to boot doesn't mean we're not going to get data corruption and lockups later on).

Sat, Feb 21, 2:32 AM · PowerPC

Wed, Feb 18

adrian added a comment to D55315: powerpc: add in some busdma domain setup.

ok, does this happen without this domain change? can you just try D55312, D55313, D55314?

Wed, Feb 18, 3:54 PM · PowerPC
adrian added a comment to D55315: powerpc: add in some busdma domain setup.

oh interesting. is this different from straight -head? If it is then i need to fix it. If it isn't then it's expected behaviour!

Wed, Feb 18, 3:31 PM · PowerPC
adrian added reviewers for D55340: powerpc: refactor common busdma tag setup: jhibbits, PowerPC.
Wed, Feb 18, 6:53 AM · PowerPC
adrian requested review of D55340: powerpc: refactor common busdma tag setup.
Wed, Feb 18, 6:52 AM · PowerPC
adrian updated the diff for D55315: powerpc: add in some busdma domain setup.

refactor

Wed, Feb 18, 6:43 AM · PowerPC
adrian updated the diff for D55315: powerpc: add in some busdma domain setup.

refactor

Wed, Feb 18, 6:41 AM · PowerPC
adrian updated the diff for D55314: powerpc: create a tag with the parents implementation if supplied.

refactor

Wed, Feb 18, 6:38 AM · PowerPC
adrian updated the diff for D55313: powerpc: initial straight port of busdma_machdep.c -> busdma_bounce.c.

refactor

Wed, Feb 18, 6:28 AM · PowerPC

Tue, Feb 17

adrian added reviewers for D55315: powerpc: add in some busdma domain setup: jhibbits, tpearson_raptorengineering.com.
Tue, Feb 17, 4:12 PM · PowerPC
adrian added reviewers for D55314: powerpc: create a tag with the parents implementation if supplied: jhibbits, tpearson_raptorengineering.com.
Tue, Feb 17, 4:12 PM · PowerPC
adrian added reviewers for D55313: powerpc: initial straight port of busdma_machdep.c -> busdma_bounce.c: jhibbits, tpearson_raptorengineering.com.
Tue, Feb 17, 4:11 PM · PowerPC
adrian added a reviewer for D55312: powerpc: implement lock iteration for mmu_oea64 pmap: jhibbits.
Tue, Feb 17, 4:11 PM · PowerPC

Mon, Feb 16

adrian requested review of D55315: powerpc: add in some busdma domain setup.
Mon, Feb 16, 8:11 PM · PowerPC
adrian requested review of D55314: powerpc: create a tag with the parents implementation if supplied.
Mon, Feb 16, 8:11 PM · PowerPC
adrian requested review of D55313: powerpc: initial straight port of busdma_machdep.c -> busdma_bounce.c.
Mon, Feb 16, 8:11 PM · PowerPC
adrian updated the summary of D54936: powerpc64: initial conversion of oea64 to rwlocks.
Mon, Feb 16, 5:57 PM · PowerPC
adrian requested review of D55312: powerpc: implement lock iteration for mmu_oea64 pmap.
Mon, Feb 16, 5:54 PM · PowerPC
adrian updated the diff for D54936: powerpc64: initial conversion of oea64 to rwlocks.

migrate this to /just/ do rwlock migration, not the iteration stuff.

Mon, Feb 16, 5:54 PM · PowerPC
adrian closed D55093: powerpc: document the magic constants for 16MB page size.
Mon, Feb 16, 5:51 PM · PowerPC
adrian committed rG995090202cae: powerpc: document the magic constants for 16MB page size (authored by adrian).
powerpc: document the magic constants for 16MB page size
Mon, Feb 16, 5:51 PM
adrian closed D55071: powerpc: enable HPT superpages by default.
Mon, Feb 16, 5:50 PM · PowerPC
adrian committed rGf412a5c565de: powerpc: enable HPT superpages by default (authored by adrian).
powerpc: enable HPT superpages by default
Mon, Feb 16, 5:50 PM
adrian added a comment to D55265: acpi_panasonic: Clear wireless RF_KILL on boot and resume.

Hm, this is an interesting problem/question.

Mon, Feb 16, 4:02 AM
adrian committed rGe4bcfe4ebf03: ichsmb: Add Intel Raptor Lake SMBus controller support (authored by guest-seuros).
ichsmb: Add Intel Raptor Lake SMBus controller support
Mon, Feb 16, 4:00 AM
adrian closed D54957: ichsmb: Add Intel Raptor Lake SMBus controller support.
Mon, Feb 16, 3:59 AM

Sun, Feb 15

adrian accepted D55289: libusb: dequeue next transfer on completion to prevent stalls.
Sun, Feb 15, 8:05 PM
adrian accepted D55291: libusb: make libusb_hotplug_get_user_data actually return user_data.
Sun, Feb 15, 8:04 PM
adrian added a comment to D55289: libusb: dequeue next transfer on completion to prevent stalls.

oh this is a good catch!

Sun, Feb 15, 6:22 PM
adrian accepted D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages..

looks good plz land

Sun, Feb 15, 5:02 PM · USB
adrian updated the diff for D54936: powerpc64: initial conversion of oea64 to rwlocks.

compile tested

Sun, Feb 15, 4:40 AM · PowerPC
adrian updated the diff for D54936: powerpc64: initial conversion of oea64 to rwlocks.

rw_init_flags() -> rw_init()

Sun, Feb 15, 3:30 AM · PowerPC
adrian added inline comments to D54936: powerpc64: initial conversion of oea64 to rwlocks.
Sun, Feb 15, 3:27 AM · PowerPC
adrian committed rG90d79dd54946: asmc: Add MacPro3,1 temperature sensor support (authored by guest-seuros).
asmc: Add MacPro3,1 temperature sensor support
Sun, Feb 15, 2:13 AM
adrian closed D54952: asmc: Add MacPro3,1 temperature sensor support.
Sun, Feb 15, 2:12 AM

Sat, Feb 14

adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

nope, still no dice

Sat, Feb 14, 7:21 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

ok, lemme try this latest one in qemu real quick, hold.

Sat, Feb 14, 7:19 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

Just tried the latest diff on power9/pseries qemu, it panics differently now

Sat, Feb 14, 12:58 AM · PowerPC

Fri, Feb 13

adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

ok i thought this was OK on power9 but it seems not:

Fri, Feb 13, 7:30 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

ok, tried with 8g in the VM instead of 2g, same issue.

Fri, Feb 13, 4:02 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

and from justin on irc

Fri, Feb 13, 4:00 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

This boots fine in qemu-system-ppc64 pseries9 + power9, but in qemu-system-ppc64 pseries-8.0 + power8, it immediately panics on boot with

Fri, Feb 13, 3:29 PM · PowerPC
adrian accepted D55265: acpi_panasonic: Clear wireless RF_KILL on boot and resume.
Fri, Feb 13, 3:34 AM
adrian added inline comments to D55265: acpi_panasonic: Clear wireless RF_KILL on boot and resume.
Fri, Feb 13, 3:34 AM
adrian accepted D54952: asmc: Add MacPro3,1 temperature sensor support.
Fri, Feb 13, 3:32 AM
adrian accepted D54957: ichsmb: Add Intel Raptor Lake SMBus controller support.
Fri, Feb 13, 3:32 AM
adrian committed rG1a6bdd6266e3: asmc: Convert driver to CTLFLAG_MPSAFE (authored by guest-seuros).
asmc: Convert driver to CTLFLAG_MPSAFE
Fri, Feb 13, 3:02 AM
adrian closed D54613: asmc: Convert driver to CTLFLAG_MPSAFE.
Fri, Feb 13, 3:01 AM

Wed, Feb 11

adrian committed rGf064d44badfa: run: rum: migrate to new net80211 encryption key API (authored by adrian).
run: rum: migrate to new net80211 encryption key API
Wed, Feb 11, 6:05 AM
adrian committed rGc08ee1eba989: iwx: migrate to new net80211 encryption key API (authored by adrian).
iwx: migrate to new net80211 encryption key API
Wed, Feb 11, 6:05 AM
adrian committed rG7a5288a023ba: net80211: clean up time comparison in HT code (authored by adrian).
net80211: clean up time comparison in HT code
Wed, Feb 11, 6:05 AM
adrian closed D54463: iwx: migrate to new net80211 encryption key API.
Wed, Feb 11, 6:05 AM · wireless
adrian closed D54462: run: rum: migrate to new net80211 encryption key API.
Wed, Feb 11, 6:05 AM · wireless
adrian closed D54390: net80211: clean up time comparison in HT code.
Wed, Feb 11, 6:05 AM · wireless

Tue, Feb 10

adrian accepted D55236: ip_mroute: Make the routing socket private.
Tue, Feb 10, 11:15 PM

Mon, Feb 9

adrian accepted D54795: net80211: in net80211_vap_printf() also use vprintf().
Mon, Feb 9, 5:07 PM
adrian added a comment to D54795: net80211: in net80211_vap_printf() also use vprintf().

I think it's fine to land as-is. Yes, the vlog vs vprintf discussion should happen soon. :-)

Mon, Feb 9, 5:07 PM

Sun, Feb 8

adrian added a reviewer for D55084: powerpc64/busdma: Migrate bounce DMA to common framework: adrian.
Sun, Feb 8, 7:53 PM · PowerPC
adrian added a comment to D55084: powerpc64/busdma: Migrate bounce DMA to common framework.

oh crap i missed testing this; lemme test this on -HEAD today on the G5 and POWER8.

Sun, Feb 8, 7:50 PM · PowerPC
adrian added a comment to D39626: libpmcstat: Teach pmcstat_image_get_elf_params about debug files.

As mentioned on IRC, I think we should create _PATH_DEBUG_PREFIX or something similar to hide the /usr/lib/debug path.

Sun, Feb 8, 5:54 PM
adrian added inline comments to D54936: powerpc64: initial conversion of oea64 to rwlocks.
Sun, Feb 8, 5:42 AM · PowerPC
adrian updated the summary of D54936: powerpc64: initial conversion of oea64 to rwlocks.
Sun, Feb 8, 5:41 AM · PowerPC
adrian updated the diff for D54936: powerpc64: initial conversion of oea64 to rwlocks.
  • convert the superpage lock path to use the iterator lock
  • and another function involved as well
Sun, Feb 8, 5:41 AM · PowerPC
adrian added inline comments to D54936: powerpc64: initial conversion of oea64 to rwlocks.
Sun, Feb 8, 5:10 AM · PowerPC
adrian updated the diff for D54936: powerpc64: initial conversion of oea64 to rwlocks.

delete old code

Sun, Feb 8, 4:05 AM · PowerPC

Sat, Feb 7

adrian added a comment to D54936: powerpc64: initial conversion of oea64 to rwlocks.

updated; i removed the recursive lock as now we shouldn't be recursing.

Sat, Feb 7, 4:41 AM · PowerPC
adrian updated the diff for D54936: powerpc64: initial conversion of oea64 to rwlocks.

update

Sat, Feb 7, 4:39 AM · PowerPC

Fri, Feb 6

adrian added a comment to D54355: stdio: rename short _fileno to _fileno_short for legacy abi compatibility, add new int _fileno in struct __sFILE.

I can see that int _flags2 was added to FILE ten years ago and only one bit has been defined leaving 31 unused bits, precisely what's needed to represent any non-negative file descriptor.
So I'm reworking this to not add a new field but rather continue using short _file for <32768 and the high 31 bits of _flags2 for descriptors >32767 && <0x7fffffff; the size of FILE will not need to change.

Fri, Feb 6, 5:12 PM
adrian added inline comments to D54936: powerpc64: initial conversion of oea64 to rwlocks.
Fri, Feb 6, 1:50 AM · PowerPC
adrian abandoned D55073: sdt: fix macro to compile on powerpc.

not needed now!

Fri, Feb 6, 1:49 AM · PowerPC

Thu, Feb 5

adrian added a comment to D55126: freebsd-git-arc-devtools: Was freebsd-git-devtools.

I did, I tried searching for 'pkg search git-arc' ;-P

Thu, Feb 5, 4:54 PM
adrian accepted D55095: powerpc64: Fix disappearing low memory on radix MMU systems (POWER9).

looks good, land when you're ready!

Thu, Feb 5, 5:23 AM · PowerPC

Wed, Feb 4

adrian accepted D54927: aw_ccu: Add clocks for H616.
Wed, Feb 4, 4:42 PM
adrian added a comment to D54355: stdio: rename short _fileno to _fileno_short for legacy abi compatibility, add new int _fileno in struct __sFILE.

@jhb so the submitter is going to also need to add/bump symbol versions to a bunch of stdio routines? Is that what you're saying?

Wed, Feb 4, 3:31 PM
adrian accepted D55097: aw_mmc: Reset controller and configure read fifo size.

This looks fine to me, nice catch!

Wed, Feb 4, 3:19 PM
adrian accepted D54814: sdt: Enable on 32-bit powerpc and powerpc64le.
Wed, Feb 4, 6:54 AM
adrian committed rG3f3cc6fd69e4: if_rge: sync with up to date OpenBSD code (authored by brad_comstyle.com).
if_rge: sync with up to date OpenBSD code
Wed, Feb 4, 6:30 AM
adrian closed D54922: if_rge: sync with up to date OpenBSD code.
Wed, Feb 4, 6:30 AM
adrian accepted D54922: if_rge: sync with up to date OpenBSD code.
Wed, Feb 4, 6:24 AM
adrian accepted D55095: powerpc64: Fix disappearing low memory on radix MMU systems (POWER9).

I think this is fine; let's see what justin thinks tomorrow morning!

Wed, Feb 4, 6:23 AM · PowerPC
adrian added a comment to D55095: powerpc64: Fix disappearing low memory on radix MMU systems (POWER9).

oh that's a good catch!

Wed, Feb 4, 6:19 AM · PowerPC
adrian added a reviewer for D55095: powerpc64: Fix disappearing low memory on radix MMU systems (POWER9): PowerPC.
Wed, Feb 4, 6:19 AM · PowerPC
adrian added a comment to D54745: powerpc64/powernv: Enable Partitionable Endpoint (PE) support.

Also /proc/iomem, which i think has what you're after in more specific detail:

Wed, Feb 4, 5:02 AM · PowerPC
adrian added a comment to D54745: powerpc64/powernv: Enable Partitionable Endpoint (PE) support.

here's petitboot:

Wed, Feb 4, 4:57 AM · PowerPC
adrian added a comment to D54745: powerpc64/powernv: Enable Partitionable Endpoint (PE) support.

ok, two normal boots and then the boot with this diff attached are at https://people.freebsd.org/~adrian/powerpc64/20260203-D54745-fail-1.txt .

Wed, Feb 4, 12:50 AM · PowerPC
adrian added a comment to D54745: powerpc64/powernv: Enable Partitionable Endpoint (PE) support.

so it didn't finish booting;

Wed, Feb 4, 12:47 AM · PowerPC
adrian added a comment to D54745: powerpc64/powernv: Enable Partitionable Endpoint (PE) support.

ok, its definitely unhappy, stay tuned!

Wed, Feb 4, 12:45 AM · PowerPC

Tue, Feb 3

adrian updated the diff for D54936: powerpc64: initial conversion of oea64 to rwlocks.

rebase after jhibbits@ recent changes

Tue, Feb 3, 11:20 PM · PowerPC
adrian added reviewers for D55093: powerpc: document the magic constants for 16MB page size: jhibbits, PowerPC, tpearson_raptorengineering.com.
Tue, Feb 3, 11:16 PM · PowerPC