Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects (13)

User Details

User Since
May 14 2014, 7:57 AM (631 w, 5 d)

Recent Activity

Today

adrian accepted D57392: virtio: remove byte conversion function calls in modern pci.
Mon, Jun 22, 4:19 PM
adrian committed rG3ffd2baa268d: if_fwsubr: remove ARP target hardware address trimming (authored by guest-seuros).
if_fwsubr: remove ARP target hardware address trimming
Mon, Jun 22, 12:42 AM
adrian committed rG51f4e90ce7ef: firewire: NULL check on malloc in fw_busreset() (authored by guest-seuros).
firewire: NULL check on malloc in fw_busreset()
Mon, Jun 22, 12:42 AM
adrian closed D57617: if_fwsubr: remove ARP target hardware address trimming.
Mon, Jun 22, 12:41 AM · network, drivers, firewire
adrian closed D57728: firewire: NULL check on malloc in fw_busreset().
Mon, Jun 22, 12:41 AM · drivers, firewire

Yesterday

adrian added inline comments to D57685: fwcam: add IIDC 1394 FireWire camera driver.
Sun, Jun 21, 10:09 PM · firewire
adrian accepted D57728: firewire: NULL check on malloc in fw_busreset().
Sun, Jun 21, 8:32 PM · drivers, firewire
adrian accepted D57685: fwcam: add IIDC 1394 FireWire camera driver.

in general this looks fine! thanks!

Sun, Jun 21, 8:14 PM · firewire
adrian accepted D57617: if_fwsubr: remove ARP target hardware address trimming.
Sun, Jun 21, 8:10 PM · network, drivers, firewire
adrian added a comment to D57617: if_fwsubr: remove ARP target hardware address trimming.

ok, if you have tested it between macosx and linux and freebsd then that's good enough for me.

Sun, Jun 21, 8:10 PM · network, drivers, firewire

Sat, Jun 20

adrian accepted D57673: ig4: unconditionally un-idle the controller core on resume.
Sat, Jun 20, 9:58 PM · drivers
adrian committed rGe44579e23430: aq(4): naming and exposure (authored by nick_spun.io).
aq(4): naming and exposure
Sat, Jun 20, 7:13 PM
adrian committed rG76d0a25be397: aq(4): add a runtime dev.aq.N.debug trace control (authored by nick_spun.io).
aq(4): add a runtime dev.aq.N.debug trace control
Sat, Jun 20, 7:12 PM
adrian committed rGa10151fa662c: aq(4): take F/W statistics off the iflib core lock (kick-and-read) (authored by nick_spun.io).
aq(4): take F/W statistics off the iflib core lock (kick-and-read)
Sat, Jun 20, 7:12 PM
adrian closed D57656: aq(4): naming and exposure.
Sat, Jun 20, 7:12 PM · drivers
adrian closed D57440: aq(4): add a runtime dev.aq.N.debug trace control.
Sat, Jun 20, 7:12 PM · drivers
adrian committed rG5409e03a0ef1: aq(4): modernize and de-Linuxify the vendor driver (authored by nick_spun.io).
aq(4): modernize and de-Linuxify the vendor driver
Sat, Jun 20, 7:12 PM
adrian closed D57439: aq(4): take F/W statistics off the iflib core lock (kick-and-read).
Sat, Jun 20, 7:12 PM · drivers
adrian committed rGb64408358d7f: aq(4): enable jumbo frames, software LRO, and suspend/resume (authored by nick_spun.io).
aq(4): enable jumbo frames, software LRO, and suspend/resume
Sat, Jun 20, 7:12 PM
adrian closed D57438: aq(4): modernize and de-Linuxify the vendor driver.
Sat, Jun 20, 7:11 PM · drivers
adrian committed rG40accc7235c2: aq(4): adopt native FreeBSD errno convention (authored by nick_spun.io).
aq(4): adopt native FreeBSD errno convention
Sat, Jun 20, 7:11 PM
adrian closed D57437: aq(4): enable jumbo frames, software LRO, and suspend/resume.
Sat, Jun 20, 7:11 PM · drivers
adrian committed rG619934a5c165: aq(4): RX/TX and HW-path correctness and hardening (authored by Nick Pricenull <nick@spun.ionull>).
aq(4): RX/TX and HW-path correctness and hardening
Sat, Jun 20, 7:11 PM
adrian closed D57436: aq(4): RX/TX and HW-path correctness and hardening.
Sat, Jun 20, 7:11 PM · drivers
adrian committed rG57f5252ff8a1: aq(4): Fix RSS indirection table OOB write and queue distribution (authored by nick_spun.io).
aq(4): Fix RSS indirection table OOB write and queue distribution
Sat, Jun 20, 7:11 PM
adrian closed D57435: aq(4): adopt native FreeBSD errno convention.
Sat, Jun 20, 7:11 PM · drivers
adrian committed rGb065af196fdc: aq(4): interrupt model and queue-count correctness (authored by Nick Pricenull <nick@spun.ionull>).
aq(4): interrupt model and queue-count correctness
Sat, Jun 20, 7:11 PM
adrian closed D57434: aq(4): interrupt model and queue-count correctness.
Sat, Jun 20, 7:11 PM · drivers
adrian closed D57240: aq(4): Fix RSS indirection table OOB write and queue distribution.
Sat, Jun 20, 7:10 PM · drivers
adrian accepted D57436: aq(4): RX/TX and HW-path correctness and hardening.
Sat, Jun 20, 4:10 PM · drivers
adrian accepted D57434: aq(4): interrupt model and queue-count correctness.
Sat, Jun 20, 4:10 PM · drivers
adrian added a comment to D37973: wtapctl(8): Introduce new tool for wtap(4).

ok, this is the next thing to dig into and figure out how to land.

Sat, Jun 20, 4:04 PM · wireless
adrian added inline comments to D57673: ig4: unconditionally un-idle the controller core on resume.
Sat, Jun 20, 3:30 PM · drivers

Fri, Jun 19

adrian accepted D57340: Move all the software license stuff to a central location..
Fri, Jun 19, 8:08 PM · docs
adrian accepted D57514: policy: Cross Repo Commit Policy.
Fri, Jun 19, 8:07 PM
adrian committed rG9919c1a8ebd7: firewire: extract shared helpers from fwe and fwip (authored by guest-seuros).
firewire: extract shared helpers from fwe and fwip
Fri, Jun 19, 7:02 PM
adrian closed D57615: firewire: extract shared helpers from fwe and fwip.
Fri, Jun 19, 7:01 PM · firewire
adrian added inline comments to D57673: ig4: unconditionally un-idle the controller core on resume.
Fri, Jun 19, 5:40 PM · drivers
adrian added a project to D57673: ig4: unconditionally un-idle the controller core on resume: drivers.
Fri, Jun 19, 5:38 PM · drivers
adrian accepted D52244: usb: preserve error when doing request.
Fri, Jun 19, 5:09 AM
adrian accepted D57434: aq(4): interrupt model and queue-count correctness.
Fri, Jun 19, 4:00 AM · drivers
adrian accepted D57656: aq(4): naming and exposure.
Fri, Jun 19, 2:39 AM · drivers
adrian added a reviewer for D57656: aq(4): naming and exposure: drivers.
Fri, Jun 19, 2:36 AM · drivers
adrian accepted D57434: aq(4): interrupt model and queue-count correctness.
Fri, Jun 19, 2:17 AM · drivers
adrian accepted D57436: aq(4): RX/TX and HW-path correctness and hardening.
Fri, Jun 19, 2:17 AM · drivers

Thu, Jun 18

adrian updated subscribers of D57617: if_fwsubr: remove ARP target hardware address trimming.
Thu, Jun 18, 8:46 PM · network, drivers, firewire
adrian added a comment to D57617: if_fwsubr: remove ARP target hardware address trimming.

wait, did this change at some point?

Thu, Jun 18, 8:45 PM · network, drivers, firewire
adrian accepted D50958: libusb: implement IAD parser.

Ah, you haven't gone through and marked them as "done".

Thu, Jun 18, 2:25 PM
adrian accepted D51759: libusb: implement zlp flag in libusb transfer.
Thu, Jun 18, 5:12 AM · USB
adrian added a reviewer for D51759: libusb: implement zlp flag in libusb transfer: USB.
Thu, Jun 18, 5:11 AM · USB
adrian accepted D51225: libusb: implement libusb_get_max_alt_packet_size.
Thu, Jun 18, 5:10 AM
adrian accepted D51224: libusb: refactor the process of setting option when init the context..
Thu, Jun 18, 5:08 AM
adrian added a comment to D50958: libusb: implement IAD parser.

please address lwhsu's comments!

Thu, Jun 18, 5:07 AM
adrian added inline comments to D50818: libusb: implement libusb_set_option.
Thu, Jun 18, 5:06 AM

Wed, Jun 17

adrian accepted D57620: libusb: Update libusb_class_code.
Wed, Jun 17, 8:08 PM
adrian added a reviewer for D57440: aq(4): add a runtime dev.aq.N.debug trace control: drivers.
Wed, Jun 17, 8:02 PM · drivers
adrian accepted D57440: aq(4): add a runtime dev.aq.N.debug trace control.
Wed, Jun 17, 8:02 PM · drivers
adrian added a comment to D57440: aq(4): add a runtime dev.aq.N.debug trace control.

this is fine; we can update this after it lands to configure it as a bitmask and per-softc.

Wed, Jun 17, 8:01 PM · drivers
adrian updated subscribers of D57440: aq(4): add a runtime dev.aq.N.debug trace control.
Wed, Jun 17, 8:01 PM · drivers
adrian accepted D57437: aq(4): enable jumbo frames, software LRO, and suspend/resume.
Wed, Jun 17, 8:00 PM · drivers
adrian added a reviewer for D57436: aq(4): RX/TX and HW-path correctness and hardening: drivers.
Wed, Jun 17, 8:00 PM · drivers
adrian added a reviewer for D57434: aq(4): interrupt model and queue-count correctness: drivers.
Wed, Jun 17, 7:59 PM · drivers
adrian added a comment to D57434: aq(4): interrupt model and queue-count correctness.

I think its fine to get it up and going, but in theory being able to transmit on all of the rings shouldn't stall traffic. If it is then chances are your RX thread is keeping your TX queue moving forward.

Wed, Jun 17, 7:58 PM · drivers
adrian accepted D57620: libusb: Update libusb_class_code.

please include a reference in the commit message to where these are defined (eg if they're in a spec or just local to freebsd)

Wed, Jun 17, 7:55 PM
adrian added a comment to D24339: Aux uart gets wrong clock speed on RPi4.

let's figure this out

Wed, Jun 17, 7:44 PM
adrian added a comment to D50958: libusb: implement IAD parser.

hi! this doesn't have a commit message in the description; would you please update that? thanks!

Wed, Jun 17, 3:17 PM
adrian committed rG85814f591261: est: gate "not recognized" message behind bootverbose (authored by guest-seuros).
est: gate "not recognized" message behind bootverbose
Wed, Jun 17, 2:52 PM
adrian committed rG021a190c88fc: est: prevent divide-by-zero in est_msr_info (authored by guest-seuros).
est: prevent divide-by-zero in est_msr_info
Wed, Jun 17, 2:51 PM
adrian closed D57616: est: gate "not recognized" message behind bootverbose.
Wed, Jun 17, 2:51 PM · drivers
adrian closed D57614: est: prevent divide-by-zero in est_msr_info.
Wed, Jun 17, 2:51 PM · drivers
adrian accepted D57614: est: prevent divide-by-zero in est_msr_info.

I can't find where this is documented - all of the SDMs I've looked at so far describe IA32_PERF_STATUS but do not cover the format of the register above bit 31.

Wed, Jun 17, 2:49 PM · drivers
adrian committed rGf981fa12b760: mtw: Fix firmware loading and memory leaks (authored by guest-seuros).
mtw: Fix firmware loading and memory leaks
Wed, Jun 17, 2:40 PM
adrian closed D57597: mtw: Fix firmware loading and memory leaks.
Wed, Jun 17, 2:39 PM · drivers, wireless
adrian accepted D57616: est: gate "not recognized" message behind bootverbose.
Wed, Jun 17, 2:33 PM · drivers
adrian accepted D57597: mtw: Fix firmware loading and memory leaks.
Wed, Jun 17, 2:30 PM · drivers, wireless
adrian added a comment to D57614: est: prevent divide-by-zero in est_msr_info.

get rid of the bootverbose change and putit in a different diff, and then i'll approve/land

Wed, Jun 17, 3:58 AM · drivers
adrian added a project to D57615: firewire: extract shared helpers from fwe and fwip: firewire.
Wed, Jun 17, 2:59 AM · firewire
adrian added a comment to D57597: mtw: Fix firmware loading and memory leaks.

interesting, is there no way to force a firmware reload without just power cycling the device?
eg if i wanted to test two different firmware images by unloading and reloading the driver?

Wed, Jun 17, 1:41 AM · drivers, wireless
adrian added a project to D57597: mtw: Fix firmware loading and memory leaks: drivers.
Wed, Jun 17, 1:40 AM · drivers, wireless
adrian added a project to D57614: est: prevent divide-by-zero in est_msr_info: drivers.

oh interesting, what did you observe this on?

Wed, Jun 17, 12:54 AM · drivers

Tue, Jun 16

adrian accepted D56994: nvme: Use newbus to ask if a device is storage.
Tue, Jun 16, 7:50 PM · drivers
adrian added inline comments to D56835: rcd(8): new service manager daemon.
Tue, Jun 16, 5:21 PM
adrian closed D36469: wtap(4): implement monitor mode and handle radiotap.
Tue, Jun 16, 3:01 PM · wireless
adrian added a comment to D36469: wtap(4): implement monitor mode and handle radiotap.

landed, i fixed it locally

Tue, Jun 16, 3:01 PM · wireless
adrian committed rG93c6906e36a4: wtap(4): implement monitor mode and handle radiotap (authored by enweiwu).
wtap(4): implement monitor mode and handle radiotap
Tue, Jun 16, 2:59 PM
adrian committed rGd4de0a69a92e: wtap(4): Implement STA/HostAP mode and support WPA/WPA2 (authored by enweiwu).
wtap(4): Implement STA/HostAP mode and support WPA/WPA2
Tue, Jun 16, 2:59 PM
adrian committed rG9ef75e05ba91: wtap: Remove bogus NULL check in wtap_transmit (authored by enweiwu).
wtap: Remove bogus NULL check in wtap_transmit
Tue, Jun 16, 2:59 PM
adrian closed D36243: wtap(4): Implement STA/HostAP mode and support WPA/WPA2.
Tue, Jun 16, 2:58 PM · wireless
adrian closed D54547: wtap: Remove bogus NULL check in wtap_transmit.
Tue, Jun 16, 2:58 PM · wireless
adrian added a comment to D57388: powerpc64le: switch long double to IEEE binary128.

Bounce that to -ppc mailing list too. Justin would likely know better for the non-POWER chips.

Tue, Jun 16, 1:49 PM
adrian accepted D57388: powerpc64le: switch long double to IEEE binary128.
Tue, Jun 16, 1:27 PM
adrian committed rG76f9bb488e77: rge: fix VLAN hardware tagging (authored by john.darrah09_gmail.com).
rge: fix VLAN hardware tagging
Tue, Jun 16, 1:12 PM
adrian added a reviewer for D45909: wpa: add MFP configuration if requested: wireless.
Tue, Jun 16, 5:02 AM · wireless
adrian added a reviewer for D46498: ifconfig: add IEEE80211_NODE_MFP flag printing.: wireless.
Tue, Jun 16, 5:02 AM · wireless
adrian added a reviewer for D57556: net80211: add node to the crypto encap/decap functions: wireless.
Tue, Jun 16, 5:01 AM · wireless
adrian added a reviewer for D57551: net80211: add IGTK key slots needed for later MFP support: wireless.
Tue, Jun 16, 5:01 AM · wireless
adrian updated the diff for D57551: net80211: add IGTK key slots needed for later MFP support.

update!

Tue, Jun 16, 4:51 AM · wireless

Mon, Jun 15

adrian added a project to D57597: mtw: Fix firmware loading and memory leaks: wireless.
Mon, Jun 15, 2:38 PM · drivers, wireless
adrian accepted D42282: mwl: Change the return value of malloc() on failure to ENOMEM.
Mon, Jun 15, 1:00 AM

Sun, Jun 14

adrian committed rG9f90536c74b8: apple_bce/vhci: add T2 virtual USB host controller (authored by guest-seuros).
apple_bce/vhci: add T2 virtual USB host controller
Sun, Jun 14, 8:58 PM