(post commit) maybe its worth adding function documentation explaining what its supposed to be doing and returning?

I think having it nailed up the way it is for now is a good first step. Ideally we'd have the bridge "state" for something like dhcp be based on the link state of a subset of children interfaces - and if none exist, it does what you're doing.

neat! how do I build/install this to test this in pseries VMs?

I've pushed D56103; please rebase this on top of -HEAD as of today and please address limiting the rx moderation value appropriately (just do it when you program; don't bother going through creating a SYSCTL_PROC hook to validate it on read/write..)

neat! why's the kernel ET_DYN on ppc anyway?

ah it's already there. yay!

Looks good; do we have a manpage with the other OF_ methods?

can you add some validation of the parameter before programming it into the register? surely it's not a single 32 bit field?

looks good; ASPM is a common breaking point.

good catch! would you mind adding a note in the code about this so it's not accidentally removed in the future when someone tinkers with compat stuff?

oh oops! ok sorry yes please test it. i missed that!

wait ignore me. There already IS stuff in sys/dev/intel/

oh one final comment - please put the code in sys/dev/intelpmc/, matching sys/modules/intelpmc/ .

I'm going to land this today unless someone has any last minute objections!

nice work!

address copyright/dates

update to include fixes to build on both 32 and 64 bit platforms

rebase/update

rename ixgbe_mdio -> if_ix_mdio_hw

Thanks! Lemme test it locally and then i'll pull it into -head.

hi! i'm trying to put as much hardware specific code into if_rge_hw.c to hopefully make it easier to keep whole hardware-specific routines in sync with openbsd.

looks like this diff got the flags stuff and shuffling around where the 'struct bus_dma_tag' is defined.
I'll go clean that up shortly.

swizzle when it's done to explicitly do it for mdio/management;
add comments in the code.

Update to latest -HEAD; make it default to off w/out a hint

at the surface this looks all just fine. I trust that if you've tested it a bunch and new installs are ok, I think we're ok.

@kevlo would you mind taking a look at this? What do y'all do in openbsd for SFP+ support?

this is good work! i would like to figure out how to describe the "why" this extra stuff is necessary though, so lemme noodle on that a bit first.

Ok, i'm now actively looking at this.

Lemme see which I can delete and which I need to keep and use.

It's in here just in case i need it when figuring out WOL. I'd much prefer we figure out WOL :P

nice catch!