♟ adrian

ok, I'd like to land this and then follow it up with some more iwx cleanups. Thanks for pointing them out though, I'm not shocked that the original upstream code was messy with key management too. ;-)

net80211: document some of the crypto/key functions

iwx: rewrite iwx_rs_update() to be VHT aware, refactor it a bit

iwx: don't log VHT rate lookups in iwx_tx_fill_cmd() for data frames

iwx: add some missed beacon debugging

iwx: add some lock assertions in the TX start path

ath: fix ath_buf leak if ath_tx_tag_crypto() returns an error

In D9157#1203017, @lwhsu wrote:

Not sure if this patch is still making sense, but maybe some parts are still worth to be picked up.

yup, and it also makes churning on libpmc development easier (if I ever do that again :-) )

iwm: assign sequence numbers even if we ask the firmware to override

iwx: re-add sequence numbers for non-AMPDU, preserving previous behaviour

[iwx] tell net80211 not to originate NULL data frames

[iwn] Don't originate NULL data frames in net80211

[rtwn] don't send NULL data frames if we're compiled with firmware enabled

usb: update wifi drivers to use IEEE80211_FEXT_SEQNO_OFFLOAD

net80211: convert the rest of the native net80211 drivers to SEQNO_OFFLOAD

In D52299#1194452, @bz wrote:

Based on your description it sounds more like you want to disable PS in net80211 and leave it to iwn?

In D52492#1199444, @bz wrote:

@adrian any concerns? The only concern I have is that with bgscans we might see a log entry every 5(?) minutes?

So, the DSPARAMS one is in ieee80211_parse_beacon(), look for IEEE80211_ELEMID_FHPARAMS and IEEE80211_ELEMID_DSPARAMS .

net80211: add support for drivers to disable sending NULL data frames

rsu: implement A-MPDU TX; add TODO items for further work

rsu: enable seqno offload

run: enable seqno offload

In D50747#1188607, @bz wrote:

On 2nd though, nothing guards against ieee80211_output_seqno_assign() being called twice. Can we be sure net80211 in no case has a seq# assigned to wh? Or should ieee80211_output_seqno_assign() assert that if tid_arg is -1 that tid from from the frame is 0?

I just leave this comment here; it came to my mind based on the next review; I also think we should carefully define what IEEE80211_FEXT_SEQNO_OFFLOAD means with a comment in net80211 as it does not necessarily mean hardware offload like others but could also mean driver offload?

[net80211] Quieten the logging from ieee80211_vht_get_vhtflags()

ok, reduced to one line diff, please re-review! thanks!

Abandoning, but it landed!

landed in rGdff11c4f8007

rtwn: enable seqno offload; migrate to use ieee80211_output_seqno_assign()

Yeah I was /just/ thinking about squishing them together into one commit.

I've tested these with the suggested changes / questions and it works fine, so I'll clean up the diffs tonight and land em. Thanks bz!

remove the % operator in the driver now that the net80211 macros do it for us

[net80211] clean up M_SEQNO_SET and M_SEQNO_GET() to always limit to the…

In D52300#1194454, @bz wrote:

If you say so; wonder what iwx tells firmware about SMPS?

I cleaned up the seqno assignment stuff in D52301 and D52302. In particular after D52302, we can sweep the drivers and remove the "% IEEE80211_SEQ_RANGE" because, well, it's now done in the macro.

adrian (Adrian Chadd)
User

Projects

User Details

Recent Activity
View All

Today

Yesterday

Wed, Oct 8

Mon, Oct 6

Sat, Oct 4

Wed, Oct 1

Sun, Sep 28

Wed, Sep 24

Mon, Sep 22

Sun, Sep 21

Sat, Sep 20

Tue, Sep 16

Mon, Sep 15

Sun, Sep 14

Sep 11 2025

Sep 9 2025

Sep 8 2025

Sep 7 2025

Sep 6 2025

Sep 5 2025

Sep 3 2025

Sep 2 2025

Sep 1 2025

Aug 31 2025

adrian (Adrian Chadd)User