Looks good now!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 13 2022
Looks good to me now. I'm approving this one and https://reviews.freebsd.org/D36769. Thanks!
Nov 12 2022
Looks good as a first introduction to vale. A few fixes and then you can commit it to the FDP primer.
I like these additions, thanks!
A few fixes provided in the comments.
Oct 29 2022
The term "Committer" was used way before SVN times.
Oct 28 2022
Found a line break after a sentence stop. You can run textproc/igor over your man page to find these.
Also, "mandoc -T lint" may also be helpful.
Very minor issue with the core-email in one place.
Thanks for working on this!
Oct 27 2022
Found a typo. You can fix it when committing. Thanks for this work!
Oct 23 2022
Oct 18 2022
Who's going to commit this?
Oct 13 2022
I would love to see this in the man page. Any updates?
Will someone commit this? It's been approved for a while...
Any updates on this one?
I like this initiative. It does make the page much better than before and with the update script, we'll keep it up-to-date.
I'd say we commit the base bits now and refine it in a follow-up commit (i.e. when the script is running with help from Sergio).
Any updates on this (from either side)?
Any updates on this one?
OK from manpages.
Oct 12 2022
Oct 11 2022
Looks good. Would be amazing if this would be updated automatically by a script of some kind.
Oct 8 2022
Oct 7 2022
OK from manpages.
Overcome by events, someone else removed the section by now.
Manpage looks good, we can do the filename markup in a followup commit.
The changes were already committed to the porters-handbook. You can close this review.
Thanks for submitting it anyway.
Manpage looks good. Thanks!
Confirm man page looks good.
OK from manpages.
OK for the man page change.
@ota_j.email.ne.jp: Can you update the rest so we can get this committed. Arigato!
Man page also looks good now.
Man page looks good, thanks!
Oct 6 2022
Oct 5 2022
Oct 1 2022
Any updates on this one? The suggested changes don't seem too difficult to me.
@ota_j.email.ne.jp are you interested in finishing this?
Looks good, can you commit this?
Can we get this committed? Seems mostly complete to me.
Any updates on this?
Explicitly approve the man page change.
@imp: Can you take care of the commit? I associate nvmecontrol mainly with you and you have a src bit to do the commit. Thank you!
Sep 30 2022
Approving the man page part.
Hope we can get it committed soon.
OK from manpages.
Would be good to see some progress on this.
Who's going to commit this? Seems like it's as complete as it can get.
Can we move this along or do we still have to discuss something about it?
Sep 29 2022
Both man pages look good now. Thank you!
Sep 28 2022
Thanks for the man page and the huge work implementing netlink!
Can hyou run "mandoc -Tlint" over it? There are at least a couple of instances where there must be a line break inserted after a sentence stop.
I started commenting some occurances, but rather than doing all of them, it's probably easier to go via the mandoc output.
Sep 26 2022
Sep 23 2022
Man page looks good now. Thanks, looks very interesting.
A few minor comments. The rest looks good.
Sep 8 2022
In D36407#828577, @obiwac_gmail.com wrote:I have not, I didn't know about that, thanks for pointing me to it! I'll fix that in a bit. May I fix all the "STYLE: useless macro: Tn" errors or do I ignore those?
Sep 7 2022
Small typo, the rest looks good to me for the man page.
One more comment about the manpage. Did you run "mandoc -Tlint" over it?
Aug 12 2022
OK from manpages.
Aug 4 2022
I'm OK with this new version to be committed.
Jul 20 2022
Jul 19 2022
That looks even better with your additions.
The man page part looks fine now. Let's wait for feedback from the transport group in case we need to adjust the wording.
Big change, but good to have. I've added a few bits of my own, mostly minor fixes.
Excellent, go for it!
Sorry, I just saw this. Thanks for the aditions and explanations to the man page, I think this will help a lot of people understanding these options.
I've found only a few minor nits, the rest looks good to me.
Jul 8 2022
Jul 4 2022
Can you add a "relnotes: yes" line to the commit message? Thanks!
Jul 1 2022
Jun 19 2022
It's a good start, thanks.
I added few language corrections and simplifications.
Jun 5 2022
Apr 19 2022
In D32436#791966, @pauamma_gundo.com wrote:In D32436#791757, @bcr wrote:Any update on this?
Are you and I waiting for each other to do something, or are you asking someone else?
Apr 15 2022
Any update on this? Would love to show the world that FreeBSD supports Wayland to the degree that is described here.
We can then add stuff later once we already have a basic handbook chapter.
Feb 13 2022
Feb 1 2022
OK for the manpages part of the change.
Jan 31 2022
Typo in man page.
Jan 29 2022
Jan 17 2022
Looks good, thanks for the update.
Dec 9 2021
Same here, can't find any grammar or other nits.
Dec 5 2021
Small suggestion, I know that it is still a draft. But good to eventually have such a man page!
Dec 2 2021
Sounds good to have in there as these old misconceptions are still around. Approved from my side.
Nov 14 2021
Alright, I incorporated these last feedback items. I'm going to commit this shortly.
Thanks to all reviewers, your feedback and suggestions helped a lot in improving the text!
Nov 4 2021
Looks like a reasonable change to me, having these shared over more languages.