Page MenuHomeFreeBSD
Feed Advanced Search

Nov 13 2022

bcr accepted D36769: Add documentation of pkg-{pre,post}-[de]install[.lua].

Looks good now!

Nov 13 2022, 9:19 AM
bcr accepted D36770: Copyedit zirias' pre*/post* update..

Looks good to me now. I'm approving this one and https://reviews.freebsd.org/D36769. Thanks!

Nov 13 2022, 9:19 AM

Nov 12 2022

bcr added a comment to D37362: vale integration with editors.

Looks good as a first introduction to vale. A few fixes and then you can commit it to the FDP primer.

Nov 12 2022, 6:20 PM
bcr added a comment to D36769: Add documentation of pkg-{pre,post}-[de]install[.lua].

I like these additions, thanks!
A few fixes provided in the comments.

Nov 12 2022, 2:28 PM

Oct 29 2022

bcr added a comment to D37207: Fixing the definition of the term "committer".

The term "Committer" was used way before SVN times.

Oct 29 2022, 4:47 PM · docs

Oct 28 2022

bcr added a comment to D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.

Found a line break after a sentence stop. You can run textproc/igor over your man page to find these.
Also, "mandoc -T lint" may also be helpful.

Oct 28 2022, 6:46 AM
bcr added a comment to D29543: license: Create a license guideline document.

Very minor issue with the core-email in one place.
Thanks for working on this!

Oct 28 2022, 6:14 AM

Oct 27 2022

bcr added a comment to D37135: hier(7): remove text describing /usr/src layout.

Found a typo. You can fix it when committing. Thanks for this work!

Oct 27 2022, 7:00 AM

Oct 23 2022

bcr requested review of D37096: Add missing resolv.conf(5) options documentation .
Oct 23 2022, 10:23 AM

Oct 18 2022

bcr added a comment to D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.

Who's going to commit this?

Oct 18 2022, 8:30 AM

Oct 13 2022

bcr added a comment to D33233: sync.8: Document that the "sync dance" is not a thing.

I would love to see this in the man page. Any updates?

Oct 13 2022, 6:30 PM
bcr added a comment to D26552: Revert DTS for omap family for stable/12 and releng 12.2.

Will someone commit this? It's been approved for a while...

Oct 13 2022, 6:25 PM · ARM
bcr added a comment to D32979: ps(1): let J flag list all jailed processes.

Any updates on this one?

Oct 13 2022, 4:44 PM
bcr accepted D36972: books: Updating ports count statistics in dev-model.

I like this initiative. It does make the page much better than before and with the update script, we'll keep it up-to-date.
I'd say we commit the base bits now and refine it in a follow-up commit (i.e. when the script is running with help from Sergio).

Oct 13 2022, 4:42 PM · docs
bcr added a comment to D18832: NTB Perf: Tool to measure performance of NTB hw drivers.

Any updates on this (from either side)?

Oct 13 2022, 4:37 PM
bcr added a comment to D32985: New manual page for vmrun.sh.

Any updates on this one?

Oct 13 2022, 4:34 PM · bhyve
bcr accepted D35401: pmcannotate: Add a '-m' mode option to control per-line annotations..

OK from manpages.

Oct 13 2022, 4:32 PM

Oct 12 2022

bcr accepted D36407: ls: `-v` flag.

Manpage looks good now. Thank you!

Oct 12 2022, 4:00 PM

Oct 11 2022

bcr accepted D36931: Update committer numbers.

Looks good. Would be amazing if this would be updated automatically by a script of some kind.

Oct 11 2022, 1:30 PM

Oct 8 2022

bcr added a reverting change for rG1c2be25f6080: Add extra EINVAL information about wrong block size to read(2)/write(2): rG44b0b943b8f3: Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)".
Oct 8 2022, 10:29 AM
bcr added a reverting change for D24617: Add additional EINVAL information about wrong block size to read(2)/write(2): rG44b0b943b8f3: Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)".
Oct 8 2022, 10:29 AM
bcr committed rG44b0b943b8f3: Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)" (authored by bcr).
Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)"
Oct 8 2022, 10:28 AM

Oct 7 2022

bcr accepted D30351: ptrace: add an option to not kill debuggees on debugger exit.

OK from manpages.

Oct 7 2022, 6:11 PM
bcr committed R9:94f8098e1999: Remove whitespaces at end of line (authored by bcr).
Remove whitespaces at end of line
Oct 7 2022, 5:27 PM
bcr committed R9:a4c01d577a7e: Typo fix: stictly -> strictly (authored by bcr).
Typo fix: stictly -> strictly
Oct 7 2022, 4:37 PM
bcr committed R9:5acdd01ea951: Fix a typo: thouroughly -> thoroughly (authored by bcr).
Fix a typo: thouroughly -> thoroughly
Oct 7 2022, 4:32 PM
bcr abandoned D19954: Remove reference to nonexistent npfctl from blacklistd man page.

Overcome by events, someone else removed the section by now.

Oct 7 2022, 2:22 PM
bcr accepted D28450: lualoader: add support for .lua configuration files.

Manpage looks good, we can do the filename markup in a followup commit.

Oct 7 2022, 2:19 PM
bcr added a comment to D32556: Add __FreeBSD_versions 1400037 and 1400038 to handbook.

The changes were already committed to the porters-handbook. You can close this review.
Thanks for submitting it anyway.

Oct 7 2022, 2:10 PM
bcr accepted D33477: ithread(9): update top-level description.

OK from manpages.

Oct 7 2022, 2:05 PM
bcr accepted D34502: libmd: export and document *Fd/*FdChunk interfaces.

Manpage looks good. Thanks!

Oct 7 2022, 2:02 PM
bcr accepted D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.

Confirm man page looks good.

Oct 7 2022, 1:53 PM
bcr accepted D35980: Add support for _CR3 critical standby (S3) threshold..

OK from manpages.

Oct 7 2022, 1:49 PM
bcr accepted D34308: Add sysctl hw.acpi and hw.acpi.acline descriptions.

OK for the man page change.
@ota_j.email.ne.jp: Can you update the rest so we can get this committed. Arigato!

Oct 7 2022, 1:46 PM
bcr committed rG1c2be25f6080: Add extra EINVAL information about wrong block size to read(2)/write(2) (authored by bcr).
Add extra EINVAL information about wrong block size to read(2)/write(2)
Oct 7 2022, 11:40 AM
bcr closed D24617: Add additional EINVAL information about wrong block size to read(2)/write(2).
Oct 7 2022, 11:39 AM
bcr committed R9:3c9d9ad5416d: Typo fix (authored by bcr).
Typo fix
Oct 7 2022, 10:46 AM
bcr committed R9:b0fd71122c01: Belatedly add the Aberdeen Hackathon in the 57 North Hacklab. (authored by bcr).
Belatedly add the Aberdeen Hackathon in the 57 North Hacklab.
Oct 7 2022, 10:03 AM
bcr accepted D32957: nvmecontrol: improve namespace size unit of devlist command output.

Man page also looks good now.

Oct 7 2022, 9:20 AM
bcr accepted D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.

Man page looks good, thanks!

Oct 7 2022, 9:18 AM

Oct 6 2022

bcr committed rG84e86788705c: nvmecontrol: Add Samsung Extended SMART Information logpage support (authored by wanpengqian_gmail.com).
nvmecontrol: Add Samsung Extended SMART Information logpage support
Oct 6 2022, 10:38 AM
bcr closed D33749: nvmecontrol: Add Samsung Extended SMART Information logpage support..
Oct 6 2022, 10:37 AM

Oct 5 2022

bcr closed D20577: Add information on how to load GEOM_MIRROR into the kernel at boot time and while the system is running to the SYNOPSIS section of gmirror.8 .
Oct 5 2022, 4:51 PM
bcr committed rGd63104d253e2: Add information on how to load gmirror on boot to auto activate mirrors (authored by bcr).
Add information on how to load gmirror on boot to auto activate mirrors
Oct 5 2022, 4:51 PM
bcr committed R9:3cceb0106c6c: Remove unnecessary line break in the sha256sum command example (authored by bcr).
Remove unnecessary line break in the sha256sum command example
Oct 5 2022, 3:19 PM
bcr committed R9:a21f100e426e: Remove whitespace at end of some lines. (authored by bcr).
Remove whitespace at end of some lines.
Oct 5 2022, 2:54 PM
bcr committed R9:b76576673c76: Fix checksum file names and verification instructions (authored by bcr).
Fix checksum file names and verification instructions
Oct 5 2022, 2:25 PM

Oct 1 2022

bcr added a comment to D22150: Update swapon.8 to discourage using ZFS as swap device/file..

Any updates on this one? The suggested changes don't seem too difficult to me.
@ota_j.email.ne.jp are you interested in finishing this?

Oct 1 2022, 9:06 AM
bcr accepted D27122: Stop symlinking vn.4 to md.4.

Looks good, can you commit this?

Oct 1 2022, 9:03 AM
bcr added a comment to D30004: Add sections to the handbook on cpu frequency control.

Can we get this committed? Seems mostly complete to me.

Oct 1 2022, 9:00 AM
bcr added a comment to D31315: lagg.4: note laggtype arg and reorder wireless example.

Any updates on this?

Oct 1 2022, 8:59 AM
bcr accepted D33749: nvmecontrol: Add Samsung Extended SMART Information logpage support..

Explicitly approve the man page change.
@imp: Can you take care of the commit? I associate nvmecontrol mainly with you and you have a src bit to do the commit. Thank you!

Oct 1 2022, 8:30 AM

Sep 30 2022

bcr accepted D31146: cron: Implement -s command option.

Approving the man page part.
Hope we can get it committed soon.

Sep 30 2022, 8:03 AM
bcr accepted D32128: Add support for sysctl.conf.d.

OK from manpages.
Would be good to see some progress on this.

Sep 30 2022, 8:00 AM · rc
bcr added a comment to D33749: nvmecontrol: Add Samsung Extended SMART Information logpage support..

Who's going to commit this? Seems like it's as complete as it can get.

Sep 30 2022, 7:57 AM
bcr added a comment to D35326: glabel.8: Warn against using generic labels on a shared device.

Can we move this along or do we still have to discuss something about it?

Sep 30 2022, 7:55 AM

Sep 29 2022

bcr accepted D36002: netlink: add netlink support.

Both man pages look good now. Thank you!

Sep 29 2022, 2:45 PM

Sep 28 2022

bcr added a comment to D36002: netlink: add netlink support.

Thanks for the man page and the huge work implementing netlink!
Can hyou run "mandoc -Tlint" over it? There are at least a couple of instances where there must be a line break inserted after a sentence stop.
I started commenting some occurances, but rather than doing all of them, it's probably easier to go via the mandoc output.

Sep 28 2022, 5:21 PM

Sep 26 2022

bcr accepted D36704: Update tip for adding a user to wheel:.

Looks good to me.

Sep 26 2022, 6:26 AM

Sep 23 2022

bcr accepted D36493: libc: Implement bsort(3) bitonic sorting algorithm..

Man page looks good now. Thanks, looks very interesting.

Sep 23 2022, 7:03 PM
bcr added a comment to D36681: FreeBSD Handbook: FreeBSD Boot Process: GNU GRUB.

A few minor comments. The rest looks good.

Sep 23 2022, 6:58 PM

Sep 8 2022

bcr added a comment to D36407: ls: `-v` flag.

I have not, I didn't know about that, thanks for pointing me to it! I'll fix that in a bit. May I fix all the "STYLE: useless macro: Tn" errors or do I ignore those?

Sep 8 2022, 9:13 AM

Sep 7 2022

bcr added a comment to D36481: bridge.4: describe new MTU behaviour.

Small typo, the rest looks good to me for the man page.

Sep 7 2022, 4:55 PM
bcr added a comment to D36407: ls: `-v` flag.

One more comment about the manpage. Did you run "mandoc -Tlint" over it?

Sep 7 2022, 9:46 AM

Aug 12 2022

bcr accepted D36147: bhyve: Support other schemes for naming pass-through devices..

OK from manpages.

Aug 12 2022, 8:03 AM

Aug 4 2022

bcr accepted D35521: fdp-primer: Add trademark section (draft).

I'm OK with this new version to be committed.

Aug 4 2022, 5:29 PM

Jul 20 2022

bcr accepted D35844: tcp.4: Sort sysctl variables.

I approve, yes.

Jul 20 2022, 12:54 PM

Jul 19 2022

bcr added a comment to D35844: tcp.4: Sort sysctl variables.

That looks even better with your additions.
The man page part looks fine now. Let's wait for feedback from the transport group in case we need to adjust the wording.

Jul 19 2022, 5:55 PM
bcr added a comment to D35844: tcp.4: Sort sysctl variables.

Big change, but good to have. I've added a few bits of my own, mostly minor fixes.

Jul 19 2022, 4:29 PM
bcr accepted D35843: icmp.4 inet.4 udp.4: sort sysctl variables.

Excellent, go for it!

Jul 19 2022, 4:02 PM
bcr added a comment to D35843: icmp.4 inet.4 udp.4: sort sysctl variables.

Sorry, I just saw this. Thanks for the aditions and explanations to the man page, I think this will help a lot of people understanding these options.
I've found only a few minor nits, the rest looks good to me.

Jul 19 2022, 11:46 AM

Jul 8 2022

bcr accepted D35758: Add -S option to veriexec.

OK for the manpage part.

Jul 8 2022, 6:55 PM

Jul 4 2022

bcr added a comment to D35694: Add ts(1) command.

Can you add a "relnotes: yes" line to the commit message? Thanks!

Jul 4 2022, 9:47 AM

Jul 1 2022

bcr accepted D35676: Catch up with 2004 and improve markup..

Looks good to me.

Jul 1 2022, 11:36 AM

Jun 19 2022

bcr added a comment to D35521: fdp-primer: Add trademark section (draft).

It's a good start, thanks.
I added few language corrections and simplifications.

Jun 19 2022, 8:38 AM

Jun 5 2022

bcr committed R9:92b4a9147a0a: Spell Google correctly. (authored by bcr).
Spell Google correctly.
Jun 5 2022, 7:30 PM

Apr 19 2022

bcr added a comment to D32436: Add section for Wayland in the x11 chapter.
In D32436#791757, @bcr wrote:

Any update on this?

Are you and I waiting for each other to do something, or are you asking someone else?

Apr 19 2022, 1:37 PM · desktop

Apr 15 2022

bcr added a comment to D32436: Add section for Wayland in the x11 chapter.

Any update on this? Would love to show the world that FreeBSD supports Wayland to the degree that is described here.
We can then add stuff later once we already have a basic handbook chapter.

Apr 15 2022, 6:29 PM · desktop

Feb 13 2022

bcr added inline comments to D34259: Report I/O stats from the CAM_IOSCHED_DYNAMIC extension.
Feb 13 2022, 12:28 PM

Feb 1 2022

bcr accepted D23230: Implement ECN++ (draft-generalized-ecn).

OK for the manpages part of the change.

Feb 1 2022, 2:55 PM

Jan 31 2022

bcr added a comment to D23230: Implement ECN++ (draft-generalized-ecn).

Typo in man page.

Jan 31 2022, 2:36 PM

Jan 29 2022

bcr committed R9:f267164260fc: Remove trailing whitespaces from lines in various chapters. (authored by bcr).
Remove trailing whitespaces from lines in various chapters.
Jan 29 2022, 2:27 PM
bcr committed R9:1f9b2d813030: Fix some typos in the Wine chapter and remove trailing whitespaces. (authored by bcr).
Fix some typos in the Wine chapter and remove trailing whitespaces.
Jan 29 2022, 2:22 PM
bcr committed R9:1ae23eb218c2: Spell 'availability' correctly. (authored by bcr).
Spell 'availability' correctly.
Jan 29 2022, 2:11 PM
bcr committed R9:4d19b8b2fa26: Typo fix: Adressses -> Addresses (authored by bcr).
Typo fix: Adressses -> Addresses
Jan 29 2022, 1:32 PM
bcr committed R9:1bf534723265: Remove extra whitespace characters from the end of a few lines. (authored by bcr).
Remove extra whitespace characters from the end of a few lines.
Jan 29 2022, 1:22 PM
bcr committed R9:3945abc7cee2: Divide up two words that should be separate. (authored by bcr).
Divide up two words that should be separate.
Jan 29 2022, 1:19 PM
bcr committed R9:63271dc2b94c: Remove trailing whitespace from the end of some lines. (authored by bcr).
Remove trailing whitespace from the end of some lines.
Jan 29 2022, 12:43 PM
bcr committed R9:64002069dd51: Typo fix: configuraton -> configuration (authored by bcr).
Typo fix: configuraton -> configuration
Jan 29 2022, 12:42 PM

Jan 17 2022

bcr accepted D33916: handbook: Fix local documentation instructions.

Looks good, thanks for the update.

Jan 17 2022, 10:38 AM

Dec 9 2021

bcr added a comment to D33360: Add genet.4 for RPi 4 Ethernet.

Same here, can't find any grammar or other nits.

Dec 9 2021, 4:48 PM

Dec 5 2021

bcr added a comment to D33275: Add a manual page for boottrace.

Small suggestion, I know that it is still a draft. But good to eventually have such a man page!

Dec 5 2021, 5:48 PM

Dec 2 2021

bcr accepted D33233: sync.8: Document that the "sync dance" is not a thing.

Sounds good to have in there as these old misconceptions are still around. Approved from my side.

Dec 2 2021, 12:15 PM

Nov 14 2021

bcr committed R9:c4708d675088: Fix build by reapplying 05b8bc3182dc4cfcf0a8a0964b4303903a4abf56 (authored by bcr).
Fix build by reapplying 05b8bc3182dc4cfcf0a8a0964b4303903a4abf56
Nov 14 2021, 3:01 PM
bcr closed D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
Nov 14 2021, 2:06 PM · ZFS
bcr committed R9:71f8b70ba8bc: Convert ZFS chapter to active voice and remove weasel/unnecessary words (authored by bcr).
Convert ZFS chapter to active voice and remove weasel/unnecessary words
Nov 14 2021, 2:06 PM
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Alright, I incorporated these last feedback items. I'm going to commit this shortly.
Thanks to all reviewers, your feedback and suggestions helped a lot in improving the text!

Nov 14 2021, 1:25 PM · ZFS

Nov 4 2021

bcr accepted D32830: Move articles/contributors/contrib-* to the shared directory.

Looks like a reasonable change to me, having these shared over more languages.

Nov 4 2021, 8:34 AM

Nov 3 2021

bcr accepted D32825: scsi.4: Document serial numbers.

Looks good to me.

Nov 3 2021, 5:22 PM
bcr accepted D32824: scsi.4: Remove untrue paragraph.

Checked up and good to go!

Nov 3 2021, 5:21 PM