Page MenuHomeFreeBSD

ota_j.email.ne.jp (Yoshihiro Ota)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 13 2017, 4:43 AM (96 w, 8 h)

Recent Activity

Sat, Sep 7

ota_j.email.ne.jp added a comment to D21530: Fix ggate.h typo..

Thanks.

Sat, Sep 7, 12:30 AM

Fri, Sep 6

ota_j.email.ne.jp added reviewers for D21530: Fix ggate.h typo.: pjd, delphij.
Fri, Sep 6, 4:06 AM

Thu, Sep 5

ota_j.email.ne.jp created D21531: Use zlib's uncompress function for simpler code..
Thu, Sep 5, 4:37 AM
ota_j.email.ne.jp created D21530: Fix ggate.h typo..
Thu, Sep 5, 4:25 AM

Tue, Aug 27

ota_j.email.ne.jp added a comment to D21388: Fix ggated/ggatec debug print of offsets..

Remove uninteded debug print.

Tue, Aug 27, 12:44 AM

Mon, Aug 26

ota_j.email.ne.jp added a comment to D21388: Fix ggated/ggatec debug print of offsets..

Also print length with PRIu32.

Mon, Aug 26, 11:00 PM

Sun, Aug 25

D21375: Remove zlib 1.0.4 from kernel. is now accepted and ready to land.
Sun, Aug 25, 2:07 PM
ota_j.email.ne.jp added inline comments to D21408: GZIO to update zlib version 1.0.4 to 1.2.11..
Sun, Aug 25, 3:02 AM
ota_j.email.ne.jp updated the test plan for D21408: GZIO to update zlib version 1.0.4 to 1.2.11..
Sun, Aug 25, 2:59 AM
ota_j.email.ne.jp added a comment to D21408: GZIO to update zlib version 1.0.4 to 1.2.11..

Include zutil.h instead of zlib.h in order to pick up OS_CODE and DEF_MEM_LEVEL.

Sun, Aug 25, 2:58 AM

Sat, Aug 24

ota_j.email.ne.jp added inline comments to D21375: Remove zlib 1.0.4 from kernel..
Sat, Aug 24, 10:47 PM
ota_j.email.ne.jp created D21408: GZIO to update zlib version 1.0.4 to 1.2.11..
Sat, Aug 24, 10:44 PM

Fri, Aug 23

ota_j.email.ne.jp added a reviewer for D21388: Fix ggated/ggatec debug print of offsets.: pjd.
Fri, Aug 23, 11:59 PM
ota_j.email.ne.jp created D21388: Fix ggated/ggatec debug print of offsets..
Fri, Aug 23, 11:57 PM
D21375: Remove zlib 1.0.4 from kernel. now requires changes to proceed.

We have a last item - sys/kern/subr_compressor.c includes sys/zutil.h.
I attempted and saw crc32() API conflict between gsb_crc32.h and zutil.h.
I haven't got a chance this week, though.

Fri, Aug 23, 11:51 PM

Thu, Aug 22

ota_j.email.ne.jp added a comment to D21186: Convert ng_deflate to use new zlib..

Thank you for explanations.
I found and had looked at that git repo while reviewing this change.
However, I didn't have enough guts to look into each of repo history to figure out which one came from where.
That explains why all of ppp use Z_PACKET_FLUSH while really NONE uses Z_SYNC_FLUSH.

Thu, Aug 22, 3:17 AM

Sun, Aug 18

ota_j.email.ne.jp added a comment to D21186: Convert ng_deflate to use new zlib..

The change looks reasonable based on PPP protocol and comparison to existing zlib code.

Sun, Aug 18, 10:08 PM
ota_j.email.ne.jp added inline comments to D21186: Convert ng_deflate to use new zlib..
Sun, Aug 18, 10:13 AM

Aug 17 2019

ota_j.email.ne.jp added a comment to D21186: Convert ng_deflate to use new zlib..

I will take a closer look.
I've never used nor looked into details of this API.
Please allow me a bit extra time for review.

Aug 17 2019, 1:36 AM

Aug 15 2019

ota_j.email.ne.jp added inline comments to D21191: Don't trim bsd_label.
Aug 15 2019, 5:34 AM
ota_j.email.ne.jp added inline comments to D20599: simple trimming before swapon.
Aug 15 2019, 5:19 AM

Aug 9 2019

ota_j.email.ne.jp added inline comments to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..
Aug 9 2019, 6:54 AM

Aug 8 2019

ota_j.email.ne.jp added a comment to D21186: Convert ng_deflate to use new zlib..

I haven't looked into FreeBSD extension of zlib yet to see if this change is safe.

Aug 8 2019, 10:23 PM
ota_j.email.ne.jp added a comment to D20675: Eliminate incorrect 2 pagesized block skipping while preparing swap device..

I wasn't aware of swap partition being the the first in a slice was the case. All of my swaps have been either one of whole device, whole slice or non-first partition, or NFS files. No wonder I never encountered any issues over years even with this change on my local tree.

Aug 8 2019, 10:17 PM

Aug 7 2019

ota_j.email.ne.jp created D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11.
Aug 7 2019, 4:45 AM
ota_j.email.ne.jp created D21175: bxe to update zlib version 1.0.4 to 1.2.11..
Aug 7 2019, 4:28 AM
ota_j.email.ne.jp added inline comments to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..
Aug 7 2019, 4:08 AM

Aug 6 2019

ota_j.email.ne.jp added a comment to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..

I found and have one more minor comment.

Aug 6 2019, 5:43 AM

Aug 5 2019

ota_j.email.ne.jp added inline comments to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..
Aug 5 2019, 10:55 PM

Aug 4 2019

ota_j.email.ne.jp retitled D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11. from Expose functions from compress.c and geom_uzip to update zlib version 1.0.4 to 1.2.11. to geom_uzip to update zlib version 1.0.4 to 1.2.11..
Aug 4 2019, 3:37 PM
ota_j.email.ne.jp added a comment to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..

I agree with the changes.

Aug 4 2019, 3:34 PM

Aug 3 2019

ota_j.email.ne.jp accepted D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
Aug 3 2019, 2:27 PM
ota_j.email.ne.jp retitled D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11. from geom_uzip to update zlib version 1.0.4 to 1.2.11. to Expose functions from compress.c and geom_uzip to update zlib version 1.0.4 to 1.2.11..
Aug 3 2019, 12:36 AM
ota_j.email.ne.jp added a comment to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..

Expose functions from compress.c with modified MY_ZCALLC handling.

Aug 3 2019, 12:18 AM

Aug 2 2019

ota_j.email.ne.jp added a comment to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..

Enhancce MY_ZCALLOC to expose functions in compress.c.
This also allows to use default zfree.

Aug 2 2019, 12:16 PM
ota_j.email.ne.jp updated the summary of D20272: if_mxge to update zlib version 1.0.4 to 1.2.11..
Aug 2 2019, 3:46 AM
Herald added a reviewer for D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11.: manpages.

Given we added -DZ_SOLO to zlib, pass zfree function explicitly.
Expose compressBound() function even with -DZ_SOLO.
compress2() doesn't work with -DZ_SOLO and not worth exposing as is.
Alternative is improve MY_ZCALLOC conditions along with Z_SOLO for compress2 to work as well.

Aug 2 2019, 2:35 AM
ota_j.email.ne.jp added inline comments to D20272: if_mxge to update zlib version 1.0.4 to 1.2.11..
Aug 2 2019, 2:28 AM
Herald added a reviewer for D20272: if_mxge to update zlib version 1.0.4 to 1.2.11.: manpages.

Given we added -DZ_SOLO to zlib, pass zfree function explicitly.

Aug 2 2019, 2:26 AM

Aug 1 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

I tested reads and writes on gzipped ZFS between 12.0-RELEASE and 13-CURRENT with this changes.
The test result was good.

Aug 1 2019, 5:09 AM

Jul 31 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

It looks ZFS changes, dropping zlib files in zfs, are melded into this one.
I recall needing to add -DGZIP and/or -DGUNZIP option for zfs compression=gzip to properly uncompress gzipped zfs devices with older version; there was gzip header regression...

Jul 31 2019, 11:07 PM
ota_j.email.ne.jp added inline comments to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..
Jul 31 2019, 10:38 PM

Jul 30 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

D21099 removed gzip'ed a.out support. Rebased and adjusted.

Jul 30 2019, 10:49 PM
ota_j.email.ne.jp added a comment to D21099: Remove gzip'ed a.out support..

Someone mentioned https://svnweb.freebsd.org/base?view=revision&revision=231885 was trigger in one of the mailing list. Anyway, if that's true, it's been broken for 7 years.

Jul 30 2019, 12:15 PM

Jul 29 2019

ota_j.email.ne.jp added a comment to D21099: Remove gzip'ed a.out support..

The changes look okay.

Jul 29 2019, 11:32 PM

Jul 28 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

D21072, "Remove support for kernel.tramp and kernel.tramp.gz", precedes this revision. This removes obsolete use of legacy zlib version.

Jul 28 2019, 8:20 PM

Jul 27 2019

ota_j.email.ne.jp added inline comments to D21072: Remove support for kernel.tramp and kernel.tramp.gz.
Jul 27 2019, 12:24 AM

Jul 15 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Actually, this file rename doesn't fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205822.
I don't think it is worth addressing this bug report here as removing the zlib in zfs also fixes this issue and we are aiming for this serious of changes.

Jul 15 2019, 4:30 AM

Jul 13 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Disable broken gzipped aout executable support and rename zlib in ZFS to avoid filename conflicts.

Jul 13 2019, 12:41 AM

Jul 11 2019

ota_j.email.ne.jp added a comment to D13484: swapoff to release multiple swap blocks at a time.

D20635 picked up the changes.

Jul 11 2019, 10:38 PM

Jul 9 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Adjusted sys/type.h include to FreeBSD section and also moved crypto_z* function implementations to top of file.

Jul 9 2019, 9:49 AM
ota_j.email.ne.jp added inline comments to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
Jul 9 2019, 9:44 AM

Jul 7 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Drop NO_GZIP compile option changes in zlib as these aren't necessary at this stage.

Jul 7 2019, 8:30 PM
ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

I had missed zcalloc.c in sys/modules/Makefile, too.

Jul 7 2019, 8:21 PM
ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Missed zcallc.h/c files from last update.

Jul 7 2019, 8:19 PM
ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Drop -DMY_ZCALLOC from kmod.mk but put zcfree() back.

Jul 7 2019, 8:17 PM

Jul 5 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Drop -DMY_ZCALLOC as no use under -DZ_SOLO.

Jul 5 2019, 10:50 PM
ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Use -DZ_SOLO to avoid standard C header files.
ZFS requires Non-Z_SOLO ZLIB and we will revisit when we work on ZFS.
Combined opencrypto conversion to avoid dtrace probe name changes.

Jul 5 2019, 10:56 AM
ota_j.email.ne.jp added inline comments to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
Jul 5 2019, 10:51 AM

Jul 3 2019

ota_j.email.ne.jp added a comment to D20635: release multiple swap blocks at a time in swp_pager_force_pagein.

I've been away and haven't been able to follow up or read updates on any of "swapoff" related changes for the last one week.
I won't be able to get back to this for another week; I will find the situations and figure out what to do later.
It is currently looking like Doug is finalizing changes based at quick look of incoming email titles. I appreciate your passion.

Jul 3 2019, 2:13 PM

Jun 27 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Added sys/contrib/zlib/crc32.c to zlib kernel module.

Jun 27 2019, 11:23 PM
ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Drop underscore from symbols - changed prefix from _zlib104 to zlib104.

Jun 27 2019, 1:33 PM

Jun 21 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Removed commented code in Makefiles.

Jun 21 2019, 1:57 AM

Jun 19 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

crc32 split has been comitted and code rebased.

Jun 19 2019, 1:51 PM
ota_j.email.ne.jp added a comment to D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

Xin committed this change with minor adjustments and https://svnweb.freebsd.org/base?view=revision&revision=349151 was the revision.

Jun 19 2019, 1:24 PM

Jun 18 2019

ota_j.email.ne.jp added reviewers for D20674: [libkvm] kvm_geswapinfo() to stop subtracting vm.dmmax size from swap device sizes.: emaste, linimon.
Jun 18 2019, 6:57 PM

Jun 17 2019

ota_j.email.ne.jp updated the summary of D20675: Eliminate incorrect 2 pagesized block skipping while preparing swap device..
Jun 17 2019, 7:27 PM
ota_j.email.ne.jp created D20675: Eliminate incorrect 2 pagesized block skipping while preparing swap device..
Jun 17 2019, 7:24 PM
ota_j.email.ne.jp updated the summary of D20674: [libkvm] kvm_geswapinfo() to stop subtracting vm.dmmax size from swap device sizes..
Jun 17 2019, 6:13 PM
ota_j.email.ne.jp updated the summary of D20674: [libkvm] kvm_geswapinfo() to stop subtracting vm.dmmax size from swap device sizes..
Jun 17 2019, 6:11 PM
ota_j.email.ne.jp created D20674: [libkvm] kvm_geswapinfo() to stop subtracting vm.dmmax size from swap device sizes..
Jun 17 2019, 6:07 PM

Jun 15 2019

ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Pick up Doug's patch for searcing multiple blocks and split code check-in mergess.

Jun 15 2019, 6:27 AM

Jun 14 2019

ota_j.email.ne.jp planned changes to D13484: swapoff to release multiple swap blocks at a time.

Doung, thank you for your very prompt responses. I looked into more after kib concerned locks and Alan's comment. I think they are right and this code has issues. Indeed, swp_pager_meta_ctl() calls are very expensive. I also experience few other issues and trying to figure out. For example, I use VMWare on Mac for this testing these days compare to when I used physical machines when I originally made this change; VMWare stalls at high memory utilization and heavy host I/O. I will be traveling shortly, too.

Jun 14 2019, 6:42 AM
ota_j.email.ne.jp added a comment to D20618: [archivers/nulib] PR 21519 - Use dirent.h instead of sys/dir.h.

https://svnweb.freebsd.org/ports?view=revision&revision=504002 removed from the port tree per https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=21519#c15

Jun 14 2019, 6:12 AM

Jun 12 2019

ota_j.email.ne.jp created D20621: PR 21519 - Use dirent.h instead of sys/dir.h.
Jun 12 2019, 11:59 AM
ota_j.email.ne.jp added reviewers for D20618: [archivers/nulib] PR 21519 - Use dirent.h instead of sys/dir.h: delphij, emaste.
Jun 12 2019, 3:37 AM
ota_j.email.ne.jp created D20618: [archivers/nulib] PR 21519 - Use dirent.h instead of sys/dir.h.
Jun 12 2019, 1:17 AM

Jun 7 2019

ota_j.email.ne.jp updated the diff for D20545: Break down swap_pager_swapoff function into small functions..

Move vm_object_pip_wakeup() and vm_pager_page_unswapped() back to swp_pager_force_pagein().

Jun 7 2019, 5:21 AM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Change -= SWAP_META_PAGES to %= SWAP_META_PAGES.

Jun 7 2019, 1:22 AM
ota_j.email.ne.jp created D20545: Break down swap_pager_swapoff function into small functions..
Jun 7 2019, 1:08 AM

Jun 6 2019

ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Revert back some changes.

Jun 6 2019, 4:41 AM
ota_j.email.ne.jp added a comment to D13484: swapoff to release multiple swap blocks at a time.

I don't think swp_pager_find_continuous() was a good idea/implementation. I will revert it shortly.

Jun 6 2019, 3:01 AM

Jun 5 2019

ota_j.email.ne.jp added a comment to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..

Thank you for taking a look.

Jun 5 2019, 5:28 AM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Created swp_pager_find_continuous instead of calling swap_pager_haspage().

Jun 5 2019, 3:24 AM

Jun 4 2019

ota_j.email.ne.jp planned changes to D13484: swapoff to release multiple swap blocks at a time.

Doug, thank you for elaboration.
Let's see how that approach works this time.
When I started and tried, it wasn't as easy and I decided to take advantages of existing functions.

Jun 4 2019, 10:29 PM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Resolve conflicts, fix style, and break a function.

Jun 4 2019, 10:22 PM

Jun 1 2019

ota_j.email.ne.jp added inline comments to D13484: swapoff to release multiple swap blocks at a time.
Jun 1 2019, 10:48 PM

May 31 2019

ota_j.email.ne.jp added a comment to D20479: Delete sys/dir.h which was deprecated since 1997..

Exp-run info: https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-exp-run
For example https://bugs.freebsd.org/214864 is the exp-run I requested for lld.
I agree that there shouldn't be any ports using sys/dir.h still but it is still good to confirm that prior to the commit. (Here it's almost certainly been long enough that it's not necessary, but is a best practice.)
I'll ask in the #bsdports channel if anyone there thinks it's necessary.

May 31 2019, 3:55 AM
ota_j.email.ne.jp added a comment to D13484: swapoff to release multiple swap blocks at a time.

I updated test case section with performance measurement.

May 31 2019, 2:38 AM
ota_j.email.ne.jp added a comment to D20479: Delete sys/dir.h which was deprecated since 1997..

What do you mean by "an exp-run?" I had made buildworld and buildkernel successful on i386. Universe will be better but I don't have enough disk space.

May 31 2019, 2:13 AM
ota_j.email.ne.jp updated the summary of D20479: Delete sys/dir.h which was deprecated since 1997..
May 31 2019, 12:44 AM
ota_j.email.ne.jp created D20479: Delete sys/dir.h which was deprecated since 1997..
May 31 2019, 12:43 AM

May 30 2019

ota_j.email.ne.jp updated the test plan for D13484: swapoff to release multiple swap blocks at a time.
May 30 2019, 3:27 AM

May 29 2019

ota_j.email.ne.jp updated the diff for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

Fix KERN to GSB.

May 29 2019, 1:05 AM
ota_j.email.ne.jp retitled D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c from Relocate crc32 functions from libkern.h to crc32.h and rename crc32.c to kern_crc32.c to Relocate crc32 functions from libkern.h to gsb_crc32.h/c.
May 29 2019, 12:47 AM
ota_j.email.ne.jp updated the diff for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

After research, I found that our crc32 functions are based on the code written
by Gary S Brown. We also have many other *crc32.[hc] files, too. Rather than,
prefixing with kern, prefix with his initial to honor his work.
It looks kern prefix is used for sub-systems.

May 29 2019, 12:34 AM

May 25 2019

ota_j.email.ne.jp added inline comments to D13484: swapoff to release multiple swap blocks at a time.
May 25 2019, 9:46 PM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Fix style.

May 25 2019, 6:37 PM
ota_j.email.ne.jp added inline comments to D13484: swapoff to release multiple swap blocks at a time.
May 25 2019, 2:10 PM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

KASSERT rearragements.

May 25 2019, 2:06 PM