Page MenuHomeFreeBSD

ota_j.email.ne.jp (Yoshihiro Ota)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 13 2017, 4:43 AM (255 w, 2 d)

Recent Activity

Yesterday

ota_j.email.ne.jp added a comment to D22150: Update swapon.8 to discourage using ZFS as swap device/file..

Thanks for revising.

Tue, Oct 4, 2:31 AM

Mon, Oct 3

ota_j.email.ne.jp updated the diff for D22150: Update swapon.8 to discourage using ZFS as swap device/file..

I've completely forgotten this changeset.

Mon, Oct 3, 2:56 AM

Mar 6 2022

ota_j.email.ne.jp added inline comments to D34308: Add sysctl hw.acpi and hw.acpi.acline descriptions.
Mar 6 2022, 3:25 PM
ota_j.email.ne.jp updated the diff for D34308: Add sysctl hw.acpi and hw.acpi.acline descriptions.
  • Management to Interface
Mar 6 2022, 5:15 AM

Mar 1 2022

ota_j.email.ne.jp retitled D34308: Add sysctl hw.acpi and hw.acpi.acline descriptions from Add hw.acpi and hw.acpi.acline descriptions to Add sysctl hw.acpi and hw.acpi.acline descriptions.
Mar 1 2022, 4:59 AM

Feb 17 2022

ota_j.email.ne.jp requested review of D34308: Add sysctl hw.acpi and hw.acpi.acline descriptions.
Feb 17 2022, 3:18 AM

Feb 11 2022

ota_j.email.ne.jp updated the diff for D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
  • sysctl -l to display the lenth of returned data.
Feb 11 2022, 4:33 AM

Feb 6 2022

ota_j.email.ne.jp added inline comments to D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
Feb 6 2022, 3:54 AM
ota_j.email.ne.jp updated the diff for D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
  • Bump the date, use "struct" as referenced in other parts of man sysctl, and give few examples of struct types.
Feb 6 2022, 3:52 AM
ota_j.email.ne.jp added a comment to D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.

Have you run mandoc -Tlint and igor on the manual page?

At the very least, the latter would hint that you need to bump .Dd :)

Feb 6 2022, 3:46 AM
ota_j.email.ne.jp updated the diff for D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
  • Bump the date, use "struct" as referenced in other parts of man sysctl, and give few examples of struct types.
Feb 6 2022, 3:34 AM

Feb 3 2022

ota_j.email.ne.jp updated the diff for D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
  • Updated man page.
Feb 3 2022, 12:50 AM

Jan 31 2022

ota_j.email.ne.jp retitled D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases from sysctl: Refactor for a function to display info options for and added test cases to sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
Jan 31 2022, 10:59 PM
ota_j.email.ne.jp updated the diff for D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
  • systat: Added -F option to show "fmt"
Jan 31 2022, 3:59 AM

Jan 24 2022

ota_j.email.ne.jp updated the diff for D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
  • Update error description of show_info()
Jan 24 2022, 11:17 PM
ota_j.email.ne.jp updated the diff for D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
  • Return error code from show_info()
Jan 24 2022, 11:08 PM
ota_j.email.ne.jp added inline comments to D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
Jan 24 2022, 10:56 PM

Jan 23 2022

ota_j.email.ne.jp added a reviewer for D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases: markj.
Jan 23 2022, 9:53 PM
ota_j.email.ne.jp added a reviewer for D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases: delphij.
Jan 23 2022, 9:47 PM
ota_j.email.ne.jp retitled D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases from Refactor to add a new info option for sysctl and thus added test cases to sysctl: Refactor for a function to display info options for and added test cases.
Jan 23 2022, 9:43 PM
ota_j.email.ne.jp added a comment to D20674: [libkvm] kvm_geswapinfo() to stop subtracting vm.dmmax size from swap device sizes..

I'm wondering if this change can be merged.
I have this change in local tree and haven't exposed to an issue since review was requested.

Jan 23 2022, 9:40 PM
ota_j.email.ne.jp requested review of D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
Jan 23 2022, 9:38 PM

Dec 28 2021

ota_j.email.ne.jp added a comment to D33495: systat -vm: Adjust VMSTATCOL from 49 to 52 and use 5 width to display for ease of reading..

This looks like a useful change.

Do you want me to commit it?

Dec 28 2021, 3:59 PM

Dec 16 2021

ota_j.email.ne.jp added a reviewer for D33495: systat -vm: Adjust VMSTATCOL from 49 to 52 and use 5 width to display for ease of reading.: mckusick.
Dec 16 2021, 4:27 AM
ota_j.email.ne.jp requested review of D33495: systat -vm: Adjust VMSTATCOL from 49 to 52 and use 5 width to display for ease of reading..
Dec 16 2021, 4:25 AM

Nov 26 2021

ota_j.email.ne.jp added a comment to D33068: agp: Gracefully handle make_dev() errors if /dev/agpgart already exists.

I tested the new patch with 13.0-RELEASE and confirmed crash isn't happening.

Nov 26 2021, 12:38 AM

Nov 21 2021

ota_j.email.ne.jp added a comment to D33068: agp: Gracefully handle make_dev() errors if /dev/agpgart already exists.

I patched to 13.0-RELEASE.
I rebuilt and installed the new kernel to the specific machine.
I removed hint.agp.1.disabled="1" from /boot/loader.conf.
I verified the new kernel with the patch booted okay after removing the config.

Nov 21 2021, 4:14 AM
ota_j.email.ne.jp added a comment to D33068: agp: Gracefully handle make_dev() errors if /dev/agpgart already exists.

I will test and report back.

Nov 21 2021, 3:36 AM

Oct 23 2021

ota_j.email.ne.jp updated the diff for D29754: Augment systat(1) -swap to display large swap space processes.

There was a bug which resulted not calling new vm.objects_swap.
After fixing the bug and further testing, I no longer see long pause.
In other words, the kernel patch and new sysctl is helping performance improvement.

Oct 23 2021, 5:16 AM

Oct 21 2021

ota_j.email.ne.jp added a comment to D29754: Augment systat(1) -swap to display large swap space processes.

While you say that D31163 did not improve the performance issue with tmpfs files, did it improve performance on other tests? Or did it fail to improve performance on any of your tests?

Oct 21 2021, 4:45 AM

Oct 12 2021

ota_j.email.ne.jp updated the diff for D29754: Augment systat(1) -swap to display large swap space processes.
  • systat: Stop displaying total if there is one swap devise.
  • systat: Implemented per-process swap display on -swap.
  • Avoid double counting and address review comments.
  • systat.1 updates
  • D31163 - Add sysctl vm.objects_swap.
  • Use new vm.objects_swap instead of vm.objects.
Oct 12 2021, 3:54 AM

Jul 24 2021

ota_j.email.ne.jp added a comment to D29754: Augment systat(1) -swap to display large swap space processes.

I started looking into https://reviews.freebsd.org/D31163.
I've been releng/13.0 based system (with cherrypick).
This time, the patch doesn't apply to 13 and I need to prepare main branch based environment.
I will need a bit time to build the latest.

Jul 24 2021, 4:01 AM

May 31 2021

ota_j.email.ne.jp added a comment to D29754: Augment systat(1) -swap to display large swap space processes.

I tested the 2 kernel changes both applied. In short, it helps since the 2nd refresh.

May 31 2021, 3:30 PM
ota_j.email.ne.jp updated the diff for D29754: Augment systat(1) -swap to display large swap space processes.

Update systat.1 based on suggestions.

May 31 2021, 2:49 PM

May 18 2021

ota_j.email.ne.jp added a comment to D29754: Augment systat(1) -swap to display large swap space processes.
In D29754#680269, @kib wrote:

Ok. Could you add the following to the kernel, please, and see if it makes any difference?

diff --git a/sys/vm/vm_object.c b/sys/vm/vm_object.c
index dbb09f67b4c1..cf8b3fcb8f9c 100644
--- a/sys/vm/vm_object.c
+++ b/sys/vm/vm_object.c
@@ -2478,7 +2478,7 @@ sysctl_vm_object_list(SYSCTL_HANDLER_ARGS)
 	struct vnode *vp;
 	struct vattr va;
 	vm_object_t obj;
-	vm_page_t m;
+//	vm_page_t m;
 	u_long sp;
 	int count, error;
 
@@ -2524,6 +2524,7 @@ sysctl_vm_object_list(SYSCTL_HANDLER_ARGS)
 		kvo->kvo_memattr = obj->memattr;
 		kvo->kvo_active = 0;
 		kvo->kvo_inactive = 0;
+#if 0
May 18 2021, 3:13 AM

May 15 2021

ota_j.email.ne.jp added a comment to D29754: Augment systat(1) -swap to display large swap space processes.
In D29754#677726, @kib wrote:

I mean, when asking whether my one-line patch helped, did interactivity of the system during vm.objects retrieval improved? Of course it cannot optimize the running time of the sysctl, but it should allow for other threads to run some more while sysctl is gathering data and copying it out.

May 15 2021, 3:54 AM

May 11 2021

ota_j.email.ne.jp accepted D29354: systat: Add SPDX-License-Identifier.
May 11 2021, 9:55 PM
ota_j.email.ne.jp updated the diff for D29354: systat: Add SPDX-License-Identifier.

Fix once more.

May 11 2021, 1:12 AM

May 9 2021

ota_j.email.ne.jp added a reviewer for D29754: Augment systat(1) -swap to display large swap space processes: bcr.
May 9 2021, 3:10 PM
ota_j.email.ne.jp abandoned D29695: systat: Implemented per-process swap display on -swap.

We have a duplicate review for this and are tracking changes in https://reviews.freebsd.org/D29754.
The comments are addressed in https://reviews.freebsd.org/D29754.

May 9 2021, 3:09 PM
ota_j.email.ne.jp updated the diff for D29754: Augment systat(1) -swap to display large swap space processes.

Adjust systat.1 from the other review.

May 9 2021, 3:09 PM
ota_j.email.ne.jp added a comment to D29754: Augment systat(1) -swap to display large swap space processes.

Most likely it was sysctl vm.objects and not per-proc vmmap sysctl that caused the intermediate hang and CPU usage. As I and Mark discussed it earlier, some more fine-grained API to retrieve e.g. just the shadow chain for given object handle probably would help there.

But before I implement this sysctl, can you recheck, please, that the following patch solves the transient hang issue?

 commit fd2da9e1515bb50fb1c8fb747d9987ee9b8a314d
Author: Konstantin Belousov <kib@FreeBSD.org>
Date:   Sat May 8 01:13:29 2021 +0300

    sysctl vm.objects: yield if hog

diff --git a/sys/vm/vm_object.c b/sys/vm/vm_object.c
index 1c4e879d82ea..b1fa3ebdf9ab 100644
--- a/sys/vm/vm_object.c
+++ b/sys/vm/vm_object.c
@@ -2614,6 +2614,7 @@ sysctl_vm_object_list(SYSCTL_HANDLER_ARGS)
 		kvo->kvo_structsize = roundup(kvo->kvo_structsize,
 		    sizeof(uint64_t));
 		error = SYSCTL_OUT(req, kvo, kvo->kvo_structsize);
+		maybe_yield();
 		mtx_lock(&vm_object_list_mtx);
 		if (error)
 			break;
May 9 2021, 2:43 PM

May 7 2021

ota_j.email.ne.jp added a comment to D29754: Augment systat(1) -swap to display large swap space processes.

Thank you for reviews.

May 7 2021, 6:50 AM
ota_j.email.ne.jp updated the diff for D29754: Augment systat(1) -swap to display large swap space processes.

Remove extra comments.

May 7 2021, 6:39 AM
ota_j.email.ne.jp updated the diff for D29754: Augment systat(1) -swap to display large swap space processes.

another style fix.

May 7 2021, 2:14 AM

May 6 2021

ota_j.email.ne.jp updated the diff for D29754: Augment systat(1) -swap to display large swap space processes.

Remove #include <devstat.h>

May 6 2021, 5:21 AM
ota_j.email.ne.jp added inline comments to D29754: Augment systat(1) -swap to display large swap space processes.
May 6 2021, 5:16 AM
ota_j.email.ne.jp updated the diff for D29754: Augment systat(1) -swap to display large swap space processes.

Style fixes based on review comments and recstored Kirk's systat.1 updates.

May 6 2021, 5:07 AM

May 5 2021

ota_j.email.ne.jp added a comment to D29754: Augment systat(1) -swap to display large swap space processes.

Thanks for the program. Indeed, I saw lots of duplicates from the java program.

May 5 2021, 4:25 AM
ota_j.email.ne.jp updated the diff for D29754: Augment systat(1) -swap to display large swap space processes.
  • Avoid double counting and address review comments.
May 5 2021, 4:10 AM

May 4 2021

ota_j.email.ne.jp updated the diff for D29754: Augment systat(1) -swap to display large swap space processes.

The algorithm has been adjusted proposed approach as below by Konstantin:

May 4 2021, 6:01 AM
ota_j.email.ne.jp commandeered D29754: Augment systat(1) -swap to display large swap space processes.

Kirk and I have been looking into this together.
Given the history of comments, this is a better one for tracking objective of this change.

May 4 2021, 5:56 AM

Apr 23 2021

ota_j.email.ne.jp added a comment to D29354: systat: Add SPDX-License-Identifier.

I had mixed with another changeset and caused failures.

Apr 23 2021, 4:16 AM
ota_j.email.ne.jp updated the diff for D29354: systat: Add SPDX-License-Identifier.

systat: Update to SPDX BSD-2-Clause - I've written zarc.c and sysput.c and University of California hasn't been involved

Apr 23 2021, 4:13 AM

Apr 15 2021

ota_j.email.ne.jp added a comment to D29754: Augment systat(1) -swap to display large swap space processes.
In D29754#667588, @kib wrote:

I saw this patch on a list, and I decided to avoid it.

It does not do what is advertised, i.e. the numbers displayed has nothing related to the 'process swap usage'. First, the swap usage per process is quite hard to define: due to the shadow chaining and sharing of the shadowing objects between siblings, a lot of swap objects is commonly used but simply not visible to the view from the process map level. Second, (and to be fair, it is mentioned in the man page update of this patch), swap object type itself does not imply that a swap is used, at all. Third, even if the top-level object is default, below it, the objects might have swap types.

Apr 15 2021, 5:38 AM

Apr 10 2021

ota_j.email.ne.jp updated the summary of D29695: systat: Implemented per-process swap display on -swap.
Apr 10 2021, 3:21 PM
ota_j.email.ne.jp requested review of D29695: systat: Implemented per-process swap display on -swap.
Apr 10 2021, 3:18 PM

Mar 20 2021

ota_j.email.ne.jp requested review of D29354: systat: Add SPDX-License-Identifier.
Mar 20 2021, 6:22 PM

Mar 19 2021

ota_j.email.ne.jp added a reviewer for D29337: systat: Handle SIGWINCH to properly window resizing and adjust -swap disk stat based on new size.: mr.
Mar 19 2021, 2:40 AM
ota_j.email.ne.jp requested review of D29337: systat: Handle SIGWINCH to properly window resizing and adjust -swap disk stat based on new size..
Mar 19 2021, 2:38 AM

Mar 17 2021

ota_j.email.ne.jp added a reviewer for D29303: systat: Avoid incorrect reallocation in pigs.c: mr.
Mar 17 2021, 12:44 AM
ota_j.email.ne.jp requested review of D29303: systat: Avoid incorrect reallocation in pigs.c.
Mar 17 2021, 12:42 AM

Dec 16 2020

ota_j.email.ne.jp updated the diff for D27496: Improve systat -swap readability and fix display issues.

Fix when the number of swap devise is 1.

Dec 16 2020, 5:22 AM

Dec 7 2020

ota_j.email.ne.jp updated the diff for D27496: Improve systat -swap readability and fix display issues.

Fix off-by-one error over 60% and stop extra +1 for percentage.

Dec 7 2020, 11:22 PM
ota_j.email.ne.jp updated the diff for D27496: Improve systat -swap readability and fix display issues.

Fix style.

Dec 7 2020, 1:11 AM
ota_j.email.ne.jp updated the diff for D27496: Improve systat -swap readability and fix display issues.

Add a , to .Xr ls

Dec 7 2020, 12:55 AM
ota_j.email.ne.jp updated the diff for D27496: Improve systat -swap readability and fix display issues.

Update getbsize man page.

Dec 7 2020, 12:53 AM
ota_j.email.ne.jp updated the summary of D27496: Improve systat -swap readability and fix display issues.
Dec 7 2020, 12:25 AM
ota_j.email.ne.jp requested review of D27496: Improve systat -swap readability and fix display issues.
Dec 7 2020, 12:24 AM

Oct 19 2020

ota_j.email.ne.jp updated the diff for D26542: [ggated/ggatec] Simplify Gate Handshake..

Remove extra spaces around a function argument.

Oct 19 2020, 4:09 AM
ota_j.email.ne.jp added inline comments to D26542: [ggated/ggatec] Simplify Gate Handshake..
Oct 19 2020, 4:07 AM
ota_j.email.ne.jp updated the diff for D26542: [ggated/ggatec] Simplify Gate Handshake..

Use bitmask to indicate which protocol versions to try.
Also remove duplicate check.

Oct 19 2020, 2:26 AM

Oct 18 2020

ota_j.email.ne.jp planned changes to D26542: [ggated/ggatec] Simplify Gate Handshake..

I make multiple read-only connection for installworld/installkernel from different machines.
Otherwise, I use ggate to export some ufs file systems.
I could use nfs for these as well.

Oct 18 2020, 4:57 AM
ota_j.email.ne.jp updated the diff for D26542: [ggated/ggatec] Simplify Gate Handshake..

Address some of problems pointed by code review.

Oct 18 2020, 3:17 AM

Sep 28 2020

ota_j.email.ne.jp added a comment to D26542: [ggated/ggatec] Simplify Gate Handshake..

The slowness issue existed back in a decade ago around 6.1-RELEASE and some years/releases thereafter.

Sep 28 2020, 4:48 AM

Sep 24 2020

ota_j.email.ne.jp retitled D26542: [ggated/ggatec] Simplify Gate Handshake. from Simplify Gate Handshake. to [ggated/ggatec] Simplify Gate Handshake..
Sep 24 2020, 3:48 AM
ota_j.email.ne.jp added a reviewer for D26503: [systat] Improve number reading by rounding up to a next unit earlier for memory display.: mr.
Sep 24 2020, 3:43 AM
ota_j.email.ne.jp requested review of D26542: [ggated/ggatec] Simplify Gate Handshake..
Sep 24 2020, 2:07 AM

Sep 20 2020

ota_j.email.ne.jp requested review of D26503: [systat] Improve number reading by rounding up to a next unit earlier for memory display..
Sep 20 2020, 11:57 PM

Sep 9 2020

ota_j.email.ne.jp updated the diff for D21388: Fix ggated/ggatec debug print of offsets..

Thank you for checking this again.
It was also my bad that the problem wasn't described well enough.

Sep 9 2020, 1:55 AM

Sep 7 2020

ota_j.email.ne.jp updated the summary of D21388: Fix ggated/ggatec debug print of offsets..
Sep 7 2020, 2:09 AM
ota_j.email.ne.jp updated the diff for D21388: Fix ggated/ggatec debug print of offsets..

Stop using PR* formatter.
Tested on i386 and amd64.

Sep 7 2020, 2:06 AM

Sep 6 2020

ota_j.email.ne.jp added a comment to D21388: Fix ggated/ggatec debug print of offsets..

ggate defines its offset in unsigned int 64 as below.
So, printing negative numbers from printf indicates using a wrong formatter.

Sep 6 2020, 8:38 PM

Aug 29 2020

ota_j.email.ne.jp added a reviewer for D21388: Fix ggated/ggatec debug print of offsets.: markj.
Aug 29 2020, 2:14 AM
ota_j.email.ne.jp added a comment to D26168: Bug 132845: ggated: Fix double file open and file descriptor leak..

Thank you for your support, Mark.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=132845 is the corresponding bugzilla entry.

Aug 29 2020, 2:12 AM

Aug 28 2020

ota_j.email.ne.jp updated the diff for D26168: Bug 132845: ggated: Fix double file open and file descriptor leak..

Verify paths are the same between handshakes for a single session.

Aug 28 2020, 3:24 AM
ota_j.email.ne.jp added inline comments to D26168: Bug 132845: ggated: Fix double file open and file descriptor leak..
Aug 28 2020, 3:01 AM

Aug 27 2020

ota_j.email.ne.jp updated the diff for D26168: Bug 132845: ggated: Fix double file open and file descriptor leak..

Moved close() to connection_remove() and aligned with send/recv fds.

Aug 27 2020, 3:50 AM

Aug 26 2020

ota_j.email.ne.jp added a comment to D26168: Bug 132845: ggated: Fix double file open and file descriptor leak..

First of all, thank you for your quick response.

Aug 26 2020, 4:39 AM

Aug 25 2020

ota_j.email.ne.jp added a reviewer for D26168: Bug 132845: ggated: Fix double file open and file descriptor leak.: cem.
Aug 25 2020, 3:14 AM

Aug 24 2020

ota_j.email.ne.jp added a reviewer for D26168: Bug 132845: ggated: Fix double file open and file descriptor leak.: pjd.
Aug 24 2020, 2:18 AM
ota_j.email.ne.jp added a reviewer for D26168: Bug 132845: ggated: Fix double file open and file descriptor leak.: delphij.
Aug 24 2020, 2:16 AM
ota_j.email.ne.jp requested review of D26168: Bug 132845: ggated: Fix double file open and file descriptor leak..
Aug 24 2020, 2:12 AM

Aug 2 2020

ota_j.email.ne.jp updated the test plan for D25920: Fault in the parent of zombie/killed processes before killing a process in OOM..
Aug 2 2020, 4:04 PM
ota_j.email.ne.jp requested review of D25920: Fault in the parent of zombie/killed processes before killing a process in OOM..
Aug 2 2020, 3:59 PM

Jun 12 2020

ota_j.email.ne.jp updated the diff for D25226: PR 219829 Handle device removal and removal+add cases to fix infinity rate..

Added static to implementatoin; follow style of other existing static functions.

Jun 12 2020, 3:44 AM
ota_j.email.ne.jp updated the diff for D25226: PR 219829 Handle device removal and removal+add cases to fix infinity rate..

Drop unnecessary NULL check. This is a field on a struct and won't be NULL.

Jun 12 2020, 3:42 AM

Jun 11 2020

ota_j.email.ne.jp retitled D25226: PR 219829 Handle device removal and removal+add cases to fix infinity rate. from PR 219829 -Handle device removal and removal+add cases to fix infinity rate. to PR 219829 Handle device removal and removal+add cases to fix infinity rate..
Jun 11 2020, 3:41 AM
ota_j.email.ne.jp added a reviewer for D25226: PR 219829 Handle device removal and removal+add cases to fix infinity rate.: mr.
Jun 11 2020, 3:39 AM
ota_j.email.ne.jp requested review of D25226: PR 219829 Handle device removal and removal+add cases to fix infinity rate..
Jun 11 2020, 3:05 AM