Page MenuHomeFreeBSD

ota_j.email.ne.jp (Yoshihiro Ota)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 13 2017, 4:43 AM (137 w, 4 d)

Recent Activity

Fri, Jun 12

ota_j.email.ne.jp updated the diff for D25226: PR 219829 Handle device removal and removal+add cases to fix infinity rate..

Added static to implementatoin; follow style of other existing static functions.

Fri, Jun 12, 3:44 AM
ota_j.email.ne.jp updated the diff for D25226: PR 219829 Handle device removal and removal+add cases to fix infinity rate..

Drop unnecessary NULL check. This is a field on a struct and won't be NULL.

Fri, Jun 12, 3:42 AM

Thu, Jun 11

ota_j.email.ne.jp retitled D25226: PR 219829 Handle device removal and removal+add cases to fix infinity rate. from PR 219829 -Handle device removal and removal+add cases to fix infinity rate. to PR 219829 Handle device removal and removal+add cases to fix infinity rate..
Thu, Jun 11, 3:41 AM
ota_j.email.ne.jp added a reviewer for D25226: PR 219829 Handle device removal and removal+add cases to fix infinity rate.: mr.
Thu, Jun 11, 3:39 AM
ota_j.email.ne.jp requested review of D25226: PR 219829 Handle device removal and removal+add cases to fix infinity rate..
Thu, Jun 11, 3:05 AM

May 29 2020

ota_j.email.ne.jp added a comment to D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..

I think I addressed all of feed backs so far.
I'm wondering if someone can take a look.

May 29 2020, 4:18 AM

May 14 2020

ota_j.email.ne.jp added a reviewer for D24834: systat: Introduced sysputpage() to display large page size with human readable format.: f20190109_eeeit.de.
May 14 2020, 2:33 AM
ota_j.email.ne.jp retitled D24834: systat: Introduced sysputpage() to display large page size with human readable format. from Introduced sysputpage() to display large page size with human readable format. to systat: Introduced sysputpage() to display large page size with human readable format..
May 14 2020, 2:27 AM
ota_j.email.ne.jp requested review of D24834: systat: Introduced sysputpage() to display large page size with human readable format..
May 14 2020, 2:25 AM
ota_j.email.ne.jp added inline comments to D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..
May 14 2020, 2:11 AM
ota_j.email.ne.jp updated the diff for D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..

Address other review comments.

May 14 2020, 2:10 AM

Mar 20 2020

ota_j.email.ne.jp updated the diff for D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..

Fixed style, moved 0 assignment to *before and *after when SWWAPBLK_NONE,
and adjusted if/else statement for *after case.

Mar 20 2020, 2:04 AM

Mar 15 2020

ota_j.email.ne.jp added inline comments to D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..
Mar 15 2020, 1:05 PM
ota_j.email.ne.jp added inline comments to D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..
Mar 15 2020, 12:28 AM
ota_j.email.ne.jp updated the diff for D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..

Split backward and forward search into separate functions for ease of reading.

Mar 15 2020, 12:24 AM

Mar 5 2020

ota_j.email.ne.jp added a comment to D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..

Thank you for quick response, Mark.

Mar 5 2020, 4:37 AM

Feb 25 2020

ota_j.email.ne.jp updated the test plan for D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..
Feb 25 2020, 6:13 AM

Jan 20 2020

ota_j.email.ne.jp updated the diff for D23274: Use swp_swdevt as struct swdevt and swp_swblk as struct swblk function prefix, respectively..

Updated function name in comment.

Jan 20 2020, 2:49 AM
ota_j.email.ne.jp created D23274: Use swp_swdevt as struct swdevt and swp_swblk as struct swblk function prefix, respectively..
Jan 20 2020, 2:46 AM
ota_j.email.ne.jp updated the diff for D23222: Check swblk size if a swap device has enoush space before calling blist_alloc.

Changed its prefix to swdevt.

Jan 20 2020, 2:44 AM

Jan 18 2020

ota_j.email.ne.jp abandoned D20675: Eliminate incorrect 2 pagesized block skipping while preparing swap device..
Jan 18 2020, 4:12 AM

Jan 17 2020

ota_j.email.ne.jp created D23222: Check swblk size if a swap device has enoush space before calling blist_alloc.
Jan 17 2020, 3:07 AM

Nov 22 2019

ota_j.email.ne.jp updated the diff for D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..

Check NULL pointers explicitly.

Nov 22 2019, 12:36 AM
ota_j.email.ne.jp added inline comments to D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..
Nov 22 2019, 12:34 AM

Nov 21 2019

ota_j.email.ne.jp updated the diff for D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..

Restore KASSERT.

Nov 21 2019, 3:27 AM

Nov 20 2019

ota_j.email.ne.jp added inline comments to D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..
Nov 20 2019, 5:31 AM
ota_j.email.ne.jp retitled D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks. from swp_pager_meta_lookup() to find swap address and additionally search for the number of continuous blocks. to Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..
Nov 20 2019, 1:45 AM
ota_j.email.ne.jp updated the diff for D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..

Update and merge D22437.

Nov 20 2019, 1:41 AM

Nov 18 2019

ota_j.email.ne.jp added a comment to D22324: try to free blocks by upgrading object locks.

It looks we better drop swp_pager_meta_ctl() changes from this, D22324, and let D22409 take over the lookup implementation while dropping SWM_POP for simpler diff.
D22409 change is to optimize swap_pager_haspage() with additional searches after successful pindex lookup.

Nov 18 2019, 4:35 AM

Nov 16 2019

ota_j.email.ne.jp updated the diff for D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..

Dropped self-test.

Nov 16 2019, 6:22 PM
ota_j.email.ne.jp created D22409: Optimize swp_pager_meta_lookup() to find additionally the numbers of continuous blocks..
Nov 16 2019, 2:39 PM
ota_j.email.ne.jp created D22402: Create swp_pager_free_empty_swblk function to free if a swblk is free..
Nov 16 2019, 1:16 AM

Nov 15 2019

ota_j.email.ne.jp abandoned D22256: Skip SWAPBLK_NONEs with swap_pager_find_least() in swap_pager_copy()..

D22280 has been committed.

Nov 15 2019, 8:42 AM

Nov 11 2019

ota_j.email.ne.jp added inline comments to D22280: exploit sparsity in swap_pager_copy.
Nov 11 2019, 2:12 AM

Nov 9 2019

ota_j.email.ne.jp updated the diff for D22256: Skip SWAPBLK_NONEs with swap_pager_find_least() in swap_pager_copy()..

Correct swblk index and exclude swp_pager_swblk_free_empty() changes.

Nov 9 2019, 6:38 PM
ota_j.email.ne.jp abandoned D21990: Optimize vm_page_in_laundry() with a bit operation..
Nov 9 2019, 5:31 AM
ota_j.email.ne.jp added a comment to D22280: exploit sparsity in swap_pager_copy.

I don't think this code duplication in swap_pager_copy() is a good idea.
I updated D22256 to avoid the double lookup cost from the first revision.
I'm still testing the 2nd version though.

Nov 9 2019, 4:03 AM
ota_j.email.ne.jp updated the diff for D22256: Skip SWAPBLK_NONEs with swap_pager_find_least() in swap_pager_copy()..

Fixed spaces/style.

Nov 9 2019, 3:49 AM
ota_j.email.ne.jp updated the diff for D22256: Skip SWAPBLK_NONEs with swap_pager_find_least() in swap_pager_copy()..

Created swp_pager_meta_find_least private API to find and delete in a single
operation. swap_pager_find_least calls it for look up.

Nov 9 2019, 3:44 AM

Nov 6 2019

ota_j.email.ne.jp created D22256: Skip SWAPBLK_NONEs with swap_pager_find_least() in swap_pager_copy()..
Nov 6 2019, 5:36 AM

Nov 5 2019

ota_j.email.ne.jp planned changes to D22088: Wait until swap space becomes full before start killing processes..

Suspend for now.

Nov 5 2019, 11:26 PM

Oct 25 2019

ota_j.email.ne.jp created D22150: Update swapon.8 to discourage using ZFS as swap device/file..
Oct 25 2019, 3:37 AM
ota_j.email.ne.jp updated the diff for D21990: Optimize vm_page_in_laundry() with a bit operation..

I've been using the comparison based optimization for 2 weeks on current
following daily, buildworld/buildkernel daily and haven't seen an issue
with this approach.

Oct 25 2019, 3:34 AM

Oct 21 2019

ota_j.email.ne.jp added a comment to D22088: Wait until swap space becomes full before start killing processes..

I see. I just added zfs/zvol swap space temporary from command line within the last a couple of weeks for other reasons. I see few of too early OOM on few of machines although it is very rare and spontaneous such that it hasn't been easy to find a trigger.

Oct 21 2019, 10:38 PM

Oct 20 2019

ota_j.email.ne.jp added a comment to D22088: Wait until swap space becomes full before start killing processes..

swap_pager_full != 0 was indeed too aggressive. I'm wondering if we can feed in swap space usage such that we can delay OOM electing at low usage and push for OOM at high usage.

Oct 20 2019, 3:30 AM

Oct 19 2019

ota_j.email.ne.jp created D22088: Wait until swap space becomes full before start killing processes..
Oct 19 2019, 4:22 AM

Oct 17 2019

ota_j.email.ne.jp retitled D22065: swapon_check_swzone() to use already calculated static variables from swapon_check_swzone() to use already calclurated static variables to swapon_check_swzone() to use already calculated static variables.
Oct 17 2019, 12:37 AM
ota_j.email.ne.jp retitled D22065: swapon_check_swzone() to use already calculated static variables from swapon_check_swzone() to use already calclurated static variable. to swapon_check_swzone() to use already calclurated static variables.
Oct 17 2019, 12:33 AM
ota_j.email.ne.jp created D22065: swapon_check_swzone() to use already calculated static variables.
Oct 17 2019, 12:26 AM

Oct 14 2019

ota_j.email.ne.jp added a comment to D21990: Optimize vm_page_in_laundry() with a bit operation..

That's another idea.
I will check the code and test if that is also an option.

Oct 14 2019, 5:26 AM
ota_j.email.ne.jp added a comment to D21990: Optimize vm_page_in_laundry() with a bit operation..

Thanks for follow up, markj.

Oct 14 2019, 12:34 AM

Oct 13 2019

ota_j.email.ne.jp added inline comments to D21989: Use enumeration to indicate swap almost full and full, instead of 2 variables..
Oct 13 2019, 2:42 AM

Oct 12 2019

ota_j.email.ne.jp updated the diff for D21989: Use enumeration to indicate swap almost full and full, instead of 2 variables..

Use "== SWPG_LOW" comparison for almost full warning.
Drop swp_gauge > SWPG_LOW comparison for high watermark check.

Oct 12 2019, 4:47 AM
ota_j.email.ne.jp created D21990: Optimize vm_page_in_laundry() with a bit operation..
Oct 12 2019, 2:18 AM
ota_j.email.ne.jp created D21989: Use enumeration to indicate swap almost full and full, instead of 2 variables..
Oct 12 2019, 2:07 AM

Oct 3 2019

ota_j.email.ne.jp created D21881: Remove unnecessary vm_page.h and vm_pager.h includes..
Oct 3 2019, 2:43 AM
ota_j.email.ne.jp abandoned D20618: [archivers/nulib] PR 21519 - Use dirent.h instead of sys/dir.h.

The only reason I created a patch was to proceed removal of sys/dir.h in the base system.
Given the upstream source hasn't been updated for more than a couple of decade.
It looks the code still assume 20 year old standard.

Oct 3 2019, 2:37 AM

Sep 29 2019

ota_j.email.ne.jp added a comment to D20674: [libkvm] kvm_geswapinfo() to stop subtracting vm.dmmax size from swap device sizes..

But sysctl describes totally different:

Sep 29 2019, 3:28 AM
ota_j.email.ne.jp added a comment to D20674: [libkvm] kvm_geswapinfo() to stop subtracting vm.dmmax size from swap device sizes..

Skipping is about https://svnweb.freebsd.org/base/head/sys/vm/swap_pager.c?revision=352407&view=markup#l2313

Sep 29 2019, 3:16 AM

Sep 18 2019

ota_j.email.ne.jp updated the diff for D21531: Use zlib's uncompress function for simpler code..

destLen -> destlen.

Sep 18 2019, 4:16 AM

Sep 7 2019

ota_j.email.ne.jp added a comment to D21530: Fix ggate.h typo..

Thanks.

Sep 7 2019, 12:30 AM

Sep 6 2019

ota_j.email.ne.jp added reviewers for D21530: Fix ggate.h typo.: pjd, delphij.
Sep 6 2019, 4:06 AM

Sep 5 2019

ota_j.email.ne.jp created D21531: Use zlib's uncompress function for simpler code..
Sep 5 2019, 4:37 AM
ota_j.email.ne.jp created D21530: Fix ggate.h typo..
Sep 5 2019, 4:25 AM

Aug 27 2019

ota_j.email.ne.jp added a comment to D21388: Fix ggated/ggatec debug print of offsets..

Remove uninteded debug print.

Aug 27 2019, 12:44 AM

Aug 26 2019

ota_j.email.ne.jp added a comment to D21388: Fix ggated/ggatec debug print of offsets..

Also print length with PRIu32.

Aug 26 2019, 11:00 PM

Aug 25 2019

D21375: Remove zlib 1.0.4 from kernel. is now accepted and ready to land.
Aug 25 2019, 2:07 PM
ota_j.email.ne.jp added inline comments to D21408: GZIO to update zlib version 1.0.4 to 1.2.11..
Aug 25 2019, 3:02 AM
ota_j.email.ne.jp updated the test plan for D21408: GZIO to update zlib version 1.0.4 to 1.2.11..
Aug 25 2019, 2:59 AM
ota_j.email.ne.jp added a comment to D21408: GZIO to update zlib version 1.0.4 to 1.2.11..

Include zutil.h instead of zlib.h in order to pick up OS_CODE and DEF_MEM_LEVEL.

Aug 25 2019, 2:58 AM

Aug 24 2019

ota_j.email.ne.jp added inline comments to D21375: Remove zlib 1.0.4 from kernel..
Aug 24 2019, 10:47 PM
ota_j.email.ne.jp created D21408: GZIO to update zlib version 1.0.4 to 1.2.11..
Aug 24 2019, 10:44 PM

Aug 23 2019

ota_j.email.ne.jp added a reviewer for D21388: Fix ggated/ggatec debug print of offsets.: pjd.
Aug 23 2019, 11:59 PM
ota_j.email.ne.jp created D21388: Fix ggated/ggatec debug print of offsets..
Aug 23 2019, 11:57 PM
D21375: Remove zlib 1.0.4 from kernel. now requires changes to proceed.

We have a last item - sys/kern/subr_compressor.c includes sys/zutil.h.
I attempted and saw crc32() API conflict between gsb_crc32.h and zutil.h.
I haven't got a chance this week, though.

Aug 23 2019, 11:51 PM

Aug 22 2019

ota_j.email.ne.jp added a comment to D21186: Convert ng_deflate to use new zlib..

Thank you for explanations.
I found and had looked at that git repo while reviewing this change.
However, I didn't have enough guts to look into each of repo history to figure out which one came from where.
That explains why all of ppp use Z_PACKET_FLUSH while really NONE uses Z_SYNC_FLUSH.

Aug 22 2019, 3:17 AM

Aug 18 2019

ota_j.email.ne.jp added a comment to D21186: Convert ng_deflate to use new zlib..

The change looks reasonable based on PPP protocol and comparison to existing zlib code.

Aug 18 2019, 10:08 PM
ota_j.email.ne.jp added inline comments to D21186: Convert ng_deflate to use new zlib..
Aug 18 2019, 10:13 AM

Aug 17 2019

ota_j.email.ne.jp added a comment to D21186: Convert ng_deflate to use new zlib..

I will take a closer look.
I've never used nor looked into details of this API.
Please allow me a bit extra time for review.

Aug 17 2019, 1:36 AM

Aug 15 2019

ota_j.email.ne.jp added inline comments to D21191: Don't trim bsd_label.
Aug 15 2019, 5:34 AM
ota_j.email.ne.jp added inline comments to D20599: simple trimming before swapon.
Aug 15 2019, 5:19 AM

Aug 9 2019

ota_j.email.ne.jp added inline comments to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..
Aug 9 2019, 6:54 AM

Aug 8 2019

ota_j.email.ne.jp added a comment to D21186: Convert ng_deflate to use new zlib..

I haven't looked into FreeBSD extension of zlib yet to see if this change is safe.

Aug 8 2019, 10:23 PM
ota_j.email.ne.jp added a comment to D20675: Eliminate incorrect 2 pagesized block skipping while preparing swap device..

I wasn't aware of swap partition being the the first in a slice was the case. All of my swaps have been either one of whole device, whole slice or non-first partition, or NFS files. No wonder I never encountered any issues over years even with this change on my local tree.

Aug 8 2019, 10:17 PM

Aug 7 2019

ota_j.email.ne.jp created D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11.
Aug 7 2019, 4:45 AM
ota_j.email.ne.jp created D21175: bxe to update zlib version 1.0.4 to 1.2.11..
Aug 7 2019, 4:28 AM
ota_j.email.ne.jp added inline comments to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..
Aug 7 2019, 4:08 AM

Aug 6 2019

ota_j.email.ne.jp added a comment to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..

I found and have one more minor comment.

Aug 6 2019, 5:43 AM

Aug 5 2019

ota_j.email.ne.jp added inline comments to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..
Aug 5 2019, 10:55 PM

Aug 4 2019

ota_j.email.ne.jp retitled D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11. from Expose functions from compress.c and geom_uzip to update zlib version 1.0.4 to 1.2.11. to geom_uzip to update zlib version 1.0.4 to 1.2.11..
Aug 4 2019, 3:37 PM
ota_j.email.ne.jp added a comment to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..

I agree with the changes.

Aug 4 2019, 3:34 PM

Aug 3 2019

ota_j.email.ne.jp accepted D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
Aug 3 2019, 2:27 PM
ota_j.email.ne.jp retitled D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11. from geom_uzip to update zlib version 1.0.4 to 1.2.11. to Expose functions from compress.c and geom_uzip to update zlib version 1.0.4 to 1.2.11..
Aug 3 2019, 12:36 AM
ota_j.email.ne.jp added a comment to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..

Expose functions from compress.c with modified MY_ZCALLC handling.

Aug 3 2019, 12:18 AM

Aug 2 2019

ota_j.email.ne.jp added a comment to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..

Enhancce MY_ZCALLOC to expose functions in compress.c.
This also allows to use default zfree.

Aug 2 2019, 12:16 PM
ota_j.email.ne.jp updated the summary of D20272: if_mxge to update zlib version 1.0.4 to 1.2.11..
Aug 2 2019, 3:46 AM
Herald added a reviewer for D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11.: manpages.

Given we added -DZ_SOLO to zlib, pass zfree function explicitly.
Expose compressBound() function even with -DZ_SOLO.
compress2() doesn't work with -DZ_SOLO and not worth exposing as is.
Alternative is improve MY_ZCALLOC conditions along with Z_SOLO for compress2 to work as well.

Aug 2 2019, 2:35 AM
ota_j.email.ne.jp added inline comments to D20272: if_mxge to update zlib version 1.0.4 to 1.2.11..
Aug 2 2019, 2:28 AM
Herald added a reviewer for D20272: if_mxge to update zlib version 1.0.4 to 1.2.11.: manpages.

Given we added -DZ_SOLO to zlib, pass zfree function explicitly.

Aug 2 2019, 2:26 AM

Aug 1 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

I tested reads and writes on gzipped ZFS between 12.0-RELEASE and 13-CURRENT with this changes.
The test result was good.

Aug 1 2019, 5:09 AM