Page MenuHomeFreeBSD

systat: Avoid incorrect reallocation in pigs.c
ClosedPublic

Authored by ota_j.email.ne.jp on Mar 17 2021, 12:42 AM.
Tags
None
Referenced Files
F105976344: D29303.diff
Mon, Dec 23, 8:49 AM
Unknown Object (File)
Thu, Dec 5, 4:33 AM
Unknown Object (File)
Nov 22 2024, 11:30 AM
Unknown Object (File)
Nov 18 2024, 9:48 PM
Unknown Object (File)
Nov 18 2024, 9:29 PM
Unknown Object (File)
Nov 12 2024, 12:21 AM
Unknown Object (File)
Nov 11 2024, 11:54 PM
Unknown Object (File)
Oct 22 2024, 11:11 AM

Details

Summary

Let's say nproc comes back in 3, 1, 2, the reallocation happens on the 3rd
fetch given lastnproc 1 is smaller than nproc 2. However, we reserved 3 slots
and thus don't need to reallocate.

Stop free() even if kvm_getprocs as we can come back but set nprocs = 0.
Check nprocs in showpigs() to ensure not try displaying with kvm_getprocs failed.
Current code can have pt with non-null after kvm_getprocs() failure.

Replace to realloc for simpler operations.

Test Plan

% systat -pigs

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable