Page MenuHomeFreeBSD

systat: Avoid incorrect reallocation in pigs.c
ClosedPublic

Authored by ota_j.email.ne.jp on Mar 17 2021, 12:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 28, 8:51 AM
Unknown Object (File)
Thu, Mar 26, 4:07 PM
Unknown Object (File)
Sat, Mar 21, 1:41 PM
Unknown Object (File)
Sat, Mar 14, 3:14 AM
Unknown Object (File)
Mar 6 2026, 7:09 PM
Unknown Object (File)
Mar 6 2026, 9:14 AM
Unknown Object (File)
Mar 3 2026, 12:17 PM
Unknown Object (File)
Mar 2 2026, 12:39 AM

Details

Summary

Let's say nproc comes back in 3, 1, 2, the reallocation happens on the 3rd
fetch given lastnproc 1 is smaller than nproc 2. However, we reserved 3 slots
and thus don't need to reallocate.

Stop free() even if kvm_getprocs as we can come back but set nprocs = 0.
Check nprocs in showpigs() to ensure not try displaying with kvm_getprocs failed.
Current code can have pt with non-null after kvm_getprocs() failure.

Replace to realloc for simpler operations.

Test Plan

% systat -pigs

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable