Page MenuHomeFreeBSD

systat: Avoid incorrect reallocation in pigs.c
ClosedPublic

Authored by ota_j.email.ne.jp on Mar 17 2021, 12:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 22, 3:26 PM
Unknown Object (File)
Mon, Jan 20, 1:08 PM
Unknown Object (File)
Fri, Jan 17, 1:36 PM
Unknown Object (File)
Fri, Jan 17, 1:31 PM
Unknown Object (File)
Fri, Jan 17, 6:09 AM
Unknown Object (File)
Thu, Jan 16, 7:22 PM
Unknown Object (File)
Sat, Jan 11, 11:38 PM
Unknown Object (File)
Mon, Jan 6, 6:09 AM

Details

Summary

Let's say nproc comes back in 3, 1, 2, the reallocation happens on the 3rd
fetch given lastnproc 1 is smaller than nproc 2. However, we reserved 3 slots
and thus don't need to reallocate.

Stop free() even if kvm_getprocs as we can come back but set nprocs = 0.
Check nprocs in showpigs() to ensure not try displaying with kvm_getprocs failed.
Current code can have pt with non-null after kvm_getprocs() failure.

Replace to realloc for simpler operations.

Test Plan

% systat -pigs

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable