Page MenuHomeFreeBSD

systat: Avoid incorrect reallocation in pigs.c
ClosedPublic

Authored by ota_j.email.ne.jp on Mar 17 2021, 12:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 12:58 AM
Unknown Object (File)
Sat, Oct 11, 12:58 AM
Unknown Object (File)
Sat, Oct 11, 12:58 AM
Unknown Object (File)
Fri, Oct 10, 6:18 PM
Unknown Object (File)
Thu, Oct 9, 5:29 AM
Unknown Object (File)
Tue, Oct 7, 3:01 AM
Unknown Object (File)
Fri, Sep 19, 10:50 AM
Unknown Object (File)
Wed, Sep 17, 10:49 AM

Details

Summary

Let's say nproc comes back in 3, 1, 2, the reallocation happens on the 3rd
fetch given lastnproc 1 is smaller than nproc 2. However, we reserved 3 slots
and thus don't need to reallocate.

Stop free() even if kvm_getprocs as we can come back but set nprocs = 0.
Check nprocs in showpigs() to ensure not try displaying with kvm_getprocs failed.
Current code can have pt with non-null after kvm_getprocs() failure.

Replace to realloc for simpler operations.

Test Plan

% systat -pigs

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable