Page MenuHomeFreeBSD

systat: Avoid incorrect reallocation in pigs.c
ClosedPublic

Authored by ota_j.email.ne.jp on Mar 17 2021, 12:42 AM.
Tags
None
Referenced Files
F129105503: D29303.diff
Wed, Sep 17, 10:49 AM
Unknown Object (File)
Fri, Sep 12, 3:18 AM
Unknown Object (File)
Mon, Sep 8, 10:22 PM
Unknown Object (File)
Sat, Sep 6, 9:00 PM
Unknown Object (File)
Sat, Aug 23, 2:56 AM
Unknown Object (File)
Wed, Aug 20, 10:10 AM
Unknown Object (File)
Aug 13 2025, 1:57 AM
Unknown Object (File)
Aug 11 2025, 4:16 PM

Details

Summary

Let's say nproc comes back in 3, 1, 2, the reallocation happens on the 3rd
fetch given lastnproc 1 is smaller than nproc 2. However, we reserved 3 slots
and thus don't need to reallocate.

Stop free() even if kvm_getprocs as we can come back but set nprocs = 0.
Check nprocs in showpigs() to ensure not try displaying with kvm_getprocs failed.
Current code can have pt with non-null after kvm_getprocs() failure.

Replace to realloc for simpler operations.

Test Plan

% systat -pigs

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37885
Build 34774: arc lint + arc unit