Page MenuHomeFreeBSD

systat -vm: Adjust VMSTATCOL from 49 to 52 and use 5 width to display for ease of reading.
ClosedPublic

Authored by ota_j.email.ne.jp on Dec 16 2021, 4:25 AM.

Details

Summary

Using 8 width is too wide for large numbers like 1379991K
and 1330M is easier to read

Test Plan

systat -vm 10
For example, the column where totfr is displayed.

  • OLD -------------------------------------------------------------------------- 5 users Load 0.13 0.43 0.71 Dec 9 22:35 Mem usage: 97%Phy 41%Kmem VN PAGER SWAP PAGER

Mem: REAL VIRTUAL in out in out

Tot   Share     Tot    Share     Free   count     1

Act 573M 0 4064M 0 59376K pages 3
All 574M 292K 4085M 16224K 1 ioflt Interrupts
Proc: 20 cow 358 total

r   p   d    s   w   Csw  Trp  Sys  Int  Sof  Flt 1348M zfod      8 atkbd0 1
           243   8    1G   1G   9G  268   23   1G     1 ozfod       psm0 12
                                                       %ozfod     1 ata1 15

1.3%Sys 1.7%Intr 0.2%User 0.0%Nice 96.8%Idle daefr 255 pcm0 le1

8 prcfr mpt0 ehci0

> 1379991K totfr uhci0 18

4 dtbuf          react       le0 19

Namei Name-cache Dir-cache 110803 maxvn pdwak 31 cpu0:timer

Calls    hits   %    hits   %    110402 numvn 1379991K pdpgs    18 cpu1:timer
  161     154  96                 94937 frevn          intrn    20 cpu2:timer
                                                  774M wire     22 cpu3:timer

Disks ada0 ada1 ada2 cd0 pass0 pass1 pass2 412M act 1 ahci0 24
KB/t 16.00 1.50 0.00 0.00 0.00 0.00 0.00 189M inact 2 xhci0 26
tps 1 0 0 0 0 0 0 128M laund vmci0 58
MB/s 0.01 0.00 0.00 0.00 0.00 0.00 0.00 59376K free
%busy 0 0 0 0 0 0 0 75018K buf

  • NEW -------------------------------------------------------------------------- 5 users Load 0.11 0.41 0.70 Dec 9 22:35 Mem usage: 97%Phy 41%Kmem VN PAGER SWAP PAGER

Mem: REAL VIRTUAL in out in out

Tot   Share     Tot    Share     Free   count

Act 573M 0 4065M 0 59056K pages
All 574M 292K 4085M 16224K ioflt Interrupts
Proc: cow 362 total

r   p   d    s   w   Csw  Trp  Sys  Int  Sof  Flt 1330M zfod      8 atkbd0 1
           243   8    1G   1G   9G  269   25   1G       ozfod     3 psm0 12
                                                       %ozfod     1 ata1 15

0.7%Sys 2.4%Intr 0.1%User 0.0%Nice 96.8%Idle daefr 254 pcm0 le1

prcfr mpt0 ehci0

++ 1330M totfr uhci0 18

9 dtbuf          react       le0 19

Namei Name-cache Dir-cache 110803 maxvn pdwak 38 cpu0:timer

Calls    hits   %    hits   %    110406 numvn    1330M pdpgs    16 cpu1:timer
   55      48  87                 94937 frevn          intrn    18 cpu2:timer
                                                  774M wire     21 cpu3:timer

Disks ada0 ada1 ada2 cd0 pass0 pass1 pass2 413M act 1 ahci0 24
KB/t 9.00 0.00 0.00 0.00 0.00 0.00 0.00 189M inact 2 xhci0 26
tps 1 0 0 0 0 0 0 127M laund vmci0 58
MB/s 0.01 0.00 0.00 0.00 0.00 0.00 0.00 58M free
%busy 0 0 0 0 0 0 0 73M buf

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This looks like a useful change.

Do you want me to commit it?

This revision is now accepted and ready to land.Dec 28 2021, 6:37 AM

This looks like a useful change.

Do you want me to commit it?

Yes, please.
It will be also nice if you can merge to 12 and 13 branches after a waiting period is over, too.

I have made the commit to head and have scheduled MFC in two weeks.
I will certainly MFC it to 13. I have not set up an environment for MFC'ing to 12, but will do so if time permits.
Please send me your email address to mckusick@mckusick.com.