ps(1): let J flag list all jailed processes

[rew]

Summary

Add an argument, -1, to the J flag.

To get a listing of all jailed processes: ps -J -1

[debdrup]

Are there other places where -(j|J) -1 is used to list all jails, instead of simply doing -(j|J)?

I don't recall any off hand, and I would think it makes more sense to not require -1 to list all of them if it can be done without.

[allanjude]

bin/ps/ps.c

798–799

since -1 is what jail_getid() returns on error, it might make more sense to check something like strcmp(elem, "-1") == 0 and if so don't bother calling jail_getid(), to help disambiguate between 'elem was literally -1, and elem was a string that doesn't correspond to a jail name'

[rew]

skip the call to jail_getid() when listing all jailed processes.

[rew]

In D32979#744492, @debdrup wrote:

Are there other places where -(j|J) -1 is used to list all jails, instead of simply doing -(j|J)?

Not that I'm aware of either, top (next on my list) uses -J 0 (for host processes) and -J $jid (for specified jail)

I don't recall any off hand, and I would think it makes more sense to not require -1 to list all of them if it can be done without.

-J requires an argument, it would have to be a different flag. I'd prefer to stick with -J -1

[bcr]

Any updates on this one?

[pauamma_gundo.com]

Minus Dd bump, manual page LGTM. Can't speak for source code or consistency.

bin/ps/ps.1

32

Bump