- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 9 2019
Jun 7 2019
May 31 2019
May 29 2019
May 24 2019
Do not copy values into local variables
May 23 2019
Address last of kib's comments.
In D19902#438246, @jilles wrote:In D19902#437991, @hrs wrote:In D19902#437962, @jilles wrote:Perhaps it is cleaner to pass the int age to be searched for by reference. However, the asymmetry in the compare function is intentional as this allows finding an object with more data given the key, while having only one storage array.
Asymmetry of the two arguments gives more capability of data lookup? I do not see a big difference between passing an int value 22 by casting it to (void *) as in the original patch and passing a pointer to a struct person which contains age = 22, in terms of the lookup operation. Can you elaborate a case in which the symmetry arguments do not work?
The problem is not that it does not work, but that it creates a bogus value of type struct person which only contains an age. Although C's type system is unsound, I still prefer to avoid subverting it like this.
- Don't initialize locals in declaration
- Remove spaces after casts
- Remove excesive blank lines
- Revert to "asymmetric" compare function
- Add blank line before multi-line comment
- Remove return in main()
May 20 2019
Addressing most of the issues with the revision:
May 19 2019
May 18 2019
In D19902#437776, @bcr wrote:Reopen this based on comments by Konstantin and Bruce after the MFC to stable/12. @fernape: Can you look into their comments and address them in a followup patch? Thank you!
May 15 2019
Is there anything else that needs to be done?
May 12 2019
May 10 2019
Apr 27 2019
Apr 20 2019
Apr 19 2019
Apr 17 2019
Properly escape \n sequences
Apr 16 2019
Apr 15 2019
Apr 14 2019
- Eliminate cast to different size warning
- Replace comments with assertions
Apr 13 2019
Apr 9 2019
Apr 6 2019
Apr 3 2019
Apr 2 2019
Mar 25 2019
Mar 21 2019
Mar 20 2019
Mar 17 2019
Mar 13 2019
Mar 10 2019
Mar 9 2019
In D19481#417839, @tcberner wrote:Yea, looks good to me.
Thanks!
If there are no other objections, I'll go ahead and commit this one.
Mar 7 2019
- Remove CMAKE_ARGS since they are the default
- Remove LDFLAGS and modify src/CMakeLists.txt instead
- Update pkg-plist to match actual installation paths
Mar 6 2019
Add actual port to review.