While I applaud this idea for route(4)ing sockets I think that applying it broadly to other socket types has issues that need to be considered. Has this patch been brought to arch@ as yet? I think either a narrower application (just to route(4)) and then a discussion on arch(4) is appropriate for this change.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Oct 4 2020
Oct 4 2020
gnn added a comment to D22369: Add support for IPSec ESN and pass relevant information to crypto layer.
This patch contains many magic numbers 4, 8 and 32 that should either be removed by the proper use of sizeof() or turned into #defines that are named.
Oct 2 2020
Oct 2 2020
Aug 20 2020
Aug 20 2020
Aug 18 2020
Aug 18 2020
Remove dead code or give it a real name please.
Can you #define the magic number?
Aug 15 2020
Aug 15 2020
I'm happy with this change although I'd remove the code in #if 0 instead of leaving it there.
Aug 14 2020
Aug 14 2020
Approved.
Aug 12 2020
Aug 12 2020
Restore Qing Li's commit bit
Aug 11 2020
Aug 11 2020
Update my key since the previous one expired.
Jul 12 2020
Jul 12 2020
gnn accepted D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Second guessing the compiler is a fool's errand and I rather doubt you'd ever see a 50% "win" with this kind of change. That being said it makes the code more readable to my eyes and is acceptable.
Jul 1 2020
Jul 1 2020
Some minor nits. I'm happy to see this go in.
Jun 23 2020
Jun 23 2020
I'm ok with "may" so LGTM.
May 14 2020
May 14 2020
Coming back to this after a discussion with cem@ and emaste@ I think this idea still deserves some merit. It makes the resulting code easier to read, at least to my eyes and removes a somewhat confusing and error prone macro from the code base. It would be easy enough to propose the same change to the other BSDs as well.
Apr 21 2020
Apr 21 2020
Apr 16 2020
Apr 16 2020
A couple of brief comments above, but overall the patch is good and should be integrated.
Feb 5 2020
Feb 5 2020
LGTM
Feb 4 2020
Feb 4 2020
Jan 20 2020
Jan 20 2020
Add support for latest Intel I219 device, supported in Lenovo Carbon X1 v7
Aug 11 2019
Aug 11 2019
Aug 3 2019
Aug 3 2019
Properly validte arguments for route deletion
Jun 4 2019
Jun 4 2019
Add -fPIC reqiured to link this library against other libraries
May 26 2019
May 26 2019
Add missing include file to the list of things to install.
May 21 2019
May 21 2019
Thanks.
May 8 2019
May 8 2019
May 7 2019
May 7 2019
Apr 13 2019
Apr 13 2019
OK, I'm happy to work out this "trace" thing later.
Apr 11 2019
Apr 11 2019
Mar 21 2019
Mar 21 2019
Thanks for fixing this.
Jan 11 2019
Jan 11 2019
Remove, the now very outdated, timed.
Jan 9 2019
Jan 9 2019
errno.d looks good to me.
Jan 8 2019
Jan 8 2019
Jan 2 2019
Jan 2 2019
Update to release 2018-12-R1
Update to 2018-12-R1 release
Dec 15 2018
Dec 15 2018
Address issues with the latest diff.
Address Obsolete vs. OptionalObsolete issues.
Dec 14 2018
Dec 14 2018
Address recent comments by bz@, but not src.conf
Address leftover space.
Address comments from sbruno. Leave the obsolete files but remove the MK_TIMED.
Address comments from bcr@ and bz@
Dec 11 2018
Dec 11 2018
Dec 10 2018
Dec 10 2018
Dec 3 2018
Dec 3 2018
Free Vincenzo Maffione from mentorship
Nov 28 2018
Nov 28 2018
I approve the plan laid out in the comments with np@
Nov 16 2018
Nov 16 2018
Approved by: gnn@
Nov 10 2018
Nov 10 2018
Thanks. Please commit with the standard Approved by: line.
LGTM this can be committed with Approved by: gnn (mentor)
Please update the onoff variable to match how we normally express this in FreeBSD. Other than that small nit this looks fine.
Oct 31 2018
Oct 31 2018
Oct 24 2018
Oct 24 2018
Please commit with Approved by: gnn
Oct 23 2018
Oct 23 2018
LGTM. Please add the Approved by: gnn@ line to your commit.
Smoke tested in the Sentex cluster on cxl (Chelsio) hardware.
Oct 8 2018
Oct 8 2018
gnn added a reviewer for D17364: netmap: align codebase to the current upstream (commit id 8374e1a7e6941): np.
Oct 5 2018
Oct 5 2018
Add myself as co-mentor with hrs@ for Vincenzo Maffione
Oct 1 2018
Oct 1 2018
LGTM
Sep 30 2018
Sep 30 2018
LGTM
Sep 29 2018
Sep 29 2018
Free Daichi Goto from mentorship
Sep 4 2018
Sep 4 2018
Update the license allow post GPLv2
Remove an unused dependency, update to properly grab version of Python
Sep 3 2018
Sep 3 2018
Update build dependencies to track a library rather than an executable
Update dependencies to properly follow Python and libraries
Switch to the more idiomatic inclusion of Python
Attach libbtbb and ubertooth to the build
Make this port depend on its library
Ubertooth Tools for use with Ubertooth One a Bluetooth and BLE sniffer
Bluetooth Baseband Library for use by Ubertooth and others
Aug 20 2018
Aug 20 2018
gnn accepted D16204: top(1): support multibyte characters in command names (ARGV array) depending on locale.
LGTM
Aug 6 2018
Aug 6 2018
LGTM
Jul 26 2018
Jul 26 2018
Jul 15 2018
Jul 15 2018
Jul 10 2018
Jul 10 2018
Please find a ports person (I don''t commit enough ports) to review this as well please.
Jul 9 2018
Jul 9 2018
Jul 8 2018
Jul 8 2018
Jul 5 2018
Jul 5 2018
gnn accepted D16083: Changed to eliminate the upper limit of command length displayed by "-a" and expand to match terminal width.
Approved by mentor.
Jul 2 2018
Jul 2 2018
Jun 30 2018
Jun 30 2018
Jun 26 2018
Jun 26 2018
Approved.
Jun 18 2018
Jun 18 2018
May 11 2018
May 11 2018
Apr 11 2018
Apr 11 2018
Temporarily suspend Bruce Simpson's commit bit.