netmap: add man page for the vale-ctl program
ClosedPublic
Actions

Authored by vmaffione on Oct 24 2018, 9:49 AM.

Details

Reviewers

gnn
hrs
bcr

Group Reviewers

manpages

Commits

rS341432: MFC r339685
rS339685: netmap: add man page for the vale-ctl program

Summary

Added man page for vale-ctl program.
Small fixes to vale-ctl, including the support for -m option (to specify the netmap memory allocator id).

Test Plan

Man page tested with igor and mandoc -Tlint.
vale-ctl tested on local machine.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vmaffione created this revision.Oct 24 2018, 9:49 AM

Herald added a reviewer: manpages. · View Herald TranscriptOct 24 2018, 9:49 AM

Herald added a subscriber: imp. · View Herald Transcript

0mp added a subscriber: 0mp.Oct 24 2018, 2:06 PM

0mp added inline comments.

vale-ctl.c
268 ↗	(On Diff #49549)	BTW, is there a reason why the options are not in order?

vmaffione marked an inline comment as done.Oct 24 2018, 2:30 PM

vmaffione added inline comments.

vale-ctl.c
268 ↗	(On Diff #49549)	You mean alphabetical order?

0mp added inline comments.Oct 24 2018, 3:09 PM

vale-ctl.c
268 ↗	(On Diff #49549)	Yes. I guess that it is not really something to be fixed in this revision but I just wanted to ask. :)

Sure, no problems. I don't think it's a good idea to sort them alphabetically, because right now they are laid out in such a way to have semantically related operations close to each other.
For instance -d, -a and -h are detach/attach/attach-with-host, -n and -r are "create" and "remove", etc.