Page MenuHomeFreeBSD
Differential D17364

netmap: align codebase to the current upstream (commit id 8374e1a7e6941)
ClosedPublic
Actions

Authored by vmaffione on Sep 30 2018, 3:06 PM.
Tags
None
Referenced Files
F108212517: D17364.id48604.diff
Wed, Jan 22, 5:22 PM
Unknown Object (File)
Sat, Jan 18, 10:09 PM
Unknown Object (File)
Wed, Jan 8, 4:57 AM
Unknown Object (File)
Dec 5 2024, 6:01 PM
Unknown Object (File)
Nov 27 2024, 8:54 PM
Unknown Object (File)
Nov 22 2024, 4:34 PM
Unknown Object (File)
Nov 10 2024, 12:56 PM
Unknown Object (File)
Nov 4 2024, 12:34 AM
View All 98 Files
Subscribers
ae
bcr
imp

Details

Reviewers
gnn
hrs
np
Commits
rS341477: MFC r339639
rS339639: netmap: align codebase to the current upstream (sha 8374e1a7e6941)
Summary

Changelist:

  • Move large parts of VALE code to a new file and header netmap_bdg.[ch]. This is useful to reuse the code within upcoming projects.
  • Improvements and bug fixes to pipes and monitors.
  • Introduce nm_os_onattach(), nm_os_onenter() and nm_os_onexit() to handle differences between FreeBSD and Linux.
  • Introduce some new helper functions to handle more host rings and fake rings (netmap_all_rings(), netmap_real_rings(), ...)
  • Added new sysctl to enable/disable hw checksum in emulated netmap mode.
  • nm_inject: add support for NS_MOREFRAG
Test Plan

There are unit tests and integration tests for netmap, yet to be included in FreeBDS (coming soon).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vmaffione created this revision.Sep 30 2018, 3:06 PM
Herald added subscribers: ae, imp. · View Herald TranscriptSep 30 2018, 3:06 PM
bcr added a subscriber: bcr.Sep 30 2018, 6:15 PM

Found a typo.

sys/dev/netmap/netmap.c
3882 ↗(On Diff #48593)

s/adapapter/adapter/

vmaffione updated this revision to Diff 48604.Oct 1 2018, 8:20 AM
vmaffione marked 2 inline comments as done.
vmaffione added inline comments.
sys/dev/netmap/netmap.c
3882 ↗(On Diff #48593)

Thanks, I fixed it in the new version.

vmaffione marked an inline comment as done.Oct 1 2018, 9:36 AM

Integration tests and unit tests ran successfully on my test machine.

gnn added a reviewer: np.Oct 8 2018, 11:31 PM
vmaffione added a comment.Oct 22 2018, 8:38 AM

Can we commit this? Thanks

gnn accepted this revision.Oct 23 2018, 8:09 AM

Smoke tested in the Sentex cluster on cxl (Chelsio) hardware.

Please commit with:

Approved by: gnn@

This revision is now accepted and ready to land.Oct 23 2018, 8:09 AM
Closed by commit rS339639: netmap: align codebase to the current upstream (sha 8374e1a7e6941) (authored by vmaffione). · Explain WhyOct 23 2018, 8:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
conf/
1 line
dev/
netmap/
125 lines
155 lines
1827 lines
38 lines
120 lines
327 lines
12 lines
231 lines
60 lines
2172 lines
net/
2 lines
27 lines

Diff 49494

View Options

head/sys/conf/files

Loading...
View Options

head/sys/dev/netmap/netmap.c

Loading...
View Options

head/sys/dev/netmap/netmap_bdg.h

Loading...
View Options

head/sys/dev/netmap/netmap_bdg.c

Loading...
View Options

head/sys/dev/netmap/netmap_freebsd.c

Loading...
View Options

head/sys/dev/netmap/netmap_generic.c

Loading...
View Options

head/sys/dev/netmap/netmap_kern.h

Loading...
View Options

head/sys/dev/netmap/netmap_mem2.c

Loading...
View Options

head/sys/dev/netmap/netmap_monitor.c

Loading...
View Options

head/sys/dev/netmap/netmap_pipe.c

Loading...
View Options

head/sys/dev/netmap/netmap_vale.c

Loading...
View Options

head/sys/net/netmap.h

Loading...
View Options

head/sys/net/netmap_user.h

Loading...