Differential D17364

netmap: align codebase to the current upstream (commit id 8374e1a7e6941)
ClosedPublic
Actions

Authored by vmaffione on Sep 30 2018, 3:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 8:28 PM

	Unknown Object (File)
	Mon, Apr 8, 9:30 PM

	Unknown Object (File)
	Mar 18 2024, 3:27 PM

	Unknown Object (File)
	Feb 3 2024, 2:42 AM

	Unknown Object (File)
	Feb 2 2024, 10:44 PM

	Unknown Object (File)
	Feb 1 2024, 7:55 AM

	Unknown Object (File)
	Dec 20 2023, 5:46 AM

	Unknown Object (File)
	Dec 13 2023, 3:55 PM

View All 47 Files

Subscribers

Details

Reviewers

gnn
hrs
np

Commits

rS341477: MFC r339639
rS339639: netmap: align codebase to the current upstream (sha 8374e1a7e6941)

Summary

Changelist:

Move large parts of VALE code to a new file and header netmap_bdg.[ch]. This is useful to reuse the code within upcoming projects.
Improvements and bug fixes to pipes and monitors.
Introduce nm_os_onattach(), nm_os_onenter() and nm_os_onexit() to handle differences between FreeBSD and Linux.
Introduce some new helper functions to handle more host rings and fake rings (netmap_all_rings(), netmap_real_rings(), ...)
Added new sysctl to enable/disable hw checksum in emulated netmap mode.
nm_inject: add support for NS_MOREFRAG

Test Plan

There are unit tests and integration tests for netmap, yet to be included in FreeBDS (coming soon).

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vmaffione created this revision.Sep 30 2018, 3:06 PM

Herald added subscribers: ae, imp. · View Herald TranscriptSep 30 2018, 3:06 PM

Found a typo.

sys/dev/netmap/netmap.c
3882	s/adapapter/adapter/

vmaffione updated this revision to Diff 48604.Oct 1 2018, 8:20 AM

vmaffione marked 2 inline comments as done.

vmaffione added inline comments.

sys/dev/netmap/netmap.c
3882	Thanks, I fixed it in the new version.

Integration tests and unit tests ran successfully on my test machine.

gnn added a reviewer: np.Oct 8 2018, 11:31 PM

Can we commit this? Thanks

Smoke tested in the Sentex cluster on cxl (Chelsio) hardware.

Please commit with:

Approved by: gnn@

This revision is now accepted and ready to land.Oct 23 2018, 8:09 AM

Closed by commit rS339639: netmap: align codebase to the current upstream (sha 8374e1a7e6941) (authored by vmaffione). · Explain WhyOct 23 2018, 8:55 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

conf/

1 line

dev/

netmap/

125 lines

126 lines

1827 lines

netmap_freebsd.c

38 lines

netmap_generic.c

120 lines

327 lines

12 lines

netmap_monitor.c

231 lines

60 lines

2172 lines

net/

2 lines

27 lines

Diff 48604

sys/conf/files

Loading...

sys/dev/netmap/netmap.c

Loading...

sys/dev/netmap/netmap_bdg.h

Loading...

sys/dev/netmap/netmap_bdg.c

Loading...

sys/dev/netmap/netmap_freebsd.c

Loading...

sys/dev/netmap/netmap_generic.c

Loading...

sys/dev/netmap/netmap_kern.h

Loading...

sys/dev/netmap/netmap_mem2.c

Loading...

sys/dev/netmap/netmap_monitor.c

Loading...

sys/dev/netmap/netmap_pipe.c

Loading...

sys/dev/netmap/netmap_vale.c

Loading...

sys/net/netmap.h

Loading...

sys/net/netmap_user.h

Loading...