Changed to eliminate the upper limit of command length displayed by "-a" and expand to match terminal width

[daichi]

Summary

Changed to eliminate the upper limit of command length displayed by "-a" and expand to match terminal width

Test Plan

on A terminal:

% touch 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
% cat - 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789

on B terminal:

% top -a -d 1

result:

original top:
% top -a -d 1 | grep cat
  879 daichi        1  20    0   11M    3M piperd   1   0:00   0.00% grep cat
  852 daichi        1  20    0   11M    2M ttyin    1   0:00   0.00% [cat]
%

patched top (terminal width is 80):
% top -a -d 1 | grep cat
 9835 daichi        1  20    0   11M    3M piperd   0   0:00   0.00% grep cat
 9830 daichi        1  20    0   11M    2M ttyin    1   0:00   0.00% cat - 0123
%

patched top (terminal width is 512):
% top -a -d 1 | grep cat
 9860 daichi        1  20    0   11M    3M piperd   0   0:00   0.00% grep cat
 9830 daichi        1  20    0   11M    2M ttyin    1   0:00   0.00% cat - 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 01234567890123456789012345678901
%

patched top (terminal width is 1128):
% top -a -d 1 | grep cat
 9862 daichi        1  20    0   11M    3M piperd   1   0:00   0.00% grep cat
 9830 daichi        1  20    0   11M    2M ttyin    1   0:00   0.00% cat - 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 012345678901234567890123456789012345678901
%

[gnn]

usr.bin/top/machine.c

874 ↗

(On Diff #44710)

Where does screen_width come from?

[eadler]

I'd like to move away from using static sizes and limits. This is fine as a stop-gap, but please consider changes that remove such static sizes.

[daichi]

Follow Eadler's advice and abolish static value. However, it is still in the early stage. More testing is necessary. Please test it.

[daichi]

Part of the patch overlapped with kib's committed patch (https://svnweb.freebsd.org/base?view=revision&revision=335937, https://reviews.freebsd.org/D16111), so I updated the patch.

[eadler]

usr.bin/top/display.c

333 ↗

(On Diff #44882)

can this be a function instead of a macro?

336 ↗

(On Diff #44882)

Why do the multiplication, and then use ,1? when using calloc? Use the args as intended :)

342 ↗

(On Diff #44882)

ditto

usr.bin/top/machine.c

873 ↗

(On Diff #44882)

remove cmdlen and just use screen_width directly.

[daichi]

It corresponded to Eitan's advice.

[gnn]

Approved by mentor.

[eadler]

I'll probably spend some time to sbufize this, but this change is good for now.