Fix the UDP tests

[tuexen]

Summary

Both UDP tests require ping to be able to send UDP packets, which is supported on Solaris but not on FreeBSD. So use a perl scripts instead.

Change the shebang to allow finding the shell outside of /usr/bin, which is the case on FreeBSD, where the shell lives in /usr/local/bin.

The remote test relies on a feature avaliable in ksh93, so use that shell instead.

I could change the extension of the remote test to .ksh93 and extend dtrace.sh to support it. Just let me know, if this is preferred.

We keep the remote test disabled, since it requires other machines to exists on the LAN. This is not always the case...

Test Plan

Run the test scripts. They should pass...

[markj]

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv4localudp.ksh

61 ↗

(On Diff #45281)

We should keep the file in /tmp rather than the current directory. It should also get cleaned up.

61 ↗

(On Diff #45281)

If you quote the EOF indicator, the shell won't perform substitutions and so you don't need to escape '$' in the script.

That is, you can write:

cat > test.pl <<'EOPERL'
...
my $s = ...
...

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv4remoteudp.ksh

64 ↗

(On Diff #45281)

Same comments as above.

[tuexen]

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv4localudp.ksh

61 ↗

(On Diff #45281)

Right, will put it in a tmp dir like the other tests. I missed that.

61 ↗

(On Diff #45281)

Regarding the quoting. I can do that, but the other scripts in this dir do it like this one... I just cloned that code (this is actually the first line or perl I wrote...).
Do you want your change or have the code consistent with the rest?

[tuexen]

Put script file in temp directory and clean it up finally.

[tuexen]

Added back Makefile change missed in last diff

[tuexen]

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv4localudp.ksh

61 ↗

(On Diff #45281)

I can't quote the EOF delimiter, because then no substitution is done in the here-document.

To be explicit:

Without quoting the EOF delimiter, test.pl contains:

use IO::Socket;
my $s = IO::Socket::INET->new(
    Proto => "udp",
    PeerAddr => "127.0.0.1",
    PeerPort => 33434);
die "Could not create UDP socket 127.0.0.1 port 33434" unless $s;
send $s, "Hello", 0;
close $s;
sleep(2);

which is correct.

However, when quoting the EOF character, test.pl reads:

use IO::Socket;
my $s = IO::Socket::INET->new(
    Proto => "udp",
    PeerAddr => "$local",
    PeerPort => $port);
die "Could not create UDP socket $local port $port" unless $s;
send $s, "Hello", 0;
close $s;
sleep(2);

which does not correct. This script does not work.

So I guess being consistent is a good thing here.

[markj]

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv4localudp.ksh

61 ↗

(On Diff #45281)

Oops, I missed that. Looks fine to me then.

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv4remoteudp.ksh

112 ↗

(On Diff #45293)

Don't we want to exit $status?

[tuexen]

Return the error code which is intended.

[tuexen]

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv4remoteudp.ksh

112 ↗

(On Diff #45293)

Sure we do... I just copied the code from tst.ipv4remotetcp.ksh, the only file in this directory which has this bug, Thanks for catching it.

[tuexen]

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv4remoteudp.ksh

112 ↗

(On Diff #45293)

I fixed the bug in tst.ipv4remotetcp.ksh in r336293.