net80211: improve media information for VHT5GHZ
ClosedPublic
Actions

Authored by bz on Aug 17 2020, 5:25 PM.

Details

Reviewers

adrian
gnn

Group Reviewers

wireless

Commits

rS364553: net80211: improve media information for VHT5GHZ

Summary

Improve ieee80211_media_setup(), media2mode(), and
ieee80211_rate2media() for VHT5GHZ at least.

MFC After: 2 weeks
Reviewed by: ..
Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

bz created this revision.Aug 17 2020, 5:25 PM

bz requested review of this revision.Aug 17 2020, 5:25 PM

Remove dead code or give it a real name please.

sys/net80211/ieee80211.c
2404 ↗	(On Diff #75901)	Can we give the #if something that allows someone to actually build this into their kernel? If it should not be here at all maybe remove the code?

This revision now requires changes to proceed.Aug 18 2020, 9:15 PM

bz added inline comments.Aug 19 2020, 2:59 PM

sys/net80211/ieee80211.c
2404 ↗	(On Diff #75901)	I can change it into #ifdef _notyet__ if that is better. I consider it as "documentation" until we actually support HW in the tree which does this and it can be tested but also if someone goes and looks for it it'll be there at least (like @adrian had done for the VHT2GHZ just that it's just splattered in a few places and not finished either). I just don't want to enable to code until we support/use it.