Page MenuHomeFreeBSD

net80211: improve media information for VHT5GHZ
ClosedPublic

Authored by bz on Aug 17 2020, 5:25 PM.

Details

Summary

Improve ieee80211_media_setup(), media2mode(), and
ieee80211_rate2media() for VHT5GHZ at least.

MFC After: 2 weeks
Reviewed by: ..
Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bz requested review of this revision.Aug 17 2020, 5:25 PM
gnn requested changes to this revision.Aug 18 2020, 9:15 PM

Remove dead code or give it a real name please.

sys/net80211/ieee80211.c
2404 ↗(On Diff #75901)

Can we give the #if something that allows someone to actually build this into their kernel? If it should not be here at all maybe remove the code?

This revision now requires changes to proceed.Aug 18 2020, 9:15 PM
sys/net80211/ieee80211.c
2404 ↗(On Diff #75901)

I can change it into #ifdef _notyet__ if that is better.
I consider it as "documentation" until we actually support HW in the tree which does this and it can be tested but also if someone goes and looks for it it'll be there at least (like @adrian had done for the VHT2GHZ just that it's just splattered in a few places and not finished either). I just don't want to enable to code until we support/use it.

Any further comments? I'd love to commit this Monday morning UTC.

This revision is now accepted and ready to land.Aug 20 2020, 11:13 PM
This revision was automatically updated to reflect the committed changes.