imp retitled D20788: implement nvmecontrol passthru commands compatible (mostly) with linux nvme-cli from rework to include descriptions and arg info to implement nvmecontrol passthru commands compatible (mostly) with linux nvme-cli.

Jul 15 2019, 4:21 PM

imp added a comment to D20831: Implement the following ivars: MMCBR_IVAR_RETUNE_REQ MMCBR_IVAR_VCCQ MMCBR_IVAR_TIMING MMCBR_IVAR_MAX_BUSY_TIMEOUT.

fixed in a different way.

Jul 15 2019, 4:20 PM

imp added inline comments to D20950: Implement a devtype command..

Jul 15 2019, 4:19 PM

imp committed rS350000: Remove RELEASE_CRUNCH here. It's obsolete..

Remove RELEASE_CRUNCH here. It's obsolete.

Jul 15 2019, 3:02 PM

imp committed rS349997: Replace complicated expression to disable libedit when no libthr is being built.

Replace complicated expression to disable libedit when no libthr is being built

Jul 15 2019, 2:23 PM

imp committed rS349996: Remove all the RELEASE_CRUNCH instances that partially disable IPSEC.

Remove all the RELEASE_CRUNCH instances that partially disable IPSEC

Jul 15 2019, 2:19 PM

imp committed rS349991: MK_OPENSSL makes RELEASE_CRUNCH redundant here.

MK_OPENSSL makes RELEASE_CRUNCH redundant here

Jul 15 2019, 7:39 AM

imp committed rS349990: Now that we have MK_LS_COLORS, we don't need RELEASE_CRUNCH check here..

Now that we have MK_LS_COLORS, we don't need RELEASE_CRUNCH check here.

Jul 15 2019, 7:36 AM

imp added reviewers for D20950: Implement a devtype command.: ken, scottl, mav.

Jul 15 2019, 6:26 AM

imp created D20950: Implement a devtype command..

Jul 15 2019, 6:26 AM

Jul 14 2019

imp added inline comments to D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.

Jul 14 2019, 1:29 AM · PowerPC

imp added inline comments to D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.

Jul 14 2019, 1:24 AM · PowerPC

Jul 13 2019

imp committed rS349964: Add device type NVME and device type MMCSD to get_device_type.

Add device type NVME and device type MMCSD to get_device_type

Jul 13 2019, 3:22 AM

Jul 12 2019

D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm now requires changes to proceed.

Jul 12 2019, 4:01 PM · PowerPC

imp committed rS349938: Retire the -DRELEASE_CRUNCH define..

Retire the -DRELEASE_CRUNCH define.

Jul 12 2019, 6:19 AM

imp committed rS349936: Retire support for -DMINIMALISTIC.

Retire support for -DMINIMALISTIC

Jul 12 2019, 5:35 AM

imp committed rS349934: There is no SMALLER define anymore here.

There is no SMALLER define anymore here

Jul 12 2019, 5:19 AM

imp committed rS349933: Remove unused defines since r147075.

Remove unused defines since r147075

Jul 12 2019, 4:45 AM

Jul 11 2019

D20811: Allow efi loader to get network params from uboot is now accepted and ready to land.

I'm happy with this now.

Jul 11 2019, 4:56 PM

imp committed rS349909: More fully implement the state machine..

More fully implement the state machine.

Jul 11 2019, 6:22 AM

Jul 10 2019

imp closed D20910: Enforce a 4GB DMA boundary on isci(4).

Jul 10 2019, 10:24 PM

imp committed rS349895: Enforce a 4GB DMA boundary on isci(4).

Enforce a 4GB DMA boundary on isci(4)

Jul 10 2019, 10:24 PM

imp added a reviewer for D20910: Enforce a 4GB DMA boundary on isci(4): jhb.

Jul 10 2019, 10:21 PM

imp created D20910: Enforce a 4GB DMA boundary on isci(4).

Jul 10 2019, 10:20 PM

imp committed rS349889: Fix compile errors with the CI20.

Fix compile errors with the CI20

Jul 10 2019, 5:22 PM

imp added a comment to D20811: Allow efi loader to get network params from uboot.

I agree with kevans' style nits, but this is looking a lot better. I'd see where servip is used better now.

Jul 10 2019, 4:33 PM

imp added inline comments to D19047: TCP Dynamic Burst Limit.

Jul 10 2019, 3:34 PM

Jul 9 2019

imp committed rS349864: Refine the advice for upgrading from 10.x.

Refine the advice for upgrading from 10.x

Jul 9 2019, 6:33 PM

Jul 8 2019

imp added a comment to D20788: implement nvmecontrol passthru commands compatible (mostly) with linux nvme-cli.

Tweaks to license / years

Jul 8 2019, 8:58 PM

imp added a comment to D20788: implement nvmecontrol passthru commands compatible (mostly) with linux nvme-cli.

rebase + spelling nit

Jul 8 2019, 8:56 PM

imp committed rS349849: Fix bugs in recovery path and improve cm tracking.

Fix bugs in recovery path and improve cm tracking

Jul 8 2019, 8:20 PM

imp closed D20785: Fix bugs in recovery path and improve cm tracking.

Jul 8 2019, 8:20 PM

D20880: Fix gcc build for superio(4) is now accepted and ready to land.

thanks!

Jul 8 2019, 7:46 PM

imp committed rS349845: Work around devices which return all zeros for reads of existing MSI-X.

Work around devices which return all zeros for reads of existing MSI-X

Jul 8 2019, 7:39 PM

imp closed D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word..

Jul 8 2019, 7:39 PM

imp added inline comments to D20880: Fix gcc build for superio(4).

Jul 8 2019, 6:03 PM

imp added a comment to D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word..

Ah, the PCI vs PCIe specs.

Jul 8 2019, 5:43 PM

imp added a comment to D20874: bhyve: add missing license identifiers in net_utils and net_backend.

I'd be tempted to do this as two different commits: one for ctypes.h and one for the SPDX. I agree with the comments about placement of ctypes.h.

Jul 8 2019, 5:15 PM

imp added inline comments to D20880: Fix gcc build for superio(4).

Jul 8 2019, 5:06 PM

imp committed rS349837: Add note about upgrading from RELENG_10..

Add note about upgrading from RELENG_10.

Jul 8 2019, 3:41 PM

Jul 7 2019

imp added a comment to D20876: Limit access to system accounting files.

I like these changes.
I had a minor gut reactions that the mode should be settable, but then realized no, it shouldn't.
But what's the group the file gets created as? Or is that adequately covered with the sticky bit in /var/account that we don't mess with that the system manager sets up?

Jul 7 2019, 6:07 PM

D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word. is now accepted and ready to land.

Subject to the one comment above, I like it and think it should go in

Jul 7 2019, 4:41 PM

imp added a comment to D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word..

Reading through the standard just now, this change looks good, provided we never use the ST Table Location value of 10b (device specific mode, table 6-12 in the 3.0 standard). If we do, then the upper 16 bits are the ST values and need to be preserved.

Jul 7 2019, 2:25 PM

Jul 5 2019

imp closed D16312: Remove Atmel AT91RM9200 and AT91SAM9 support..

Jul 5 2019, 9:01 PM

Herald added a reviewer for D20745: Remove NAND and NANDFS support: manpages.

Jul 5 2019, 8:43 PM

Jul 4 2019

imp committed rS349731: Fix cut-and-pasto that slipped through my testing..

Fix cut-and-pasto that slipped through my testing.

Jul 4 2019, 3:10 PM

imp committed rS349728: Implement missing MMCBR ivars.

Implement missing MMCBR ivars

Jul 4 2019, 2:15 PM

Jul 3 2019

imp added inline comments to D20811: Allow efi loader to get network params from uboot.

Jul 3 2019, 5:23 PM

Jul 1 2019

D20520: Normalize deployment tools usage and definitions now requires changes to proceed.

Please make the change that bapt suggested.

Jul 1 2019, 11:36 PM

imp added a comment to D20520: Normalize deployment tools usage and definitions.

I need to think through the sys.mk change, and I've got no time today to do that. I'll try to articulate something coherent (one way or the other) by the end of the day tomorrow since I know what I've said so far isn't actionable.

Jul 1 2019, 9:48 PM

imp created D20831: Implement the following ivars: MMCBR_IVAR_RETUNE_REQ MMCBR_IVAR_VCCQ MMCBR_IVAR_TIMING MMCBR_IVAR_MAX_BUSY_TIMEOUT.

Jul 1 2019, 9:30 PM

Jun 30 2019

imp added a comment to D20811: Allow efi loader to get network params from uboot.

can you re-upload the diff -U9999 please? It will make it easier to review.
I like the general direction, but want to look at it more closely.

Jun 30 2019, 6:32 PM

Jun 28 2019

imp added inline comments to D20785: Fix bugs in recovery path and improve cm tracking.

Jun 28 2019, 3:57 PM

imp retitled D20785: Fix bugs in recovery path and improve cm tracking from Grab bag of "fixes" for mps issue to Fix bugs in recovery path and improve cm tracking.

Jun 28 2019, 3:55 PM

imp added a comment to D20785: Fix bugs in recovery path and improve cm tracking.

Cleaned up

Jun 28 2019, 3:55 PM

imp added a comment to D20785: Fix bugs in recovery path and improve cm tracking.

Here's a slightly better debug run, with printing of the cm address:

mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe03150916c0 sc 0xfffffe0069f13000
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315091818 sc 0xfffffe0069f13000 [****]
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315091970 sc 0xfffffe0069f13000 [****]
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315091ac8 sc 0xfffffe0069f13000 [****]
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315091c20 sc 0xfffffe0069f13000 [****]
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe03150922d8 sc 0xfffffe0069f13000 [****]
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315092430 sc 0xfffffe0069f13000 [****]
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
run_interrupt_driven_hooks: still waiting after 60 seconds for xpt_config
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315092588 sc 0xfffffe0069f13000 [****]
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe03150926e0 sc 0xfffffe0069f13000 [****]
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315092838 sc 0xfffffe0069f13000 [****]
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_add_device: sending Target Reset for stuck SATA identify command (cm = 0xfffffe03150916c0)
mps2: Sending target reset to target 0
mps2: Bad state for ADDRESS_REPLY status, ignoring state 0 cm 0xfffffe03150916c0
mps2: mpssas_action_scsiio: Freezing devq for target ID 0
(probe0:mps2:0:0:0): INQUIRY. CDB: 12 00 00 00 24 00
(probe0:mps2:0:0:0): CAM status: CAM subsystem is busy
(probe0:mps2:0:0:0): Retrying command, 3 more tries remain
mps2: Bad state for ADDRESS_REPLY status, ignoring state 0 cm 0xfffffe0315092838
mps2: Bad state for ADDRESS_REPLY status, ignoring state 0 cm 0xfffffe03150926e0
mps2: Bad state for ADDRESS_REPLY status, ignoring state 0 cm 0xfffffe0315092588
mps2: Bad state for ADDRESS_REPLY status, ignoring state 0 cm 0xfffffe0315092430
mps2: Bad state for ADDRESS_REPLY status, ignoring state 0 cm 0xfffffe03150922d8
mps2: Bad state for ADDRESS_REPLY status, ignoring state 0 cm 0xfffffe0315091c20
mps2: Bad state for ADDRESS_REPLY status, ignoring state 0 cm 0xfffffe0315091ac8
mps2: Bad state for ADDRESS_REPLY status, ignoring state 0 cm 0xfffffe0315091970
mps2: Bad state for ADDRESS_REPLY status, ignoring state 0 cm 0xfffffe0315091818
mps2: target reset status 0x0 code 0x0 count 9
mps2: Finished reset recovery for target 0
mps2: Unfreezing devq for target ID 0

All the Bad States CMs are marked with [****] in the retry output.

Jun 28 2019, 3:25 PM

imp added a comment to D20785: Fix bugs in recovery path and improve cm tracking.

So we get 10 timeouts and have 9 cm's in the free state. We have to do the Target Reset after these timeouts. Unsure why the mismatch, unless the commands complete 'eventually' because we didn't properly cancel them and that's what's causing the issue? Unsure.

Jun 28 2019, 12:29 AM

imp added a comment to D20785: Fix bugs in recovery path and improve cm tracking.

Here's the boot log from a machine that now survives.

mps0: <Avago Technologies (LSI) SAS2008> port 0xe000-0xe0ff mem 0xfb900000-0xfb903fff,0xfb880000-0xfb8bffff irq 26 at device 0.0 on pci1
mps0: Firmware: 15.00.00.00, Driver: 21.02.00.00-fbsd
mps0: IOCCapabilities: 1285c<ScsiTaskFull,DiagTrace,SnapBuf,EEDP,TransRetry,EventReplay,HostDisc>
...
mps1: <Avago Technologies (LSI) SAS2008> port 0xd000-0xd0ff mem 0xfb300000-0xfb303fff,0xfb280000-0xfb2bffff irq 34 at device 0.0 on pci3
mps1: Firmware: 15.00.00.00, Driver: 21.02.00.00-fbsd
mps1: IOCCapabilities: 1285c<ScsiTaskFull,DiagTrace,SnapBuf,EEDP,TransRetry,EventReplay,HostDisc>
...
mps2: <Avago Technologies (LSI) SAS2008> port 0xc000-0xc0ff mem 0xfad00000-0xfad03fff,0xfac80000-0xfacbffff irq 40 at device 0.0 on pci4
mps2: Firmware: 15.00.00.00, Driver: 21.02.00.00-fbsd
mps2: IOCCapabilities: 1285c<ScsiTaskFull,DiagTrace,SnapBuf,EEDP,TransRetry,EventReplay,HostDisc>
...
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe03150916c0 sc 0xfffffe0069f13000
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315091818 sc 0xfffffe0069f13000
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315091970 sc 0xfffffe0069f13000
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315091ac8 sc 0xfffffe0069f13000
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315091c20 sc 0xfffffe0069f13000
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe03150922d8 sc 0xfffffe0069f13000
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315092430 sc 0xfffffe0069f13000
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
run_interrupt_driven_hooks: still waiting after 60 seconds for xpt_config
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315092588 sc 0xfffffe0069f13000
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe03150926e0 sc 0xfffffe0069f13000
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_ata_id_timeout ATA ID command timeout cm 0xfffffe0315092838 sc 0xfffffe0069f13000
ata_id_timeout: state is 3
mps2: Request for SATA PASSTHROUGH page completed with error 60
mps2: Sleeping 3 seconds after SATA ID error to wait for spinup
mps2: mpssas_add_device: sending Target Reset for stuck SATA identify command (cm = 0xfffffe03150916c0)
mps2: Sending target reset to target 0
Free state for ADDRESS_REPLY status, ignoring
mps2: mpssas_action_scsiio: Freezing devq for target ID 0
(probe0:mps2:0:0:0): INQUIRY. CDB: 12 00 00 00 24 00
(probe0:mps2:0:0:0): CAM status: CAM subsystem is busy
(probe0:mps2:0:0:0): Retrying command, 3 more tries remain
Free state for ADDRESS_REPLY status, ignoring
Free state for ADDRESS_REPLY status, ignoring
Free state for ADDRESS_REPLY status, ignoring
Free state for ADDRESS_REPLY status, ignoring
Free state for ADDRESS_REPLY status, ignoring
Free state for ADDRESS_REPLY status, ignoring
Free state for ADDRESS_REPLY status, ignoring
Free state for ADDRESS_REPLY status, ignoring
Free state for ADDRESS_REPLY status, ignoring
mps2: target reset status 0x0 code 0x0 count 9
mps2: Finished reset recovery for target 0
mps2: Unfreezing devq for target ID 0
mps2: Controller reported scsi ioc terminated tgt 0 SMID 269 loginfo 31111000
(probe0:mps2:0:0:0): INQUIRY. CDB: 12 00 00 00 24 00
(probe0:mps2:0:0:0): CAM status: CCB request completed with an error
(probe0:mps2:0:0:0): Retrying command, 2 more tries remain
run_interrupt_driven_hooks: still waiting after 120 seconds for xpt_config
mps2: Controller reported scsi ioc terminated tgt 0 SMID 270 loginfo 31111000
(probe0:mps2:0:0:0): INQUIRY. CDB: 12 00 00 00 24 00
(probe0:mps2:0:0:0): CAM status: CCB request completed with an error
(probe0:mps2:0:0:0): Retrying command, 1 more tries remain
run_interrupt_driven_hooks: still waiting after 180 seconds for xpt_config
mps2: Controller reported scsi ioc terminated tgt 0 SMID 271 loginfo 31111000
(probe0:mps2:0:0:0): INQUIRY. CDB: 12 00 00 00 24 00
(probe0:mps2:0:0:0): CAM status: CCB request completed with an error
(probe0:mps2:0:0:0): Retrying command, 0 more tries remain
mps2: Controller reported scsi ioc terminated tgt 0 SMID 272 loginfo 31111000
(probe0:mps2:0:0:0): INQUIRY. CDB: 12 00 00 00 24 00
(probe0:mps2:0:0:0): CAM status: CCB request completed with an error
(probe0:mps2:0:0:0): Error 5, Retries exhausted
da2 at mps0 bus 0 scbus7 target 1 lun 0
da2: <ATA HGST HUS726060AL T1E2> Fixed Direct Access SPC-4 SCSI device
da2: Serial Number AR31001EV1AVUC
da2: 600.000MB/s transfers
da2: Command Queueing enabled
da2: 5723166MB (11721045168 512 byte sectors)
da1 at mps0 bus 0 scbus7 target 0 lun 0
da1: <ATA HGST HUS726060AL T1E2> Fixed Direct Access SPC-4 SCSI device
da1: Serial Number AR31001EV1A8YC
da1: 600.000MB/s transfers
da1: Command Queueing enabled
da1: 5723166MB (11721045168 512 byte sectors)
...

Jun 28 2019, 12:26 AM

Jun 27 2019

imp added a comment to D18705: efibootmgr: make generic usage message more readable.

https://reviews.freebsd.org/D20788 is a much better way to go...

Jun 27 2019, 11:11 PM

imp created D20788: implement nvmecontrol passthru commands compatible (mostly) with linux nvme-cli.

Jun 27 2019, 11:11 PM

imp added a comment to D20785: Fix bugs in recovery path and improve cm tracking.

There's three fixes here: one is to remove TIMEDOUT as a state and moves it to a couple of bits
one is to only remove the cm from the deferred list when its been inserted
and one is to fix the race that I called out separately.

Jun 27 2019, 10:31 PM

imp created D20785: Fix bugs in recovery path and improve cm tracking.

Jun 27 2019, 10:28 PM

imp added a comment to D20511: Expose build-ID through `uname -b`.

OK. that works for me. thanks for the answer.

Jun 27 2019, 8:30 PM

imp added a comment to D20511: Expose build-ID through `uname -b`.

Looks good. What do we do if we can't get the string?

Jun 27 2019, 8:26 PM

Jun 26 2019

imp added inline comments to D20773: stand: shuffle dv_open/dv_init bits around.

Jun 26 2019, 9:53 PM

imp added inline comments to D20773: stand: shuffle dv_open/dv_init bits around.

Jun 26 2019, 6:28 PM

imp added a comment to D20394: Ports Tree Base Packages.

In D20394#449248, @kmoore wrote:
In D20394#449200, @adamw wrote:
So, I'm just going to throw this out here. This is just a neat feature of the ports tree that the src framework might choose to leverage.

Many src OPTIONS will necessarily depend upon each other. For instance, enabling ZFS but not CDDL will (afaik) not produce working zfs. Similarly, TELNET without INET will not produce a working telnet. I know that there are a great number of options here, and that this would add some complexity, but it might save some users from shooting themselves in the foot.

We have a syntax that specifies that one option requires another, or that enabling one option should prevent another option from being enabled.
ZFS_IMPLIES=         CDDL
SENDMAIL_IMPLIES=    MAIL MAILWRAPPER INET
Here, if SENDMAIL is enabled, once the options form is submitted, MAIL, MAILWRAPPER, and INET will be automatically enabled.
SENDMAIL_PREVENTS=    RATIONAL_THOUGHT
Here, if SENDMAIL and RATIONAL_THOUGHT are both enabled when the options form is submitted, the build will die with a (configurable) error explaining that those options are incompatible.
@adamw

Yes, this is something really nice about the ports framework. We started with a more basic list of options, so you can run 'make config' and select your knobs at will. But we've anticipated going back and figuring out the groupings and conflicts between the options and setting those as well. We can see there being a lot of users who appreciate being able to see what options are available via the dialog menus, but also have that guidance on which ones are safe to set/unset as they build a custom kernel/userland or whatever.

Jun 26 2019, 3:16 PM

imp added a comment to D20458: first step towards enforcing must-succeed semantics for bus accessors.

I'm not sure I see the need for _system.h, at least for this. sys/bus.h isn't a standards defined thing, so name space pollution is not an issue, right?

Jun 26 2019, 3:09 PM