Page MenuHomeFreeBSD

bhyve: add missing license identifiers in net_utils and net_backend
ClosedPublic

Authored by vmaffione on Jul 7 2019, 12:27 PM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vmaffione created this revision.Jul 7 2019, 12:27 PM
markj added a subscriber: markj.Jul 7 2019, 2:30 PM
markj added inline comments.
usr.sbin/bhyve/net_backends.c
41 ↗(On Diff #59504)

The cdefs.h include should become the first include in this file.

jhb added inline comments.Jul 8 2019, 4:32 PM
usr.sbin/bhyve/net_backends.c
41 ↗(On Diff #59504)

Yes, the normal style is to place <sys/cdefs.h> and __FBSDID followed by a blank line before all other #includes.

imp added a comment.Jul 8 2019, 5:15 PM

I'd be tempted to do this as two different commits: one for ctypes.h and one for the SPDX. I agree with the comments about placement of ctypes.h.

Also, in the future, it would be more convenient for reviewers if you uploaded patches generated with -U99999 so we get the full context and don't have to switch away to another window for see if these files actually have the specific wording of the BSD-2-Clause-FreeBSD license or not.

vmaffione updated this revision to Diff 59554.Jul 8 2019, 9:13 PM

Changed the patch to update the license identifiers only.

jhb accepted this revision.Jul 8 2019, 9:38 PM
This revision is now accepted and ready to land.Jul 8 2019, 9:38 PM