Details
Details
- Reviewers
tychon jhb - Group Reviewers
bhyve - Commits
- rS350195: MFC r349867
rS349867: bhyve: add missing license identifiers in net_utils and net_backend
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 25229
Event Timeline
usr.sbin/bhyve/net_backends.c | ||
---|---|---|
41 | The cdefs.h include should become the first include in this file. |
usr.sbin/bhyve/net_backends.c | ||
---|---|---|
41 | Yes, the normal style is to place <sys/cdefs.h> and __FBSDID followed by a blank line before all other #includes. |
Comment Actions
I'd be tempted to do this as two different commits: one for ctypes.h and one for the SPDX. I agree with the comments about placement of ctypes.h.
Also, in the future, it would be more convenient for reviewers if you uploaded patches generated with -U99999 so we get the full context and don't have to switch away to another window for see if these files actually have the specific wording of the BSD-2-Clause-FreeBSD license or not.