Differential D20874

bhyve: add missing license identifiers in net_utils and net_backend
ClosedPublic
Actions

Authored by vmaffione on Jul 7 2019, 12:27 PM.

Details

Reviewers

tychon
jhb

Group Reviewers

bhyve

Commits

rS350195: MFC r349867
rS349867: bhyve: add missing license identifiers in net_utils and net_backend

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vmaffione created this revision.Jul 7 2019, 12:27 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJul 7 2019, 12:27 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

Harbormaster completed remote builds in B25229: Diff 59504.Jul 7 2019, 12:27 PM

markj added a subscriber: markj.Jul 7 2019, 2:30 PM

markj added inline comments.

usr.sbin/bhyve/net_backends.c
41	The cdefs.h include should become the first include in this file.

jhb added inline comments.Jul 8 2019, 4:32 PM

usr.sbin/bhyve/net_backends.c
41	Yes, the normal style is to place <sys/cdefs.h> and __FBSDID followed by a blank line before all other #includes.

I'd be tempted to do this as two different commits: one for ctypes.h and one for the SPDX. I agree with the comments about placement of ctypes.h.

Also, in the future, it would be more convenient for reviewers if you uploaded patches generated with -U99999 so we get the full context and don't have to switch away to another window for see if these files actually have the specific wording of the BSD-2-Clause-FreeBSD license or not.

Changed the patch to update the license identifiers only.

vmaffione mentioned this in D20883: bhyve: net_backends.c: add missing __FBSDID.Jul 8 2019, 9:23 PM

jhb accepted this revision.Jul 8 2019, 9:38 PM

This revision is now accepted and ready to land.Jul 8 2019, 9:38 PM

Closed by commit rS349867: bhyve: add missing license identifiers in net_utils and net_backend (authored by vmaffione). · Explain WhyJul 9 2019, 10:04 PM

This revision was automatically updated to reflect the committed changes.

vmaffione added a commit: rS349867: bhyve: add missing license identifiers in net_utils and net_backend.

vmaffione added a commit: rS350195: MFC r349867.Jul 21 2019, 11:27 AM