Fix errant newline

Wordsmith the sentente to match behaviour described in r318443

Here's a few nits I noticed.

Welp, I screwed up.

Fix a tiny issue about characters not being allowed in /bin/sh

At the request of @allanjude, I'm commandeering this to make a little change so that sysrc doesn't try to operate on files it can't work on.

Comma use looks good to me.

Well, an actual doc persons opinion is more valuable than mine, so I defer :)

I'm not completely sure about .It Va, but the Va macro is not documented in mandoc(7) and only appears in some openbsd mandoc.samples man-page which doesn't seem to be connected to their or our build, where it's referenced as a variable.
.Ql also isn't documented in mandoc(7), however it's a quoted literal according to groff_mdoc(7) from textproc/groff, so I think it's fine.

Fix .Dd nit and nc path nit.

Add comment explaining what the example achieves, add nc(1) to SEE ALSO section

Use -N to close nc again after the file has EOF'd.

Looks marklar to me!

Aside from these two nits, I think it would be best to do s/a\.out/progname/g as a.out is only supported via COMPAT_43 on FreeBSD, and - as far as I know - isn't used anymore. This also has the added benefit of bringing it in line with the example used just above the section where a.out is currently mentioned.

In D21886#556542, @hselasky wrote:

In D21886#556496, @debdrup wrote:

I've been using this script for about a week, and it does exactly what it says on the tin.
Since devfs.conf only gets read on boot, I think handling this script via devd is the perfect way to handle devices that can disappear and reappear.

Would be fantastic if it could be merged, others can enjoy it. :)

Are you using this patch or script?

I've been using this script for about a week, and it does exactly what it says on the tin.
Since devfs.conf only gets read on boot, I think handling this script via devd is the perfect way to handle devices that can disappear and reappear.

Looks good to me :)

Minor nit, that I'm not absolutely sure about.

I thought I had run lint, but you've pretty much proved I didn't. My apologies, and deep thanks.

I wonder if it would be appropriate to ask @woodsb02 whether his instructions on https://wiki.freebsd.org/BenWoods/DebuggingPorts could be added as a section of this handbook page, or perhaps a note made about it instructing the user to look at the wiki? It seems very appropriate, as otherwise, people might not know how to get debugging symbols for third party programs supplied by ports.
Additionally, should there also be a section noting that debugging symbols for -RELEASE is included in the base-dbg and kernel-dbg distribution sets available on all installation media but -bootonly and -memdisk-mini images? People building from source might also need to be directed towards the appropriate page.

Did you mean to add some reviewers for this too? :)
Looks like @rwatson might have some thoughts on this :)

Minor nits only.

Thank you very much :)

For what it's worth (not much, since I'm not yet a doc commiter), the manual page looks good.

Remove BUGS section

Add licese, taken from commiters guide and bump .Dd

Bumping this, in the hopes it doesn't get lost.

Adding the diff via the website apparently accepts the key, whereas php-arcanist fails silently.

Syntactically and lexicographically, this makes sense to me.
As to whether it matters kernel-defined behavior, that's outside my area of expertise.

For compatibility's sake, I think using <br /> (ie. a space between r and forward-slash) is better.
Some older browsers require and while newer browsers seem to do fine with either, they certainly don't complain.

Cross-reference man-pages listed in this document

I must've missed .Fx on a separate line the first time around.

Fix .Fx macro to be on its own line

Replace Xr with Nm as it, at least in less, bolds the commands making it easier to read.

Glad to have so many reviews :)

Remove ministat, add stat, remove erroneous comma, wordsmithed the history section, and addressed issue to clarify that FreeBSD base contains more than just man-pages.

In D24417#537074, @allanjude wrote:

Not sure if ministat belongs on the list. It is more for doing statistical analysis, it doesn't actually give you any stats/status about your system

I believe I've addressed the issues.

Address typo, .Fx, macro usage, s/Cm/Xr/g, capitalization, inconsistent period, and wordsmithed a bit.

There is a generated html file of the first version of the man-page available here.

I was unsure about bumping the $FreeBSD line so I opted not to.
Is there documentation for when it should be updated?

I already did correcting and typo passes when commiting/merging these to the freebsd/freebsd-quarterly github repo, so it has my implicit approval. :)

Looks good to me now.

For the entire document, please do s/screenreader-friendly/screen-reader friendly/g so that it uses the same verbiage.

According to mdoc(7), the .Li macro is deprecated - should Ql be used instead?

Anyone who's still using tcsh after all these years might recognize that export is a Bourne shell thing - but it's absolutely vital that it's documented in case new people come along.

I don't wish to cause unnecessary noise, but it seems the accepted-status got lost in bumping things, so I'm wondering if you lost track of this review as I did?

I hope it's okay that I'm (apparently) combining two reviews into one? Or should I resubmit on each? I thought arc could handle multiple outstanding reviews, but apparently not.

Added recently discovered filename tag around /dev

Looks good to me, but I'll defer to other people to approve.
You might also wanna check with igor, as mentioned on IRC.

Add some examples as suggested by cress.

When you get around to it, you're welcome to commit this - as I don't have src access. :)

Edited the date of the man-page.

I think it might be a good idea to add the docs group as reviewers for this.

Feel free to commit at your leisure then - since I still don't have svn access, just project membership (that I need to get setup).

If the VM high watermark levels are tweaked, OOM from ZFS on swap can be entirely avoided. Don't know if this is relevant?

The description of what it does makes sense, although I can't spot if that's actually what the code does.
Otherwise, LGTM.

I think you need to actually add them as reviewers?

The feedback I provided on the git repo has been fixed, so I'm more than happy with this change. I don't have permission to accept nor commit it, though.

I can't help with the review itself, but the least I can do for this excellent idea is to remind you that you'll want to add some reviewers so that your code can be reviewed. :)