Page MenuHomeFreeBSD

ftw.3: Add examples
Needs ReviewPublic

Authored by 0mp on Sep 22 2019, 12:31 PM.

Details

Reviewers
bcr
Group Reviewers
manpages
Summary
Test Plan

The example compiles and runs just fine.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 26617
Build 24995: arc lint + arc unit

Event Timeline

0mp created this revision.Sep 22 2019, 12:31 PM

The description of what it does makes sense, although I can't spot if that's actually what the code does.
Otherwise, LGTM.

jilles added a subscriber: jilles.Sep 22 2019, 1:41 PM
jilles added inline comments.
lib/libc/gen/ftw.3
162

Given that POSIX.1-2008tc2 says that ftw() is obsolete and applications should use nftw() instead, it seems better to have the example use nftw() instead.

163

can be used.

189

Not having a default in this switch feels somewhat uncomfortable, especially because POSIX says FTW_SL is a valid value here.