Paths

Table of Contentst

Differential D21750

ftw.3: Add examples
ClosedPublic
Actions

Authored by 0mp on Sep 22 2019, 12:31 PM.

Tags

None

Referenced Files

	F106860439: D21750.id67710.diff
	Mon, Jan 6, 1:38 PM

	Unknown Object (File)
	Sun, Jan 5, 9:08 PM

	Unknown Object (File)
	Thu, Dec 26, 7:15 PM

	Unknown Object (File)
	Thu, Dec 26, 5:01 PM

	Unknown Object (File)
	Wed, Dec 25, 5:25 PM

	Unknown Object (File)
	Tue, Dec 24, 9:05 PM

	Unknown Object (File)
	Mon, Dec 23, 1:59 PM

	Unknown Object (File)
	Dec 2 2024, 4:33 AM

View All 63 Files

Subscribers

Details

Reviewers

bcr
jilles

Group Reviewers

Commits

rS359128: MFC 358674, 358916:
rS359127: MFC 358674, 358916: Add examples to ftw.3
rS358674: ftw.3: Add examples

Summary

ftw.3: Add examples

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=173448

Test Plan

The example compiles and runs just fine.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

0mp created this revision.Sep 22 2019, 12:31 PM

Herald added a reviewer: manpages. · View Herald TranscriptSep 22 2019, 12:31 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B26617: Diff 62417.Sep 22 2019, 12:31 PM

The description of what it does makes sense, although I can't spot if that's actually what the code does.
Otherwise, LGTM.

jilles added a subscriber: jilles.Sep 22 2019, 1:41 PM

jilles added inline comments.

lib/libc/gen/ftw.3
162 ↗	(On Diff #62417)	Given that POSIX.1-2008tc2 says that ftw() is obsolete and applications should use nftw() instead, it seems better to have the example use nftw() instead.
163 ↗	(On Diff #62417)	can be used.
189 ↗	(On Diff #62417)	Not having a default in this switch feels somewhat uncomfortable, especially because POSIX says `FTW_SL` is a valid value here.

0mp planned changes to this revision.Feb 1 2020, 10:26 AM

Use nftw instead of ftw

Harbormaster completed remote builds in B29133: Diff 67710.Feb 3 2020, 4:29 PM

The example now uses nftw() instead of ftw().

Is is ready now?

lib/libc/gen/ftw.3
162 ↗	(On Diff #62417)	Great idea! Thanks!
163 ↗	(On Diff #62417)	Done!
189 ↗	(On Diff #62417)	I've included all the types now into the switch.

0mp marked 3 inline comments as done.Feb 4 2020, 8:50 AM

jilles added inline comments.Feb 4 2020, 11:02 PM

lib/libc/gen/ftw.3
189 ↗	(On Diff #62417)	Especially for example code it would be better to have defined behaviour for all values of `typeflag`. Consider that people might copy and paste.

0mp added inline comments.Feb 12 2020, 1:11 PM

lib/libc/gen/ftw.3
189 ↗	(On Diff #62417)	@jilles, Hmmm, the example now has a case statement for every possible value of `typeflag`. I think I don't understand your comment. Am I missing something?

jilles added inline comments.Feb 12 2020, 10:51 PM

lib/libc/gen/ftw.3
189 ↗	(On Diff #62417)	Paranoia in case the code is edited to remove cases or to add a flag (that does not exist yet) requesting a new `typeflag` value. Initializing `type` or adding a default would avoid that.

0mp planned changes to this revision.Feb 18 2020, 11:35 AM

Add a default case to the switch statement

Harbormaster completed remote builds in B29720: Diff 69060.Mar 2 2020, 10:43 AM

jilles accepted this revision.Mar 4 2020, 9:06 PM

This revision is now accepted and ready to land.Mar 4 2020, 9:06 PM

bcr accepted this revision.Mar 5 2020, 9:52 AM

Closed by commit rS358674: ftw.3: Add examples (authored by 0mp). · Explain WhyMar 5 2020, 2:52 PM

This revision was automatically updated to reflect the committed changes.

0mp added a commit: rS358674: ftw.3: Add examples.

0mp added a commit: rS359127: MFC 358674, 358916: Add examples to ftw.3.Mar 19 2020, 10:32 AM

0mp added a commit: rS359128: MFC 358674, 358916:.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

gen/

61 lines

Diff 69217

head/lib/libc/gen/ftw.3

Loading...