If this is a copy of an existing port, create the new port using svn copy (as this is what committers will have to do). Also have the benefits of that copy being tracked and displayed in the phabricator differential, and showing the diffs to the original source (so we know whats been updated/changed, rather than everything being new)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 12 2019
Personally I'd go with changing the pyqt format to the more consistently used in the tree <component>:<target> format but that's a more invasive change requiring a substantial amount of existing port churn. It would be good as a second step evolution of pyqt.mk to bring it in line with the rest of the framework
Nov 11 2019
Uses/pyqt.mk should grow either standard support for :[build,run,test] args, or if it cant in its current state (it currently supports a <component>[_build|_run] format), then it should support <component>[_test] too, allowing those dependencies to be set only as test dependencies
Nov 2 2019
Nov 1 2019
Oct 7 2019
Oct 6 2019
Oct 2 2019
Oct 1 2019
Sep 30 2019
Sep 25 2019
Sep 24 2019
Sep 18 2019
I'm not C savvy, so probably not appropriate for review (but thanks for adding me so I was aware of the change)
Sep 16 2019
Sep 15 2019
Sep 11 2019
Sep 7 2019
Sep 6 2019
Thank you for taking care of this @dbaio
Looks good, thank you for looking after this @dbaio
Sep 2 2019
Aug 27 2019
LGTM if it passes QA (portlint, poudriere (py 2/3), make test)
In D21229#466138, @Vladimir.Chukharev_gmail.com wrote:I discussed the tests failure with developers. The source of it is that Qt in FreeBSD uses three dots instead of the unicode ellipsis symbol (supposedly, elidedText() function).
The test has been changed to admit "..." as ellipsis. This will come with the next release.
We can simply ignore the test failure for now. I plan to find the exact place where ellipsis is inserted, and to try using the unicode ellipsis symbol (but don't hold your breath).
Aug 26 2019
@nwhitehorn Looks good!
Aug 25 2019
Aug 23 2019
Aug 19 2019
Aug 16 2019
Also, tests are available upstream (but not in the sdist), but it would be great to be able to QA this complex port properly.
The FreeBSD Python ports policy has recently been updated to clarify USES=python guidelines.
In D20683#462669, @dbaio wrote:In D20683#462167, @koobs wrote:@dbaio Can you add these to the diff please:
- Copies py-fabric -> py-fabric1
- Updates dependents that require fabric < 2 to devel/py-fabric1
Alternatively, create a separate differential for them, and set this as dependent (child) of it
To update this review I'll need to get it with the Commandeer Revision, is that ok ?
Aug 14 2019
@dbaio Can you add these to the diff please:
Aug 12 2019
Aug 10 2019
Aug 3 2019
If the port installs files in shared (for multiple Python verion) locations, port must be concurrent safe
Aug 2 2019
LGTM (previous revision was accepted, with additional comments)
Jul 26 2019
In D17459#456514, @loader wrote:I'm not sure if it's okay to update the OPTION descriptioins in some ports or just keep them as is,
for example, GIT_DESC in www/moinmoincl/Makefile:GIT_DESC= Install git to use git-diff(1) instead of diff(1) for colored output
Jul 23 2019
In D17459#456222, @adamw wrote:Perhaps these could say Git repository support or, even better, Git code repository support.
I'm sick of LibXYZ support descriptions.
In D17459#456234, @loader wrote:In D17459#456127, @koobs wrote:For all options added in Mk/bsd.options.desc.mk I think we should have 'version control` in the description, like
MERCURIAL_DESC= Mercurial version control support
After changing the names in Mk/bsd.options.desc.mk to their full names, update ports that use those names too
Should I also change the SVN_DESC?= Subversion support to SUBVERSION_DESC?= Subversion version control support in Mk/bsdoptions.desc.mk?
Looks OK. Questions:
Jul 22 2019
Mk/bsd.options.desc.mk MAINTAINER is:
For all options added in Mk/bsd.options.desc.mk I think we should have 'version control` in the description, like
Feel free to re-add me as reviewer after updating
Jul 18 2019
Jul 17 2019
Our SVN commit hooks dont like Changes: in commit log messages. Needs to be Changelog: and I'd probably separate software changelog lines from the freebsd commit log attributes section, like:
Jul 15 2019
concurrent should always be used when anything is installed by a package in locations (filenames/pathnames) that are not version-specific, like /usr/local/bin.
Jul 12 2019
Looks good (with minor patch comment), ship it.
Jul 9 2019
Jul 8 2019
Oh, you didn't use my commit log message verbatim ;(~ *tear*
Fixed in pypa/pip today: https://github.com/pypa/pip/issues/1890