tftp: fix two minor Coverity CIDs
ClosedPublic
Actions

Authored by asomers on Sep 17 2019, 11:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 11, 11:17 PM

	Unknown Object (File)
	Mon, Aug 10, 3:25 PM

	Unknown Object (File)
	Sat, Aug 8, 5:33 AM

	Unknown Object (File)
	Thu, Jul 30, 9:22 AM

	Unknown Object (File)
	Thu, Jul 30, 9:19 AM

	Unknown Object (File)
	Tue, Jul 28, 6:32 PM

	Unknown Object (File)
	Sun, Jul 26, 8:31 PM

	Unknown Object (File)
	Sun, Jul 26, 1:50 PM

View All Files

Subscribers

imp

koobs

Details

Reviewers

cem

Commits

rS354163: MFC r353068:
rS353068: tftp: fix two minor Coverity CIDs

Summary

tftp: fix two minor Coverity CIDs

CID 1394842: file descriptor leak in an error path
CID 1007603: single byte array overflow

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Sep 17 2019, 11:18 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 17 2019, 11:18 PM

Harbormaster completed remote builds in B26540: Diff 62242.Sep 17 2019, 11:18 PM

I'm not C savvy, so probably not appropriate for review (but thanks for adding me so I was aware of the change)

koobs removed a reviewer: koobs.Sep 18 2019, 3:43 AM

koobs added a subscriber: koobs.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 3 2019, 8:22 PM

Closed by commit rS353068: tftp: fix two minor Coverity CIDs (authored by asomers). · Explain Why

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS353068: tftp: fix two minor Coverity CIDs.

asomers added a commit: rS354163: MFC r353068:.Oct 30 2019, 1:41 AM

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

tftp/

main.c

3 lines

Diff 62883

View Options

tftp: fix two minor Coverity CIDsClosedPublicActions