- User Since
- Nov 12 2015, 6:20 AM (238 w, 2 d)
Nov 10 2019
The patch looks good to me. And I hope this was clear in the the discussion in PR 239576, though that was not stated explicitly there.
Nov 5 2019
Oct 19 2019
Sep 16 2019
$ DEVELOPER=yes portlint -Ca WARN: Makefile: : use a tab (not space) after a variable name 0 fatal errors and 1 warning found.
Sep 13 2019
Accept corrections from @kai (slightly changed).
Address comments by Kai Knoblich. Thanks, Kai!
Sep 11 2019
Sep 10 2019
Aug 26 2019
I discussed the tests failure with developers. The source of it is that Qt in FreeBSD uses three dots instead of the unicode ellipsis symbol (supposedly, elidedText() function).
The test has been changed to admit "..." as ellipsis. This will come with the next release.
We can simply ignore the test failure for now. I plan to find the exact place where ellipsis is inserted, and to try using the unicode ellipsis symbol (but don't hold your breath).
Aug 20 2019
I tested the new version on my system. There are still some minor issues.
- From portlint:
$ portlint -Ca WARN: Makefile: When USES=pyqt:5 is defined, you must also define USE_PYQT=xxxx 0 fatal errors and 1 warning found.
Aug 13 2019
It seems to me that options can be made more user friendly. Or completely abandoned for now. May be, until pyside is added.
In particular, for py36, the only possible toolkit is QT5, and it comes off by default. Logically, it can be unconditionally used in this flavor.
For py27, there is QT5 and WXGTK. None is selected by default, and I think, at least one is compulsory. Do they both work with traitsui? Or can we choose the better of the two? (I still cannot build it for py27, some deps fail to install with their py36 flavors installed.)
The DEMO option adds some dependencies. Is this useful without demos from examples directory? I cannot get any demo actually show anything, even with the examples...
May 15 2019
A newer version committed.
May 10 2019
Feb 22 2019
I moved 'SVNROOT?=...' to the maintainer section.
Feb 17 2019
Feb 16 2019
Shell I submit a PR to Bugzilla? Or will it be committed directly from here? Provided no more questions arise, of course.
Feb 15 2019
I'm sure I tried to remove flavors, and failed with dependence specification. Then I had problems with same name of pkgnames for flavors.
The first was rather long time ago, and the second, not so long, few months ago. Good progress!
Would be nice to have in Poter's Handbook up-to-date recommendations for flavors for Python...
Feb 13 2019
Feb 12 2019
Sep 4 2016
Everything has been committed.
Mar 14 2016
Sorry, forgot to "svn add" the new ports after getting a new svn working copy (due to OS upgrade).
Mar 12 2016
Probably, better to say it explicitly:
I do not know about any issues with any of the five ports in this review. All five are ready to commit IMO.
Update to the current state.
All license information is filled.
Corresponding PRs in bugzilla are updated, too.
Feb 3 2016
Jan 9 2016
Update devel/py-pyface to 5.0.0.
Jan 2 2016
Dec 21 2015
Have you tested with the post-install: target? It helped me in one of my ports.
I'm travelling at the moment, can't test myself for a while.
Dec 17 2015
I got the following warnings in poudriere:
Dec 11 2015
Change USES=python:2 to USES=python:-2.7
Dec 8 2015
mat, I agree, the change is very simple, and that's why I added ports commiters group (otherwise I'd use only Python group).
On the other hand, Julio Merino has a good point in his opinion that everything is to be reviewed.
My reasoning to create a PR immediately after a review was to put the QA logs to the PR and make cross-references in both of them. I have a feeling, probably false, that QA logs suit better a PR than a review.
Thanks, mat. A PR 205126 is filed as mentioned in my previous comment. Was it wrong to submit a PR before receiving a positive review?
See bug 205126 in Bugzilla for QA tests output.
Dec 7 2015
Review 10830 contains graphics/py-mayavi/files/patch-* files, forgotten in the previous review. These patches fix the problem with plist.
Dec 6 2015
Dec 5 2015
Dec 3 2015
Most of he issues are resolved in the new revision, with two exceptions.
- LICENSE work is made only in commented out lines. I think, without ready documentation it's too complex job for these ports. Or, a least, I need more guidance in this area.
- The dependence from a port with certain OPTION is reverted to what I had in the first revision. I'm still not ready to work on a new (sub)port of math/vtk6. On the other hand, the method I tried in my comment to graphycs/py-mayavi/Makefile (using pkg query) gives answer about packages installed on the system, but not in a jail of poudriere.
Nov 20 2015
Nov 19 2015
Nov 18 2015
Nov 16 2015
OK, I add the review via web interface.
I do not understand why all the files are empty. Is it related to the fact, that I use svn while 'arc diff --create' uses git in its commands:
diff --git a/graphics/py-traitsui/pkg-descr b/graphics/py-traitsui/pkg-descr