[NEW PORT] finance/py-ofxparse: OFX file format parser for Python

[vishwin]

Summary

ofxparse is a parser for Open Financial Exchange (.ofx) format files, written in Python.

PR: 242855
Sponsored by: Wahgwan Industry Limited

Test Plan

• testport: OK
• portlint: OK

Tests included.

[koobs]

Is there a PR to go with this? If so please add it to the revision summary (PR: XXXX)

If not, please create one, adding this review url to the bugs URL field. Without a PR, reviews can 'fall through the cracks'

finance/py-ofxparse/Makefile

26

This isn't necessary when specifying do-test as the target

[koobs]

Could you split the 'testport' results in the TEST PLAN section into explicit py27, py3x poudriere tests. Many packages package differently when built with different versions

Also, does maketest: Pass? Add the summary output to the TEST PLAN sectio0n too

finance/py-ofxparse/Makefile

29

The package defines test_suite in setup.py which enables the setuptools 'test' command.

When packages define this, use ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test unless there is a compelling temporary reason not to (say for example, that invocation method is currently broken)

Failing that method working, the next best method is:

${PYTHON_CMD} -m <module> where target could be nose or pytest et al.

Many packages depend on, or are limited to specific versions of test dependencies, and doing the above, allows you to use the 'package name and version' style TEST_DEPENDS declaration, which the 'binary name' method doesn't allow.

So when changing the do-test invocation, switch the TEST_DEPENDS on nose from the binary to packagename style

[koobs]

Minor formatting nit, the canonical and preferred format for a new port is:

[NEW PORT] category/portname: COMMENT

<pkg-descr>

[koobs]

Feel free to re-add me as reviewer after updating

[vishwin]

use setuptools test_suite

[vishwin]

finance/py-ofxparse/Makefile

29

The documentation said to run nose directly, but it turns out test_suite works too. Switched.

[vishwin]

Hook into INDEX