Page MenuHomeFreeBSD

[NEW PORT] finance/py-ofxparse OFX file format parser for Python
Needs ReviewPublic

Authored by ml_vishwin.info on Jun 13 2019, 7:35 AM.

Details

Reviewers
koobs
Group Reviewers
Python
Summary

ofxparse is a parser for Open Financial Exchange (.ofx) format files, written in Python.

Sponsored by: Wahgwan Industry Limited

Test Plan
  • testport: OK
  • portlint: OK

Tests included.

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24836
Build 23588: arc lint + arc unit

Event Timeline

ml_vishwin.info set the repository for this revision to rP FreeBSD ports repository.Jun 13 2019, 7:35 AM
koobs added a subscriber: koobs.Jun 13 2019, 11:30 AM

Is there a PR to go with this? If so please add it to the revision summary (PR: XXXX)

If not, please create one, adding this review url to the bugs URL field. Without a PR, reviews can 'fall through the cracks'

finance/py-ofxparse/Makefile
25

This isn't necessary when specifying do-test as the target

koobs requested changes to this revision.Jun 13 2019, 11:36 AM

Could you split the 'testport' results in the TEST PLAN section into explicit py27, py3x poudriere tests. Many packages package differently when built with different versions

Also, does maketest: Pass? Add the summary output to the TEST PLAN sectio0n too

finance/py-ofxparse/Makefile
28

The package defines test_suite in setup.py which enables the setuptools 'test' command.

When packages define this, use ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test unless there is a compelling temporary reason not to (say for example, that invocation method is currently broken)

Failing that method working, the next best method is:

${PYTHON_CMD} -m <module> where target could be nose or pytest et al.

Many packages depend on, or are limited to specific versions of test dependencies, and doing the above, allows you to use the 'package name and version' style TEST_DEPENDS declaration, which the 'binary name' method doesn't allow.

So when changing the do-test invocation, switch the TEST_DEPENDS on nose from the binary to packagename style

This revision now requires changes to proceed.Jun 13 2019, 11:36 AM

Minor formatting nit, the canonical and preferred format for a new port is:

[NEW PORT] category/portname: COMMENT

<pkg-descr>
koobs resigned from this revision.Jul 22 2019, 3:32 AM

Feel free to re-add me as reviewer after updating

use setuptools test_suite

ml_vishwin.info marked 2 inline comments as done.Aug 5 2019, 3:26 AM
ml_vishwin.info added inline comments.
finance/py-ofxparse/Makefile
28

The documentation said to run nose directly, but it turns out test_suite works too. Switched.

ml_vishwin.info retitled this revision from New port: finance/py-ofxparse OFX file format parser for Python to [NEW PORT] finance/py-ofxparse OFX file format parser for Python.Aug 5 2019, 3:27 AM
ml_vishwin.info set the repository for this revision to rP FreeBSD ports repository.