Page MenuHomeFreeBSD

sysutils/fusefs-ntfs: Disable UBLIO
Needs ReviewPublic

Authored by koobs on Aug 10 2019, 2:43 AM.

Details

Reviewers
None
Group Reviewers
Contributor Reviewers (ports)
Summary
sysutils/fusefs-ntfs: Disable UBLIO

Disable* the UBLIO port option as it is unmaintained, experimental code for
which there have been bug reports including data corruption when using it. 

Note: the bits to enable and patch NTFS-3g to use UBLIO have been left in
place to enable interested persons to test and potentially bring it back to
a maintained and stable state. To enable UBLIO, add UBLIO to the ports
OPTIONS_DEFINE line.

While I'm here:

OPTIONS:

 - Make UUID functionality (and libuuid dependency) OPTION'al (UUID option
   enabled by default)
 - Add CRYPTO option (Enable crypto related code and utilities), enabled by
   default
 - Add DEBUG option
 - Add EXTRAS option (ntfsdecrypt, ntfsrecover, ntfssecaudit, ntfstruncate,
   ntfsusermap, ntfswipe), enabled by default. EXTRAS implies (ntfsdecrypt
   breaks without) CRYPTO enabled.

PATCHES:

 - Replace pkgconfigdir configure patch with one that adds a
   --with-pkgconfigdir option to configure.ac instead. Add USES=autoreconf
   accordingly. Upstreamable
   
 - Replace configure patch removing the freebsd* error case in
   enable_ntfs_3g check with adding freebsd to list of OS's that get the
   --with-fuse option. Upstreamable.
   
 - Fix missing AM_PATH_LIBGRYPT macro errors by checking for their presence
 
PORT COMPLIANCE:

 - Use install-strip to strip shared libraries/binaries instead of a custom
   post-install target.
 - Respect user/sysctl CFLAGS in configure.ac, in particular to allow for
   -Wno-<warning> overrides.
 - Sort pkg-plist
   
[1] bug 194526, bug 206978

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25772
Build 24345: arc lint + arc unit

Event Timeline

koobs created this revision.Aug 10 2019, 2:43 AM
koobs edited the summary of this revision. (Show Details)Aug 10 2019, 2:43 AM
arrowd added a subscriber: arrowd.Aug 12 2019, 9:25 AM
arrowd added inline comments.
sysutils/fusefs-ntfs/Makefile
32

Just a suggestion - how about adding # UBLIO to make it clear there is a hidden option?

37

Extra tab relative to CRYPTO_DESC.

sysutils/fusefs-ntfs/files/patch-configure.ac
9

A typo?

mat added a comment.Aug 13 2019, 2:08 PM

Please also convert the pkg-message.in file to ucl so that is is only shown on install.

tobik added a subscriber: tobik.Aug 30 2019, 8:15 AM
tobik added inline comments.
sysutils/fusefs-ntfs/files/README.FreeBSD
42–46

This seems weird to me. The option should be discoverable not hidden. Putting up an additional barrier for interested users by hiding it in long documents (README.FreeBSD and the Makefile) that few people will read is artificial and unnecessary. Please just rename the option to something more sensible like UBLIO_EXPERIMENTAL or UBLIO_UNSTABLE and add it back to OPTIONS_DEFINE. The likelihood of users turning it on by accident or due to stale OPTIONS_SET should be minimal to nonexistent. The option could be further warned about by an improved option description and pkg-help.