Thanks!

I think this should be ready to go- upstream has accepted it. Are you happy with it?

Just get rid of this paragraph entirely, and the header in the sample

Remove OPTIONS and replace with flavour

I don't think daemons usually create piddirs- this is very common in ports land. Usually it's because they don't have permission for /var/run, so I guess they can't, but it's certainly not out of the ordinary.

You're quite right. I don't know why my /var/run/dhclient is owned like
that!

Hi Mark,

elftoolchain: stop leaving tempfiles on error

Hold for a bit- it errs on the verbose side, so in the test suite we get unnecessary stderr output. Will add extra checks.

The submitter of ports/238089 has asked for py-pillow to be removed from dependencies unless mono-heapviz is used, as it's a heavy dependency:

Is this OK for you two? @salvadore, if you commit this, please make sure you close https://bugs.freebsd.org/238089?

That's true, but isn't it normal to have 'first affected version' and 'first fixed version'?

I'll agree with Conrad and Jilles in that it's adding a configuration value (needlessly?) and doesn't really do what it's advertised to do anyway.

I'm not sure the /dev/null bit is necessary here now since that was presumably originally to ignore the failed amount of root, in the days before the -A option was a thing. In fact, I think it's undesirable as any errors from umount -A are now something we need to see.

The 'and' makes it explicit to me that 1.6 is affected. You can think of it as 'version 1.6 and versions up to ...', but I know Romance languages like yours are stricter on leaving out nouns than English.

How about,

An en-dash is the correct one to use, but the historical ones don't really need urgently changing now. Maybe some day someone will fix it, but it's not really a big deal :)

You don't touch $FreeBSD$- that's dealt with by Subversion :)

Yup, fine by me.

@dteske, @debdrup isn't a committer, so I was going to do this for him.

I meant, so I could see what it looks like :)

Have you rendered this somewhere? Can't see any issues in the code.

This needs some heavy testing, for which I'm afraid I just don't have the capacity for at the moment. I've been bitten quite hard recently by a 'simple' rc change recently so I'm reluctant to put my stamp on it!

I have a comment on the MAINTAINER line, but agree with @bcr.

They are separate actions, so should be separate commits and therefore separate reviews, but I'm happy to split them this time.

https://www.bayofrum.net/~crees/patches/patch-obsolete-headers-porter.diff

Mat does indeed mean that the paragraph should be removed, and I'm inclined to agree- we don't have any

I'll deal with whitespace separately.

This matches your suggestions.

There are a couple of tagging issues I'll fix before committing, yes.

Looks great. If no one else does so, I'll commit this in a few days when I get a chance.

Ok, no worries, I'll commit when Mat approves.

Docs approval granted. Not sure if Mat wants to comment as it's a bugs part.

Do you have a rendered version? I think the diff is missing a bit.

While I agree with the sentiment, is this definitely policy?

Do you think some actual examples might help? As an example perhaps the shutdown privilege, but can you think of any others?

Please go ahead.

This isn't necessary to make X run in vmware, so including it in xorg-drivers is overkill.

Go ahead.