Page MenuHomeFreeBSD

Switch to umount -A in rc.d/root and document it
Changes PlannedPublic

Authored by 0mp on Apr 14 2020, 10:18 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, Mar 22, 5:16 PM
Unknown Object (File)
Tue, Mar 12, 4:43 PM
Unknown Object (File)
Sun, Mar 10, 3:39 PM
Unknown Object (File)
Fri, Mar 8, 3:32 PM
Unknown Object (File)
Wed, Mar 6, 3:44 PM
Unknown Object (File)
Wed, Mar 6, 8:01 AM
Unknown Object (File)
Fri, Mar 1, 12:01 AM
Unknown Object (File)
Feb 8 2024, 4:13 AM
Subscribers

Details

Reviewers
allanjude
Group Reviewers
Contributor Reviews (src)
Summary
Switch to umount -A in rc.d/root and document it

Our root serivce, which is primarly used to mount the root partition read-write,
is executing `umount -a` at some point. It is somewhat confusing to the users
to see it in a service, which is supposed to mount the partitions. Let's document
the reasoning behind having umount in this service at all. Also, replace `umount -a`
with `umount -A` as we do not intend to umount root anyway.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30491
Build 28243: arc lint + arc unit

Event Timeline

  • Replace umount -a with umount -A
  • Include some reasoning behind having umount there at all.
0mp retitled this revision from Explain umount -a in rc.d/root to Switch to umount -A in rc.d/root and document it.Apr 14 2020, 11:32 AM
0mp edited the summary of this revision. (Show Details)

I'm not sure the /dev/null bit is necessary here now since that was presumably originally to ignore the failed amount of root, in the days before the -A option was a thing. In fact, I think it's undesirable as any errors from umount -A are now something we need to see.

  • Stop silecing stdout and stderr of umount.

I don't know anything about this rc script, sorry.

0mp planned changes to this revision.Jun 18 2020, 11:09 PM

It turns out this is not how umount -A works (https://reviews.freebsd.org/D25351).

Perhaps we should not switch to umount -A but just add a comment for the umount -a command.