Page MenuHomeFreeBSD

elfcopy: stop leaving temporary files on error
ClosedPublic

Authored by crees on Feb 13 2021, 4:33 PM.

Details

Summary

Temporary files were not cleaned up, resulting in $TMPDIR or even
the current directory becoming littered with ecp.* files.

This happened with error and even sometimes on success!

Test Plan

make buildworld

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

crees requested review of this revision.Feb 13 2021, 4:33 PM

Hold for a bit- it errs on the verbose side, so in the test suite we get unnecessary stderr output. Will add extra checks.

elftoolchain: stop leaving tempfiles on error

Temporary files were not cleaned up, resulting in $TMPDIR or even
the current directory becoming littered with ecp.* files.

This happened with error and even sometimes on success!

Obtained from: https://sourceforge.net/p/elftoolchain/code/3918/

I think this should be ready to go- upstream has accepted it. Are you happy with it?

Ah sorry, totally forgotten about this. It seems to be fine, let's get it in then.

This revision is now accepted and ready to land.Mar 3 2021, 4:42 PM