Please remember to bump .Dd, too. Thanks!

Still no context (as in diff context, as in svn diff --diff-cmd=diff -x -U999999 or git diff -U999999 other-branch). But other than the whitespace issues noted, looks good. Please fix those, bump .Dd, and check the patched file with igor -R wpa_cli.8 and mandoc -Tlint wpa_cli.8 before commit.

Please also bump .Dd in getsockopt.2. Thanks!

In D5667#187435, @feld wrote:

I kept "The following parameters" because it's used about 20 times in this file. So unless we want to update the wording for every instance it seems out of place to change the pattern in these two places.

Update for feedback and move examples section before errors section in an unsuccessful attempt to get mandoc to not complain about it. But it's closer than it was.

Updated for feedback.

A quick glance and this looks good, but it's missing any context. Please see https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface

Done through line 494, at which point Phabricator insists I am already editing another comment and so can't add one. Even though I am not. Yay Phabricator! Review continued in a separate batch.

Found one small addition, which does not diminish the the overall awesomeness of this diff!

Updated. The sentence in question now reads (without markup):

Other than the question about the meaning of "executed", I edited and modified the markup, and so will just provide this file:

Man page changes look okay. Please check with igor and mandoc -Tlint before commit. Thanks!

Sorry for the late reply... no major complaints. For the future, remember that "may" usually implies permission ("yes, you may overwrite that file now"), while "might" is usually better to use to say that something might or might not happen: "this function might return a pointer to a random area of memory". Also, try to avoid "the former" or "the latter", because it forces the reader to stop and look back to see which is which.

This diff has no context, so it is difficult to review. Please update the diff with full context as shown in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface

This diff has no context, so it is difficult to review. Please update the diff with full context as shown in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface

In D8362#175166, @mat wrote:

There are more than one commit, the whitespace fixes will go in separate commits.

Some of these are whitespace-only changes. I don't know how many groups have translated this document, though.

I think this is a good idea. To go a step further, would it be more useful to have the tables in major revision descending order? FreeBSD 12 first, then 11, 10, and so on. As it is, most readers will usually have to scroll to near the end.

Looks good to me.

The sheer quantity of this work is amazing. Thank you!

Wow, the rendered version is not only shorter but easier to read. Thank you!

Thank you!

Thank you!

Man page looks good, but please test with mandoc -Tlint and igor -Rbefore commit. Thanks!

In D7612#171511, @avg wrote:

@wblock I remember making them and updating the diff.
I look at this https://reviews.freebsd.org/D7612?vs=21017&id=21295&whitespace=ignore-most#toc and I see the changes.

In D7612#171485, @avg wrote:

In D7612#171482, @wblock wrote:

In D7612#170785, @avg wrote:

@wblock thank you!

You're welcome, but none of them seem to have changed the source.

Apologies, I failed to understand this comment... could you please explain?