update SMB_BWRITE documentation, clarify SMB_BREAD
ClosedPublic
Actions

Authored by avg on Nov 3 2016, 8:47 AM.

Details

Reviewers

jhb
grembo
wblock

Group Reviewers

manpages

Commits

rS308532: update SMB_BWRITE documentation, clarify SMB_BREAD

Summary

After removal of SMB_TRANS some information in the description of SMB_BWRITE has become stale.
E.g., the maximum block size has been restored to 32.

Also, the descriptions of SMB_BREAD and SMB_BWRITE had some incorrect information on the SMBus protocol details.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avg updated this revision to Diff 21966.Nov 3 2016, 8:47 AM

avg retitled this revision from to update SMB_BWRITE documentation, clarify SMB_BREAD.

avg updated this object.

avg edited the test plan for this revision. (Show Details)

avg added reviewers: grembo, jhb, wblock.

Herald added a reviewer: manpages. · View Herald TranscriptNov 3 2016, 8:47 AM

Herald added a subscriber: imp. · View Herald Transcript

avg updated this object.Nov 3 2016, 8:50 AM

avg edited edge metadata.

Closed by commit rS308532: update SMB_BWRITE documentation, clarify SMB_BREAD (authored by avg). · Explain WhyNov 11 2016, 3:16 PM

This revision was automatically updated to reflect the committed changes.

wblock added inline comments.Nov 18 2016, 4:48 PM

head/share/man/man4/smb.4

149

.Em BlockWrite
sends the
.Fa cmd
byte to the device, then the
.Fa wcount
byte, then that many bytes of data from the buffer pointed to by
.Fa wbuf .

159

Maybe a little smoother:

.Em BlockRead
sends the
.Fa cmd
byte to the device, reads the count of data bytes the device will provide,
then reads those data bytes.

Revision Contents
Changeset List

Path

Size

head/

share/

man/

man4/

smb.4

19 lines

Diff 22145

View Options

update SMB_BWRITE documentation, clarify SMB_BREADClosedPublicActions